1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
|
//
// MBShapeSourceTests.m
// integration
//
// Created by Julian Rex on 4/5/18.
// Copyright © 2018 Mapbox. All rights reserved.
//
#import "MGLMapViewIntegrationTest.h"
@interface MGLShapeSourceTests : MGLMapViewIntegrationTest
@end
@implementation MGLShapeSourceTests
- (void)testSettingShapeSourceToNilInRegionDidChange {
NSMutableArray *features = [[NSMutableArray alloc] init];
for (NSUInteger i = 0; i <= 180; i+=5) {
CLLocationCoordinate2D coord[4] = {
CLLocationCoordinate2DMake(round(0), round(i)),
CLLocationCoordinate2DMake(round(20), round(i)),
CLLocationCoordinate2DMake(round(0), round(i / 2 )),
CLLocationCoordinate2DMake(round(20), round(i / 2))};
MGLPolygonFeature *feature = [MGLPolygonFeature polygonWithCoordinates:coord count:4];
[features addObject:feature];
}
MGLShapeSource *shapeSource = [[MGLShapeSource alloc] initWithIdentifier:@"source" features:features options:nil];
[self.style addSource:shapeSource];
MGLFillStyleLayer *layer = [[MGLFillStyleLayer alloc] initWithIdentifier:@"layer" source:shapeSource];
layer.fillOpacity = [NSExpression expressionForConstantValue:@0.5];
[self.style addLayer:layer];
XCTestExpectation *expectation = [self expectationWithDescription:@"regionDidChange expectation"];
expectation.expectedFulfillmentCount = 1;
expectation.assertForOverFulfill = YES;
__weak typeof(self) weakself = self;
__block NSInteger delegateCallCount = 0;
self.regionDidChange = ^(MGLMapView *mapView, MGLCameraChangeReason reason, BOOL animated) {
MGLShapeSourceTests *strongSelf = weakself;
if (!strongSelf)
return;
delegateCallCount++;
// Setting the shapeSource.shape = nil, was causing an infinite loop, so here
// we check for a runaway call. 10 here is arbitrary. We could argue that this
// should check that the call count is only 1, however in this case we particularly
// want to check for the infinite loop.
// See https://github.com/mapbox/mapbox-gl-native/issues/11180
if (delegateCallCount > 10) {
MGLTestFail(strongSelf);
}
else {
shapeSource.shape = nil;
}
[expectation fulfill];
};
// setCenterCoordinate is NOT animated here.
[self.mapView setCenterCoordinate:CLLocationCoordinate2DMake(10.0, 10.0)];
[self waitForExpectations:@[expectation] timeout:5.0];
}
- (void)testSettingShapeSourceToNilInRegionIsChanging {
NSMutableArray *features = [[NSMutableArray alloc] init];
for (NSUInteger i = 0; i <= 180; i+=5) {
CLLocationCoordinate2D coord[4] = {
CLLocationCoordinate2DMake(round(0), round(i)),
CLLocationCoordinate2DMake(round(20), round(i)),
CLLocationCoordinate2DMake(round(0), round(i / 2 )),
CLLocationCoordinate2DMake(round(20), round(i / 2))};
MGLPolygonFeature *feature = [MGLPolygonFeature polygonWithCoordinates:coord count:4];
[features addObject:feature];
}
MGLShapeSource *shapeSource = [[MGLShapeSource alloc] initWithIdentifier:@"source" features:features options:nil];
[self.style addSource:shapeSource];
MGLFillStyleLayer *layer = [[MGLFillStyleLayer alloc] initWithIdentifier:@"layer" source:shapeSource];
layer.fillOpacity = [NSExpression expressionForConstantValue:@0.5];
[self.style addLayer:layer];
XCTestExpectation *expectation = [self expectationWithDescription:@"regionDidChange expectation"];
expectation.expectedFulfillmentCount = 1;
expectation.assertForOverFulfill = YES;
__block NSInteger delegateCallCount = 0;
__weak typeof(self) weakself = self;
self.regionIsChanging = ^(MGLMapView *mapView) {
// See https://github.com/mapbox/mapbox-gl-native/issues/11180
shapeSource.shape = nil;
};
self.regionDidChange = ^(MGLMapView *mapView, MGLCameraChangeReason reason, BOOL animated) {
delegateCallCount++;
if (delegateCallCount > 1) {
MGLTestFail(weakself);
}
[expectation fulfill];
};
// Should take MGLAnimationDuration seconds (0.3)
[self.mapView setCenterCoordinate:CLLocationCoordinate2DMake(10.0, 10.0) animated:YES];
[self waitForExpectations:@[expectation] timeout:1.0];
}
@end
|
