summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Hacked together iOS benching.upstream/start-collision-benchChris Loer2017-11-0814-14/+4302
| | | | | | | | | | | | This commit makes the iOS Bench target render two scenes for 600 frames. 1) 10 second rotation at z13.86 2) 10 second zoom from z10-z14 renderer_impl and RenderSymbolLayer collect timing information and pipe it to std::cout Copy the appropriate section of the console output to a CSV file and analyze away. This commit should re-base conflict free on either start-collision or start-collision-async, but needs some adaptation for master. [skip ci]
* Unbind VAO before binding a GL_ELEMENT_ARRAY_BUFFER.Chris Loer2017-11-081-0/+3
| | | | Fixes the native equivalent of gl-js issue #5620.
* Ignores for the remaining tests that aren't failing locally but still fail ↵upstream/start-collision-todo-todoneChris Loer2017-11-071-1/+5
| | | | on CI.
* 'make test-node-recycle-map' fails if the cross tile symbol index is ↵Chris Loer2017-11-073-0/+11
| | | | re-used, so this commit clears it out for each still frame.
* Fix clang-tidy error.Chris Loer2017-11-071-1/+1
|
* Remove ignores for issues that I'm pretty confident are fixed by ↵Chris Loer2017-11-071-10/+0
| | | | viewport-collision changes.
* Add ignores for two relatively minor test failures.Chris Loer2017-11-071-0/+3
| | | | We may want to address these before merging, but I want to get CI passing so we can start catching regressions.
* Use UnwrappedTileID instead of CanonicalTileID as input to queryRenderedSymbols.Chris Loer2017-11-075-10/+12
| | | | This is necessary for handling the case where the feature is not projected onto the screen for the tile with wrap 0, but is onscreen for a tile with a different wrap.
* Settle on using 'float' as unit for CollisionIndex.Chris Loer2017-11-073-49/+36
| | | | Use mapbox::geometry::envelope to calculate query box instead of rolling our own.
* TODO -> explanation for why we calculate tile distances the way we do.Chris Loer2017-11-071-1/+2
|
* Remove annotation_tile test. This test exercised the pathway that ↵Chris Loer2017-11-072-102/+0
| | | | transferred collision data from the background to the foreground, and that pathway has been removed.
* Fix unit tests that use SymbolBucket.Chris Loer2017-11-072-2/+2
|
* Give up on idea of instantiating a different version of GridIndex for use in ↵Chris Loer2017-11-073-6/+29
| | | | | | FeatureIndex (which could use ints instead of floats and could use a smaller version of IndexedSubfeature). Add explicit constructors for IndexedSubfeatures to keep the symbol vs. non symbol use case clear.
* Remove GridIndex TODOs.Chris Loer2017-11-072-7/+5
| | | | Move 'circle' type from `mapbox::geometry` to `mbgl::geometry` since it's not a GeoJSON type.
* Remove unused `SymbolPlacementType` for icons.Chris Loer2017-11-073-6/+2
|
* I checked and this seems right [skip ci]Ansis Brammanis2017-11-071-1/+0
|
* clear() returns the moved vector to a known stateAnsis Brammanis2017-11-071-1/+0
|
* not hereAnsis Brammanis2017-11-071-2/+0
|
* I think being public is ok hereAnsis Brammanis2017-11-071-7/+1
|
* remove unusedAnsis Brammanis2017-11-073-7/+3
|
* move SymbolInstances to bucket instead of copyingAnsis Brammanis2017-11-073-5/+4
|
* replace placedTextIndices vector with two membersAnsis Brammanis2017-11-074-33/+32
|
* Appease clang-tidy.Chris Loer2017-11-071-1/+1
|
* Fix sanitizer issue caused by adding a duration to TimePoint::max() in ↵Chris Loer2017-11-073-9/+28
| | | | | | MapMode::Still. Make "recent/stale" Placement state private.
* Port fix of gl-js issue #5546 (correct vertical orientation for single-glyph ↵Chris Loer2017-11-071-20/+28
| | | | labels)
* Pull in latest tests from mapbox-gl-js, update ignores.Chris Loer2017-11-072-4/+3
|
* update mapbox-gl-js to fix symbol-spacing/line-closeAnsis Brammanis2017-11-062-0/+32
|
* Fix unit tests:Chris Loer2017-11-063-5/+5
| | | | | | - Include "symbolBucketsChanged" in deciding whether to swap out last placement result for new placement. Even if no cross-tile symbol opacities have changed, we need to swap placements if any of the buckets have changed because the CollisionIndex will contain updated tile IDs. - Offline map fixture was affected by Shaping change from int->float, reset expected - Annotations#QueryFractionalZoomLevels/VisibleFeatures are densely placed enough on a 256px screen to trigger duplicate symbol detection on crossing zoom levels (which leads to some of the markers being hidden). Space out markers to avoid this problem.
* Rename CollisionBoxOpacityAttributes -> CollisionBoxDynamicAttributes.Chris Loer2017-11-066-45/+49
| | | | They're not really about opacity.
* Switch to "one-phase" tile loading:Chris Loer2017-11-065-11/+48
| | | | | | - Don't render tiles that don't have a symbol layer - Remove unused tiles/bucket from the cross tile symbol index - Clear cached "crossTileIDs" from symbol buckets that are removed from the symbol index
* use floats for shaping to fix render tests (#10389)Ansis Brammanis2017-11-062-5/+5
|
* only render one version of each symbolupstream/start-collision-tile-boundsAnsis Brammanis2017-11-032-4/+9
|
* drop symbols outside of tile boundaries earlierAnsis Brammanis2017-11-035-54/+38
|
* throttle placementupstream/start-collision-throttleAnsis Brammanis2017-11-033-7/+22
|
* Remove addressed TODOsChris Loer2017-11-032-5/+1
|
* Fix collision box dynamic updating logic to match tile boundaries used in ↵Chris Loer2017-11-032-20/+25
| | | | collision box generation.
* Fix "scale" and "textPixelRatio" calculations -- both of them need to ↵Chris Loer2017-11-031-3/+2
| | | | include overscaling factor, instead of neither.
* Fix infinite loop when minZoom == 0.Chris Loer2017-11-021-0/+6
|
* Port GL JS logic for generating extra collision circles in overscaled tiles.Chris Loer2017-11-027-20/+30
| | | | Unfortunately only re-enable one of the overscaling render tests -- the "Figueroa St" test works but gives somewhat different results than JS.
* fade symbols across tiles (#10361)Ansis Brammanis2017-11-029-150/+131
|
* Apparently parameter names can collide with method names for gcc?Chris Loer2017-11-012-6/+6
|
* More compiler appeasement.Chris Loer2017-11-011-2/+2
|
* Compiler appeasement.Chris Loer2017-11-012-3/+3
|
* Changes for circle-ci clang-tidy.Chris Loer2017-11-014-4/+5
|
* Add "icon-allow-overlap" to query_style.json in order to preserve test ↵Chris Loer2017-11-011-4/+8
| | | | behavior from when each source did collision detection separately instead of sharing the same index.
* Update unit test stubs to match new collision code.Chris Loer2017-11-014-7/+12
| | | | Disable annotation_tile test -- seems like maybe it makes sense to delete?
* Update Map.Offline unit test with new image fixture reflecting new collision ↵Chris Loer2017-11-011-0/+0
| | | | | | detection. (only glanced at the new results, but they look reasonable)
* GridIndex: add separate "query" method that doesn't return bounding boxes, ↵Chris Loer2017-11-014-12/+17
| | | | | | for use by unit test and FeatureIndex. Also: fix a bug that would cause results to be duplicated for query boxes that completely contained the index.
* Fix "vertexStartIndex" calculation for text symbols.Chris Loer2017-11-012-11/+27
| | | | This probably needs refactoring.
* Make sure to sort all symbol buckets the first time we get them ready for ↵Chris Loer2017-11-012-2/+2
| | | | upload.