diff options
Diffstat (limited to 'src')
-rw-r--r-- | src/mbgl/map/map_impl.cpp | 6 | ||||
-rw-r--r-- | src/mbgl/map/map_impl.hpp | 1 | ||||
-rw-r--r-- | src/mbgl/map/map_options.cpp | 10 | ||||
-rw-r--r-- | src/mbgl/renderer/render_orchestrator.cpp | 4 | ||||
-rw-r--r-- | src/mbgl/renderer/render_orchestrator.hpp | 3 | ||||
-rw-r--r-- | src/mbgl/renderer/renderer.cpp | 4 | ||||
-rw-r--r-- | src/mbgl/renderer/update_parameters.hpp | 5 |
7 files changed, 8 insertions, 25 deletions
diff --git a/src/mbgl/map/map_impl.cpp b/src/mbgl/map/map_impl.cpp index 60d4d6021c..0edc715134 100644 --- a/src/mbgl/map/map_impl.cpp +++ b/src/mbgl/map/map_impl.cpp @@ -17,7 +17,6 @@ Map::Impl::Impl(RendererFrontend& frontend_, mode(mapOptions.mapMode()), pixelRatio(mapOptions.pixelRatio()), crossSourceCollisions(mapOptions.crossSourceCollisions()), - keepRenderData(mapOptions.keepRenderData()), fileSource(std::move(fileSource_)), style(std::make_unique<style::Style>(fileSource, pixelRatio)), annotationManager(*style) { @@ -65,9 +64,8 @@ void Map::Impl::onUpdate() { annotationManager.makeWeakPtr(), fileSource, prefetchZoomDelta, - stillImageRequest.get(), - crossSourceCollisions, - keepRenderData}; + bool(stillImageRequest), + crossSourceCollisions}; rendererFrontend.update(std::make_shared<UpdateParameters>(std::move(params))); } diff --git a/src/mbgl/map/map_impl.hpp b/src/mbgl/map/map_impl.hpp index 56b18e4b2d..416662f9e5 100644 --- a/src/mbgl/map/map_impl.hpp +++ b/src/mbgl/map/map_impl.hpp @@ -59,7 +59,6 @@ public: const MapMode mode; const float pixelRatio; const bool crossSourceCollisions; - const bool keepRenderData; MapDebugOptions debugOptions { MapDebugOptions::NoDebug }; diff --git a/src/mbgl/map/map_options.cpp b/src/mbgl/map/map_options.cpp index 1e93125fd7..4cebb6adab 100644 --- a/src/mbgl/map/map_options.cpp +++ b/src/mbgl/map/map_options.cpp @@ -9,7 +9,6 @@ public: ViewportMode viewportMode = ViewportMode::Default; NorthOrientation orientation = NorthOrientation::Upwards; bool crossSourceCollisions = true; - bool keepRenderData = true; Size size = { 64, 64 }; float pixelRatio = 1.0; }; @@ -55,15 +54,6 @@ bool MapOptions::crossSourceCollisions() const { return impl_->crossSourceCollisions; } -MapOptions& MapOptions::withKeepRenderData(bool keepRenderData_) { - impl_->keepRenderData = keepRenderData_; - return *this; -} - -bool MapOptions::keepRenderData() const { - return impl_->keepRenderData; -} - MapOptions& MapOptions::withNorthOrientation(NorthOrientation orientation) { impl_->orientation = orientation; return *this; diff --git a/src/mbgl/renderer/render_orchestrator.cpp b/src/mbgl/renderer/render_orchestrator.cpp index 985aac98b4..08338ff616 100644 --- a/src/mbgl/renderer/render_orchestrator.cpp +++ b/src/mbgl/renderer/render_orchestrator.cpp @@ -141,10 +141,6 @@ std::unique_ptr<RenderTree> RenderOrchestrator::createRenderTree( if (!isMapModeContinuous) { // Reset zoom history state. zoomHistory.first = true; - if (!updateParameters->keepRenderData && stillImageRequest != updateParameters->stillImageRequest) { - clearData(); - stillImageRequest = updateParameters->stillImageRequest; - } } if (LayerManager::annotationsEnabled) { diff --git a/src/mbgl/renderer/render_orchestrator.hpp b/src/mbgl/renderer/render_orchestrator.hpp index 312b28fd56..7c1abfe1f4 100644 --- a/src/mbgl/renderer/render_orchestrator.hpp +++ b/src/mbgl/renderer/render_orchestrator.hpp @@ -75,11 +75,11 @@ public: void reduceMemoryUse(); void dumpDebugLogs(); + void clearData(); private: bool isLoaded() const; bool hasTransitions(TimePoint) const; - void clearData(); RenderSource* getRenderSource(const std::string& id) const; @@ -127,7 +127,6 @@ private: const bool backgroundLayerAsColor; bool contextLost = false; - const void* stillImageRequest = nullptr; // Vectors with reserved capacity of layerImpls->size() to avoid reallocation // on each frame. diff --git a/src/mbgl/renderer/renderer.cpp b/src/mbgl/renderer/renderer.cpp index 5afbbbd47e..ac2f327a4e 100644 --- a/src/mbgl/renderer/renderer.cpp +++ b/src/mbgl/renderer/renderer.cpp @@ -131,4 +131,8 @@ void Renderer::reduceMemoryUse() { impl->orchestrator.reduceMemoryUse(); } +void Renderer::clearData() { + impl->orchestrator.clearData(); +} + } // namespace mbgl diff --git a/src/mbgl/renderer/update_parameters.hpp b/src/mbgl/renderer/update_parameters.hpp index fbdebc4197..4336fa0972 100644 --- a/src/mbgl/renderer/update_parameters.hpp +++ b/src/mbgl/renderer/update_parameters.hpp @@ -41,12 +41,9 @@ public: const uint8_t prefetchZoomDelta; // For still image requests, render requested - const void* stillImageRequest; + const bool stillImageRequest; const bool crossSourceCollisions; - - // If set, the render data from the previous render calls is kept. - const bool keepRenderData; }; } // namespace mbgl |