diff options
| -rw-r--r-- | platform/ios/CHANGELOG.md | 1 | ||||
| -rw-r--r-- | platform/ios/app/MBXViewController.m | 6 | ||||
| -rw-r--r-- | platform/ios/src/MGLAnnotationView.h | 8 | ||||
| -rw-r--r-- | platform/ios/src/MGLAnnotationView.mm | 2 |
4 files changed, 6 insertions, 11 deletions
diff --git a/platform/ios/CHANGELOG.md b/platform/ios/CHANGELOG.md index 850c5b19b8..64df3dd013 100644 --- a/platform/ios/CHANGELOG.md +++ b/platform/ios/CHANGELOG.md @@ -39,6 +39,7 @@ The 4.0._x_ series of releases will be the last to support iOS 8. The minimum iO ### Annotations +* Changed the default value of `MGLAnnotationView.scalesWithViewingDistance` to `NO`, to improve performance. If your use case involves many annotation views, consider keeping this property disabled. ([#11636](https://github.com/mapbox/mapbox-gl-native/pull/11636)) * Fixed an issue preventing `MGLAnnotationImage.image` from being updated. ([#10372](https://github.com/mapbox/mapbox-gl-native/pull/10372)) * Improved performance of `MGLAnnotationView`-backed annotations that have `scalesWithViewingDistance` enabled. ([#10951](https://github.com/mapbox/mapbox-gl-native/pull/10951)) * Fixed an issue where tapping a group of annotations may not have selected the nearest annotation. ([#11438](https://github.com/mapbox/mapbox-gl-native/pull/11438)) diff --git a/platform/ios/app/MBXViewController.m b/platform/ios/app/MBXViewController.m index b871a459c9..07d684cd64 100644 --- a/platform/ios/app/MBXViewController.m +++ b/platform/ios/app/MBXViewController.m @@ -1810,12 +1810,6 @@ typedef NS_ENUM(NSInteger, MBXSettingsMiscellaneousRows) { // Comment out the pin dropping functionality in the handleLongPress: // method in this class to make draggable annotation views play nice. annotationView.draggable = YES; - - // Uncomment to force annotation view to maintain a constant size when - // the map is tilted. By default, annotation views will shrink and grow - // as they move towards and away from the horizon. Relatedly, annotations - // backed by GL sprites currently ONLY scale with viewing distance. - // annotationView.scalesWithViewingDistance = NO; } else { // orange indicates that the annotation view was reused annotationView.backgroundColor = [UIColor orangeColor]; diff --git a/platform/ios/src/MGLAnnotationView.h b/platform/ios/src/MGLAnnotationView.h index 8006ec3e40..57d97e56c1 100644 --- a/platform/ios/src/MGLAnnotationView.h +++ b/platform/ios/src/MGLAnnotationView.h @@ -169,12 +169,12 @@ MGL_EXPORT value of this property is `NO` or the map’s pitch is zero, the annotation view remains the same size regardless of its position on-screen. - The default value of this property is `YES`. Set this property to `NO` if the - view’s legibility is important. + The default value of this property is `NO`. Keep this property set to `NO` if + the view’s legibility is important. @note Scaling many on-screen annotation views can contribute to poor map - performance. Consider disabling this property if your use case involves - hundreds or thousands of annotation views. + performance. Consider keeping this property disabled if your use case + involves hundreds or thousands of annotation views. */ @property (nonatomic, assign) BOOL scalesWithViewingDistance; diff --git a/platform/ios/src/MGLAnnotationView.mm b/platform/ios/src/MGLAnnotationView.mm index 4585479582..1c53ba507a 100644 --- a/platform/ios/src/MGLAnnotationView.mm +++ b/platform/ios/src/MGLAnnotationView.mm @@ -45,7 +45,7 @@ _lastAppliedScaleTransform = CATransform3DIdentity; _annotation = annotation; _reuseIdentifier = [reuseIdentifier copy]; - _scalesWithViewingDistance = YES; + _scalesWithViewingDistance = NO; _enabled = YES; } |