[tidy] Check modernize-pass-by-value

Ref: http://clang.llvm.org/extra/clang-tidy/checks/modernize-pass-by-value.html

3 files changed, 5 insertions, 5 deletions

diff --git a/test/src/mbgl/test/fixture_log_observer.cpp b/test/src/mbgl/test/fixture_log_observer.cpp
index 302fdc7081..11587be15a 100644
--- a/test/src/mbgl/test/fixture_log_observer.cpp
+++ b/test/src/mbgl/test/fixture_log_observer.cpp
@@ -6,8 +6,8 @@ namespace mbgl {
 FixtureLog::Message::Message(EventSeverity severity_,
                              Event event_,
                              int64_t code_,
-                             const std::string& msg_)
-    : severity(severity_), event(event_), code(code_), msg(msg_) {
+                             std::string msg_)
+    : severity(severity_), event(event_), code(code_), msg(std::move(msg_)) {
 }
 
 bool FixtureLog::Message::operator==(const Message& rhs) const {
diff --git a/test/src/mbgl/test/fixture_log_observer.hpp b/test/src/mbgl/test/fixture_log_observer.hpp
index 1eabe10095..c66cd42f18 100644
--- a/test/src/mbgl/test/fixture_log_observer.hpp
+++ b/test/src/mbgl/test/fixture_log_observer.hpp
@@ -12,7 +12,7 @@ namespace mbgl {
 class FixtureLog {
 public:
     struct Message {
-        Message(EventSeverity severity_, Event event_, int64_t code_, const std::string &msg_);
+        Message(EventSeverity severity_, Event event_, int64_t code_, std::string msg_);
         Message();
 
         bool operator==(const Message& rhs) const;
diff --git a/test/style/filter.cpp b/test/style/filter.cpp
index f8f56d9316..d28ee4a357 100644
--- a/test/style/filter.cpp
+++ b/test/style/filter.cpp
@@ -16,8 +16,8 @@ typedef std::multimap<std::string, mbgl::Value> Properties;
 
 class StubFeature : public GeometryTileFeature {
 public:
-    inline StubFeature(const Properties& properties_, FeatureType type_)
-        : properties(properties_)
+    inline StubFeature(Properties properties_, FeatureType type_)
+        : properties(std::move(properties_))
         , type(type_)
     {}