summaryrefslogtreecommitdiff
path: root/test/style/expression
diff options
context:
space:
mode:
authorBruno de Oliveira Abinader <bruno@mapbox.com>2018-08-12 12:32:49 +0300
committerBruno de Oliveira Abinader <bruno@mapbox.com>2018-10-02 06:16:13 -0700
commit19179e08bc58e10361bdb387122a6db59552b9ec (patch)
treeedf30fe1e0da98f28d0e04de4b3c7605ed1b2b80 /test/style/expression
parent0ef0a9763c2132a3c5b3bf5833622c235e606f29 (diff)
downloadqtlocation-mapboxgl-19179e08bc58e10361bdb387122a6db59552b9ec.tar.gz
[core] Do not constrain on X axis in ConstrainMode::HeightOnly
Diffstat (limited to 'test/style/expression')
-rw-r--r--test/style/expression/expression.test.cpp21
1 files changed, 12 insertions, 9 deletions
diff --git a/test/style/expression/expression.test.cpp b/test/style/expression/expression.test.cpp
index 4c2ec5cf92..bed3d4f063 100644
--- a/test/style/expression/expression.test.cpp
+++ b/test/style/expression/expression.test.cpp
@@ -29,18 +29,21 @@ TEST(Expression, IsExpression) {
for(auto& entry : allExpressions.GetObject()) {
const std::string name { entry.name.GetString(), entry.name.GetStringLength() };
- if (name == "line-progress" ||
- name == "feature-state" ||
- name == "interpolate-hcl" ||
- name == "interpolate-lab" ||
- name == "format") {
- // Not yet implemented
- continue;
- }
JSDocument document;
document.Parse<0>(R"([")" + name + R"("])");
-
const JSValue* expression = &document;
+
+ // TODO: "feature-state": https://github.com/mapbox/mapbox-gl-native/issues/12613
+ // TODO: "interpolate-hcl": https://github.com/mapbox/mapbox-gl-native/issues/8720
+ // TODO: "interpolate-lab": https://github.com/mapbox/mapbox-gl-native/issues/8720
+ // TODO: "format": https://github.com/mapbox/mapbox-gl-native/issues/12612
+ if (name == "feature-state" || name == "interpolate-hcl" || name == "interpolate-lab" || name == "format") {
+ if (expression::isExpression(conversion::Convertible(expression))) {
+ ASSERT_TRUE(false) << "Expression name" << name << "is implemented - please update Expression.IsExpression test.";
+ }
+ continue;
+ }
+
EXPECT_TRUE(expression::isExpression(conversion::Convertible(expression))) << name;
}
}