diff options
| author | John Firebaugh <john.firebaugh@gmail.com> | 2016-01-15 12:40:53 -0800 |
|---|---|---|
| committer | John Firebaugh <john.firebaugh@gmail.com> | 2016-01-21 11:22:11 -0800 |
| commit | c33ed50c98c57ce2f2cf3b971bcf72c4208bf120 (patch) | |
| tree | a45369f797029fa6a7a05511e3c4b051bede9a2a /test/storage/http_cancel.cpp | |
| parent | 1766d7dcbf9482ceac9bff37e0f7f5a4c60b9123 (diff) | |
| download | qtlocation-mapboxgl-c33ed50c98c57ce2f2cf3b971bcf72c4208bf120.tar.gz | |
[core] Eliminate Response::stale and inline Response::isExpired()
Response::isExpired() had subtle and potentially confusing behavior around Seconds::zero(). It's best to inline it and comment why.
Diffstat (limited to 'test/storage/http_cancel.cpp')
| -rw-r--r-- | test/storage/http_cancel.cpp | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/test/storage/http_cancel.cpp b/test/storage/http_cancel.cpp index a20e78fa53..4b6ff75381 100644 --- a/test/storage/http_cancel.cpp +++ b/test/storage/http_cancel.cpp @@ -41,7 +41,6 @@ TEST_F(Storage, HTTPCancelMultiple) { std::unique_ptr<FileRequest> req = fs.request(resource, [&](Response res) { req.reset(); EXPECT_EQ(nullptr, res.error); - EXPECT_EQ(false, res.stale); ASSERT_TRUE(res.data.get()); EXPECT_EQ("Hello World!", *res.data); EXPECT_EQ(Seconds::zero(), res.expires); |