diff options
author | Mikhail Pozdnyakov <mikhail.pozdnyakov@mapbox.com> | 2020-02-11 01:54:05 +0200 |
---|---|---|
committer | Mikhail Pozdnyakov <mikhail.pozdnyakov@mapbox.com> | 2020-02-11 14:34:46 +0200 |
commit | 64e2bcdf4395a1c65cd9faca81f98c4c5d974bd6 (patch) | |
tree | 672f0cb62600314c76c26478d44ebf6d56c96577 /test/sprite/sprite_loader.test.cpp | |
parent | 146e0ac8ed6a287b77505ffdefa9fe77da93eee1 (diff) | |
download | qtlocation-mapboxgl-64e2bcdf4395a1c65cd9faca81f98c4c5d974bd6.tar.gz |
[core] Loading images to style optimization
This change enables attaching images to the style with batches and
avoids massive re-allocations. Thus, it improves UI performance
especially at start-up time.
Diffstat (limited to 'test/sprite/sprite_loader.test.cpp')
-rw-r--r-- | test/sprite/sprite_loader.test.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/test/sprite/sprite_loader.test.cpp b/test/sprite/sprite_loader.test.cpp index 122e711f51..4e68bff505 100644 --- a/test/sprite/sprite_loader.test.cpp +++ b/test/sprite/sprite_loader.test.cpp @@ -17,7 +17,7 @@ using namespace mbgl::style; class StubSpriteLoaderObserver : public SpriteLoaderObserver { public: - void onSpriteLoaded(std::vector<std::unique_ptr<style::Image>>&& images) override { + void onSpriteLoaded(std::vector<Immutable<style::Image::Impl>> images) override { if (spriteLoaded) spriteLoaded(std::move(images)); } @@ -25,7 +25,7 @@ public: if (spriteError) spriteError(error); } - std::function<void (std::vector<std::unique_ptr<style::Image>>&&)> spriteLoaded; + std::function<void(std::vector<Immutable<style::Image::Impl>>)> spriteLoaded; std::function<void (std::exception_ptr)> spriteError; }; @@ -92,7 +92,7 @@ TEST(SpriteLoader, LoadingSuccess) { test.end(); }; - test.observer.spriteLoaded = [&] (std::vector<std::unique_ptr<style::Image>>&& images) { + test.observer.spriteLoaded = [&](std::vector<Immutable<style::Image::Impl>> images) { EXPECT_EQ(images.size(), 367u); test.end(); }; @@ -169,7 +169,7 @@ TEST(SpriteLoader, LoadingCancel) { return optional<Response>(); }; - test.observer.spriteLoaded = [&] (const std::vector<std::unique_ptr<style::Image>>&) { + test.observer.spriteLoaded = [&](std::vector<Immutable<style::Image::Impl>>) { FAIL() << "Should never be called"; }; |