[core] use individual textures for line dash patternsupstream/zmiao-test

This moves the LineAtlas from a shared texture that contained SDF dash patterns to use individual textures.

Previously, the texture space was limited to a texture of 512 pixels height. Dash patterns were never removed (and are still never removed as of this patch), which means that this texture could fill up for styles that use a lot of different dash patterns. In particular, dash patterns for lines with a round line cap take up 15 pixels of texture height, limiting the amount of unique dash patterns to 34. While this was probably enough for rendering a single style, we quickly exhausted this number when reusing the Map object to render different styles.

Instead of a global shared texture, we're now creating individual textures for every dash pattern. These textures are still cached so that we don't need to re-upload the texture on every frame.

1 files changed, 2 insertions, 2 deletions

diff --git a/test/geometry/line_atlas.test.cpp b/test/geometry/line_atlas.test.cpp
index 960e4ad7ad..1d817220e1 100644
--- a/test/geometry/line_atlas.test.cpp
+++ b/test/geometry/line_atlas.test.cpp
@@ -13,7 +13,7 @@ TEST(LineAtlas, Random) {
     std::normal_distribution<float> lengthDistribution(3, 5);
 
     for (size_t it = 0; it < 100; it++) {
-        LineAtlas atlas{ Size{ 128, 1024 } };
+        LineAtlas atlas;
         std::vector<float> dasharray;
         dasharray.reserve(8);
         for (size_t j = 0; j < 100; j++) {
@@ -25,7 +25,7 @@ TEST(LineAtlas, Random) {
             const LinePatternCap patternCap =
                 capStyleDistribution(generator) > 0 ? LinePatternCap::Round : LinePatternCap::Square;
 
-            atlas.addDash(dasharray, patternCap);
+            atlas.getDashPatternTexture(dasharray, dasharray, patternCap);
         }
     }
 }