summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorzmiao <miao.zhao@mapbox.com>2020-02-18 13:06:27 +0200
committerzmiao <miao.zhao@mapbox.com>2020-02-21 21:39:48 +0200
commit6764ab46752681b6bdeb068bdfbc9d4f5313d845 (patch)
treea5bd67cb63ab9e057999c04b6ee6e323cb86e9db /src
parent0cc042434d04989d8450575075fce2958e57bbc0 (diff)
downloadqtlocation-mapboxgl-6764ab46752681b6bdeb068bdfbc9d4f5313d845.tar.gz
[core] Move geometry within algorithm to util
Diffstat (limited to 'src')
-rw-r--r--src/mbgl/style/expression/within.cpp153
-rw-r--r--src/mbgl/util/geometry_within.cpp143
-rw-r--r--src/mbgl/util/geometry_within.hpp19
3 files changed, 168 insertions, 147 deletions
diff --git a/src/mbgl/style/expression/within.cpp b/src/mbgl/style/expression/within.cpp
index dd9c280b89..c5582b4168 100644
--- a/src/mbgl/style/expression/within.cpp
+++ b/src/mbgl/style/expression/within.cpp
@@ -7,6 +7,7 @@
#include <mbgl/util/logging.hpp>
#include <mbgl/util/string.hpp>
+#include <mbgl/util/geometry_within.hpp>
#include <rapidjson/document.h>
#include <mbgl/style/conversion/json.hpp>
@@ -35,144 +36,14 @@ public:
}
};
-void printPolygon(const Polygon<double>& polygon) {
- mbgl::Log::Debug(mbgl::Event::General, "-------Print Polygon------");
- for (auto ring : polygon) {
- auto length = ring.size();
- mbgl::Log::Debug(mbgl::Event::General, "-------Print New ring with size: %d ------", length);
- // loop through every edge of the ring
- for (std::size_t i = 0; i < length - 1; ++i) {
- mbgl::Log::Debug(mbgl::Event::General, "point [%.15f, %.15f],", ring[i].x, ring[i].y);
- }
- }
-}
-
-void printLine(const LineString<double>& lineString) {
- mbgl::Log::Debug(mbgl::Event::General, "-------Print LineString------");
- for (std::size_t i = 0; i < lineString.size(); ++i) {
- mbgl::Log::Debug(mbgl::Event::General, "point [%.15f, %.15f],", lineString[i].x, lineString[i].y);
- }
-}
-
-bool rayIntersect(const mbgl::Point<double>& p, const mbgl::Point<double>& p1, const mbgl::Point<double>& p2) {
- return ((p1.y > p.y) != (p2.y > p.y)) && (p.x < (p2.x - p1.x) * (p.y - p1.y) / (p2.y - p1.y) + p1.x);
-}
-
-// ray casting algorithm for detecting if point is in polygon
-bool pointWithinPolygon(const mbgl::Point<double>& point, const mapbox::geometry::polygon<double>& polygon) {
- bool within = false;
- for (auto ring : polygon) {
- auto length = ring.size();
- // loop through every edge of the ring
- for (std::size_t i = 0; i < length - 1; ++i) {
- if (rayIntersect(point, ring[i], ring[i + 1])) {
- within = !within;
- }
- }
- }
- return within;
-}
-
-bool pointWithinPolygons(const mbgl::Point<double>& point, const mapbox::geometry::multi_polygon<double>& polygons) {
- for (auto polygon : polygons) {
- if (pointWithinPolygon(point, polygon)) return true;
- }
- return false;
-}
-
-bool lineIntersectLine(const mbgl::Point<double>& p1,
- const mbgl::Point<double>& p2,
- const mbgl::Point<double>& q1,
- const mbgl::Point<double>& q2) {
- // precondition is p1, p2 is inside polygon, so p1, p2 is not on line q1->q2
- const auto perp = [](const mbgl::Point<double>& v1, const mbgl::Point<double>& v2) {
- return (v1.x * v2.y - v1.y * v2.x);
- };
-
- // check if p1 and p2 are in different sides of line segment q1->q2
- const auto twoSided = [](const mbgl::Point<double>& p1,
- const mbgl::Point<double>& p2,
- const mbgl::Point<double>& q1,
- const mbgl::Point<double>& q2) {
- double x1, y1, x2, y2, x3, y3;
-
- // q1->p1 (x1, y1), q1->p2 (x2, y2), q1->q2 (x3, y3)
- x1 = p1.x - q1.x;
- y1 = p1.y - q1.y;
- x2 = p2.x - q1.x;
- y2 = p2.y - q1.y;
- x3 = q2.x - q1.x;
- y3 = q2.y - q1.y;
- if ((x1 * y3 - x3 * y1) * (x2 * y3 - x3 * y2) < 0) return true;
- return false;
- };
- auto vectorP = mbgl::Point<double>(p2.x - p1.x, p2.y - p1.y);
- auto vectorQ = mbgl::Point<double>(q2.x - q1.x, q2.y - q1.y);
-
- // check if two segments are parallel or not
- if (perp(vectorQ, vectorP) == 0) return false;
-
- // check if there are intersecting with each other
- // p1 and p2 lie in separate side of segment q1->q2
- // q1 and q2 lie in separate side of segment p1->p2
- if (twoSided(p1, p2, q1, q2) && twoSided(q1, q2, p1, p2)) return true;
- return false;
-}
-
-bool lineIntersectPolygon(const mbgl::Point<double>& p1,
- const mbgl::Point<double>& p2,
- const mapbox::geometry::polygon<double>& polygon) {
- for (auto ring : polygon) {
- auto length = ring.size();
- // loop through every edge of the ring
- for (std::size_t i = 0; i < length - 1; ++i) {
- if (lineIntersectLine(p1, p2, ring[i], ring[i + 1])) {
- // mbgl::Log::Debug(mbgl::Event::General,
- // "intersecting with edge from %.15f to %.15f", i, i+ 1);
- return true;
- }
- }
- }
- return false;
-}
-
-bool lineStringWithinPolygon(const mbgl::LineString<double>& lineString,
- const mapbox::geometry::polygon<double>& polygon) {
- // First, check if endpoints of line are all inside polygon
- for (std::size_t i = 0; i < lineString.size() - 1; ++i) {
- if (!pointWithinPolygon(lineString[i], polygon)) {
- mbgl::Log::Debug(
- mbgl::Event::General, "point %.15f, %.15f is not inside polygon", lineString[i].x, lineString[i].y);
- return false;
- }
- }
-
- // Second, check if there was line segment intersecting polygon edge
- for (std::size_t i = 0; i < lineString.size() - 1; ++i) {
- if (lineIntersectPolygon(lineString[i], lineString[i + 1], polygon)) {
- mbgl::Log::Debug(mbgl::Event::General,
- "---------line [%.15f, %.15f] to [%.15f, %.15f] is not inside polygon",
- lineString[i].x,
- lineString[i].y,
- lineString[i + 1].x,
- lineString[i + 1].y);
- return false;
- }
- }
-
- mbgl::Log::Debug(mbgl::Event::General, "---------line is inside polygon, line point size: %d: ", lineString.size());
- return true;
-}
-
bool pointsWithinPolygons(const mbgl::GeometryTileFeature& feature,
const mbgl::CanonicalTileID& canonical,
const mbgl::GeoJSON& geoJson) {
return geoJson.match(
[&feature, &canonical](const mapbox::geometry::geometry<double>& geometrySet) -> bool {
mbgl::Feature f(geometrySet);
-
- PolygonFeature polyFeature(f, canonical);
- auto refinedGeoSet = convertGeometry(polyFeature, canonical);
+ PolygonFeature polyFeature(f, CanonicalTileID(0, 0, 0));
+ auto refinedGeoSet = convertGeometry(polyFeature, CanonicalTileID(0, 0, 0));
return refinedGeoSet.match(
[&feature, &canonical](const mapbox::geometry::multi_polygon<double>& polygons) -> bool {
return convertGeometry(feature, canonical)
@@ -185,9 +56,7 @@ bool pointsWithinPolygons(const mbgl::GeometryTileFeature& feature,
return pointWithinPolygons(p, polygons);
});
},
- [](const auto&) -> bool {
- return false;
- });
+ [](const auto&) -> bool {return false;});
},
[&feature, &canonical](const mapbox::geometry::polygon<double>& polygon) -> bool {
return convertGeometry(feature, canonical)
@@ -207,12 +76,7 @@ bool pointsWithinPolygons(const mbgl::GeometryTileFeature& feature,
[](const auto&) -> bool { return false; });
}
-bool lineStringWithinPolygons(const mbgl::LineString<double>& line, const MultiPolygon<double>& polygons) {
- for (auto polygon : polygons) {
- if (lineStringWithinPolygon(line, polygon)) return true;
- }
- return false;
-}
+
bool linesWithinPolygons(const mbgl::GeometryTileFeature& feature,
const mbgl::CanonicalTileID& canonical,
@@ -228,9 +92,6 @@ bool linesWithinPolygons(const mbgl::GeometryTileFeature& feature,
auto refinedGeoSet = convertGeometry(polyFeature, CanonicalTileID(0, 0, 0));
return refinedGeoSet.match(
[&feature, &canonical](const MultiPolygon<double>& polygons) -> bool {
- for (auto polygon : polygons) {
- printPolygon(polygon);
- }
return convertGeometry(feature, canonical)
.match(
[&polygons](const LineString<double>& line) -> bool {
@@ -248,7 +109,6 @@ bool linesWithinPolygons(const mbgl::GeometryTileFeature& feature,
});
},
[&feature, &canonical](const Polygon<double>& polygon) -> bool {
- printPolygon(polygon);
return convertGeometry(feature, canonical)
.match(
[&polygon](const LineString<double>& line) -> bool {
@@ -312,8 +172,7 @@ EvaluationResult Within::evaluate(const EvaluationContext& params) const {
auto geometryType = params.feature->getType();
// Currently only support Point/Points in Polygon/Polygons
if (geometryType == FeatureType::Point) {
- pointsWithinPolygons(*params.feature, *params.canonical, geoJSONSource);
- return true;
+ return pointsWithinPolygons(*params.feature, *params.canonical, geoJSONSource);
} else if (geometryType == FeatureType::LineString) {
return linesWithinPolygons(*params.feature, *params.canonical, geoJSONSource);
}
diff --git a/src/mbgl/util/geometry_within.cpp b/src/mbgl/util/geometry_within.cpp
new file mode 100644
index 0000000000..0d60a5622b
--- /dev/null
+++ b/src/mbgl/util/geometry_within.cpp
@@ -0,0 +1,143 @@
+#include <mbgl/util/geometry_within.hpp>
+#include <mbgl/util/logging.hpp>
+
+namespace mbgl {
+
+namespace {
+bool rayIntersect(const Point<double>& p, const Point<double>& p1, const Point<double>& p2) {
+ return ((p1.y > p.y) != (p2.y > p.y)) && (p.x < (p2.x - p1.x) * (p.y - p1.y) / (p2.y - p1.y) + p1.x);
+}
+
+// a, b are end point for line segment1, c and d are end points for line segment2
+bool lineIntersectLine(const Point<double>& a,
+ const Point<double>& b,
+ const Point<double>& c,
+ const Point<double>& d) {
+ const auto perp = [](const Point<double>& v1, const Point<double>& v2) {
+ return (v1.x * v2.y - v1.y * v2.x);
+ };
+
+ // check if p1 and p2 are in different sides of line segment q1->q2
+ const auto twoSided = [](const Point<double>& p1,
+ const Point<double>& p2,
+ const Point<double>& q1,
+ const Point<double>& q2) {
+ double x1, y1, x2, y2, x3, y3;
+
+ // q1->p1 (x1, y1), q1->p2 (x2, y2), q1->q2 (x3, y3)
+ x1 = p1.x - q1.x;
+ y1 = p1.y - q1.y;
+ x2 = p2.x - q1.x;
+ y2 = p2.y - q1.y;
+ x3 = q2.x - q1.x;
+ y3 = q2.y - q1.y;
+ if ((x1 * y3 - x3 * y1) * (x2 * y3 - x3 * y2) < 0) return true;
+ return false;
+ };
+
+ auto vectorP = Point<double>(b.x - a.x, b.y - a.y);
+ auto vectorQ = Point<double>(d.x - c.x, d.y - c.y);
+
+ // check if two segments are parallel or not
+ // precondition is end point a, b is inside polygon, if they line a->b is
+ // parallel to edge c->d, then a->b won't intersect with c->d
+ if (perp(vectorQ, vectorP) == 0) return false;
+
+ // check if there are intersecting with each other
+ // a and b lie in separate side of segment c->d
+ // c and d lie in separate side of segment a->b
+ if (twoSided(a, b, c, d) && twoSided(c, d, a, b)) return true;
+ return false;
+}
+
+bool lineIntersectPolygon(const Point<double>& p1,
+ const Point<double>& p2,
+ const Polygon<double>& polygon) {
+ for (auto ring : polygon) {
+ auto length = ring.size();
+ // loop through every edge of the ring
+ for (std::size_t i = 0; i < length - 1; ++i) {
+ if (lineIntersectLine(p1, p2, ring[i], ring[i + 1])) {
+ return true;
+ }
+ }
+ }
+ return false;
+}
+}
+
+void printPolygon(const Polygon<double>& polygon) {
+ mbgl::Log::Debug(mbgl::Event::General, "-------Print Polygon------");
+ for (auto ring : polygon) {
+ auto length = ring.size();
+ mbgl::Log::Debug(mbgl::Event::General, "-------Print New ring with size: %d ------", length);
+ // loop through every edge of the ring
+ for (std::size_t i = 0; i < length - 1; ++i) {
+ mbgl::Log::Debug(mbgl::Event::General, "point [%.15f, %.15f],", ring[i].x, ring[i].y);
+ }
+ }
+}
+
+void printLine(const LineString<double>& lineString) {
+ mbgl::Log::Debug(mbgl::Event::General, "-------Print LineString------");
+ for (std::size_t i = 0; i < lineString.size(); ++i) {
+ mbgl::Log::Debug(mbgl::Event::General, "point [%.15f, %.15f],", lineString[i].x, lineString[i].y);
+ }
+}
+
+// ray casting algorithm for detecting if point is in polygon
+bool pointWithinPolygon(const Point<double>& point, const Polygon<double>& polygon) {
+ bool within = false;
+ for (const auto& ring : polygon) {
+ const auto length = ring.size();
+ // loop through every edge of the ring
+ for (std::size_t i = 0; i < length - 1; ++i) {
+ if (rayIntersect(point, ring[i], ring[i + 1])) {
+ within = !within;
+ }
+ }
+ }
+ return within;
+}
+
+bool pointWithinPolygons(const Point<double>& point, const MultiPolygon<double>& polygons) {
+ for (const auto& polygon : polygons) {
+ if (pointWithinPolygon(point, polygon)) return true;
+ }
+ return false;
+}
+
+
+bool lineStringWithinPolygon(const LineString<double>& line,
+ const Polygon<double>& polygon) {
+ const auto length = line.size();
+ // First, check if endpoints of line are all inside polygon
+ for (std::size_t i = 0; i < length; ++i) {
+ if (!pointWithinPolygon(line[i], polygon)) {
+ mbgl::Log::Debug(mbgl::Event::General, "point %.15f, %.15f is not inside polygon", line[i].x, line[i].y);
+ return false;
+ }
+ }
+
+ // Second, check if there is line segment intersecting polygon edge
+ for (std::size_t i = 0; i < length - 1; ++i) {
+ if (lineIntersectPolygon(line[i], line[i + 1], polygon)) {
+ mbgl::Log::Debug(mbgl::Event::General,
+ "---------line [%.15f, %.15f] to [%.15f, %.15f] is not inside polygon",
+ line[i].x,
+ line[i].y,
+ line[i + 1].x,
+ line[i + 1].y);
+ return false;
+ }
+ }
+ return true;
+}
+
+bool lineStringWithinPolygons(const LineString<double>& line, const MultiPolygon<double>& polygons) {
+ for (const auto& polygon : polygons) {
+ if (lineStringWithinPolygon(line, polygon)) return true;
+ }
+ return false;
+}
+}
diff --git a/src/mbgl/util/geometry_within.hpp b/src/mbgl/util/geometry_within.hpp
new file mode 100644
index 0000000000..fe9312cd4a
--- /dev/null
+++ b/src/mbgl/util/geometry_within.hpp
@@ -0,0 +1,19 @@
+#pragma once
+#include <mbgl/util/geometry.hpp>
+
+namespace mbgl {
+
+void printPolygon(const Polygon<double>& polygon);
+
+void printLine(const LineString<double>& lineString);
+
+// ray casting algorithm for detecting if point is in polygon
+bool pointWithinPolygon(const Point<double>& point, const Polygon<double>& polygon);
+
+bool pointWithinPolygons(const Point<double>& point, const MultiPolygon<double>& polygons);
+
+bool lineStringWithinPolygon(const LineString<double>& lineString,
+ const Polygon<double>& polygon);
+
+bool lineStringWithinPolygons(const LineString<double>& line, const MultiPolygon<double>& polygons);
+}