[core] SymbolBucket updates complete at placement stage

`RenderSymbolLayer` does not have to update dynamic vertices of its buckets, this logic is moved to placement (which is already updates opacity vertices).

* fixes clustering of labels when text variable placement enabled - as assignes `usesVariablePlacement` per bucket
* simplifies the code in `RenderSymbolLayer` (the `RenderSymbolLayer::upload()`	is now omitted).
* symbol buckets are not modified after orchestration finishes

1 files changed, 0 insertions, 5 deletions

diff --git a/src/mbgl/renderer/upload_parameters.hpp b/src/mbgl/renderer/upload_parameters.hpp
index 0328309927..14da1026c6 100644
--- a/src/mbgl/renderer/upload_parameters.hpp
+++ b/src/mbgl/renderer/upload_parameters.hpp
@@ -7,23 +7,18 @@ namespace mbgl {
 
 class TransformState;
 class LineAtlas;
-class VariableOffset;
-using VariableOffsets = std::unordered_map<uint32_t, VariableOffset>;
 
 class UploadParameters {
 public:
     UploadParameters(const TransformState& state_,
-                     const VariableOffsets& variableOffsets_,
                      ImageManager& imageManager_,
                      LineAtlas& lineAtlas_)
         : state(state_),
-          variableOffsets(variableOffsets_),
           imageManager(imageManager_),
           lineAtlas(lineAtlas_) {
     }
 
     const TransformState& state;
-    const VariableOffsets& variableOffsets;
     ImageManager& imageManager;
     LineAtlas& lineAtlas;
 };