summaryrefslogtreecommitdiff
path: root/src/mbgl/renderer/painters
diff options
context:
space:
mode:
authorJohn Firebaugh <john.firebaugh@gmail.com>2017-06-13 16:04:13 -0700
committerJohn Firebaugh <john.firebaugh@gmail.com>2017-06-14 11:14:05 -0700
commitfd45242d05e496d24b814a567c3f24a4c82b499f (patch)
treeb56ed3571adf3885f3d8dde768b3c93937c615ae /src/mbgl/renderer/painters
parent12279b5dcc4205d1b96ae4374322ed40735a2836 (diff)
downloadqtlocation-mapboxgl-fd45242d05e496d24b814a567c3f24a4c82b499f.tar.gz
[core] Don't use "current" icon/text-size when binding
The current value is not passed to `SymbolSizeBinder::uniformValues`, so we shouldn't check `currentValue.isConstant()` in `SymbolSizeBinder::attributeBindings`. If it were true, then we might end up using attribute bindings that are appropriate only for a constant property, but uniform bindings that are appropriate only for a source or composite function. Instead, just wait for a new bucket to be generated. This will happen automatically, since icon/text-size are layout properties.
Diffstat (limited to 'src/mbgl/renderer/painters')
-rw-r--r--src/mbgl/renderer/painters/painter_symbol.cpp1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/mbgl/renderer/painters/painter_symbol.cpp b/src/mbgl/renderer/painters/painter_symbol.cpp
index ee5e8c7e2f..d3a505aa3f 100644
--- a/src/mbgl/renderer/painters/painter_symbol.cpp
+++ b/src/mbgl/renderer/painters/painter_symbol.cpp
@@ -53,7 +53,6 @@ void Painter::renderSymbol(PaintParameters& parameters,
std::move(uniformValues),
*buffers.vertexBuffer,
*symbolSizeBinder,
- values_.layoutSize,
*buffers.indexBuffer,
buffers.segments,
binders,