[core] Reduce use of RecalculateStyle

* Don't use it to track zoom changes. Instead, Style::update can use the zoom history to check for a change in zoom from the previous frame.
* Don't use it to track active property transitions. Style already knows which layers/light have an active transition, and can re-evaluate only those that do.

This leaves layer property changes as the only use of RecalculateStyle.

1 files changed, 3 insertions, 4 deletions

diff --git a/src/mbgl/map/transform.hpp b/src/mbgl/map/transform.hpp
index 2c59a6c1aa..af2f821602 100644
--- a/src/mbgl/map/transform.hpp
+++ b/src/mbgl/map/transform.hpp
@@ -4,7 +4,6 @@
 #include <mbgl/map/map_observer.hpp>
 #include <mbgl/map/mode.hpp>
 #include <mbgl/map/transform_state.hpp>
-#include <mbgl/map/update.hpp>
 #include <mbgl/util/chrono.hpp>
 #include <mbgl/util/geo.hpp>
 #include <mbgl/util/noncopyable.hpp>
@@ -128,7 +127,7 @@ public:
 
     // Transitions
     bool inTransition() const;
-    Update updateTransitions(const TimePoint& now);
+    void updateTransitions(const TimePoint& now);
     TimePoint getTransitionStart() const { return transitionStart; }
     Duration getTransitionDuration() const { return transitionDuration; }
     void cancelTransitions();
@@ -153,12 +152,12 @@ private:
 
     void startTransition(const CameraOptions&,
                          const AnimationOptions&,
-                         std::function<Update(double)>,
+                         std::function<void(double)>,
                          const Duration&);
 
     TimePoint transitionStart;
     Duration transitionDuration;
-    std::function<Update(const TimePoint)> transitionFrameFn;
+    std::function<void(const TimePoint)> transitionFrameFn;
     std::function<void()> transitionFinishFn;
 };