summaryrefslogtreecommitdiff
path: root/render-test/runner.cpp
diff options
context:
space:
mode:
authorThiago Marcos P. Santos <tmpsantos@gmail.com>2019-10-13 17:49:49 +0300
committerThiago Marcos P. Santos <tmpsantos@gmail.com>2019-10-14 21:15:21 +0300
commit8b3a222c81abdfacddd6019135c1f655273ecaa5 (patch)
tree00c47bb213ace068a0da1bc5b5e67f628c946d4d /render-test/runner.cpp
parent2187980a871cc22f59c1078a949e42db0ab7c1a2 (diff)
downloadqtlocation-mapboxgl-8b3a222c81abdfacddd6019135c1f655273ecaa5.tar.gz
[render-test] Add tolerance to file-size tests
Diffstat (limited to 'render-test/runner.cpp')
-rw-r--r--render-test/runner.cpp9
1 files changed, 6 insertions, 3 deletions
diff --git a/render-test/runner.cpp b/render-test/runner.cpp
index 103a14a079..3594c9488b 100644
--- a/render-test/runner.cpp
+++ b/render-test/runner.cpp
@@ -258,7 +258,8 @@ bool TestRunner::checkRenderTestResults(mbgl::PremultipliedImage&& actualImage,
return false;
}
- if (actual->second.size != expected.second.size) {
+ auto result = checkValue(expected.second.size, actual->second.size, actual->second.tolerance);
+ if (!std::get<bool>(result)) {
std::stringstream ss;
ss << "File size does not match at probe \"" << expected.first << "\": " << actual->second.size
<< ", expected is " << expected.second.size << ".";
@@ -574,14 +575,16 @@ bool TestRunner::runOperations(const std::string& key, TestMetadata& metadata) {
}
} else if (operationArray[0].GetString() == fileSizeProbeOp) {
// probeFileSize
- assert(operationArray.Size() >= 3u);
+ assert(operationArray.Size() >= 4u);
assert(operationArray[1].IsString());
assert(operationArray[2].IsString());
+ assert(operationArray[3].IsNumber());
std::string mark = std::string(operationArray[1].GetString(), operationArray[1].GetStringLength());
std::string path = std::string(operationArray[2].GetString(), operationArray[2].GetStringLength());
assert(!path.empty());
+ float tolerance = operationArray[3].GetDouble();
mbgl::filesystem::path filePath(path);
if (!filePath.is_absolute()) {
@@ -592,7 +595,7 @@ bool TestRunner::runOperations(const std::string& key, TestMetadata& metadata) {
auto size = mbgl::filesystem::file_size(filePath);
metadata.metrics.fileSize.emplace(std::piecewise_construct,
std::forward_as_tuple(std::move(mark)),
- std::forward_as_tuple(std::move(path), size));
+ std::forward_as_tuple(std::move(path), size, tolerance));
} else {
metadata.errorMessage = std::string("File not found: ") + path;
return false;