summaryrefslogtreecommitdiff
path: root/platform
diff options
context:
space:
mode:
authorMike Morris <michael.patrick.morris@gmail.com>2015-09-15 13:27:45 -0400
committerMike Morris <michael.patrick.morris@gmail.com>2015-09-15 13:29:46 -0400
commita101ab4cf5d3bec88dde0255c6a1b9fad8a86383 (patch)
treee02ccb305cc019fc63c6a1e0fa67a107f6850226 /platform
parenta3ea4acb7cb4d57ca2f5808b9b600d7c1b7b3cc7 (diff)
downloadqtlocation-mapboxgl-a101ab4cf5d3bec88dde0255c6a1b9fad8a86383.tar.gz
[node] throw if a render is already pending, fixes #2247
Diffstat (limited to 'platform')
-rw-r--r--platform/node/src/node_map.cpp4
-rw-r--r--platform/node/test/js/map.test.js8
2 files changed, 6 insertions, 6 deletions
diff --git a/platform/node/src/node_map.cpp b/platform/node/src/node_map.cpp
index 5b2a839164..f1abf48066 100644
--- a/platform/node/src/node_map.cpp
+++ b/platform/node/src/node_map.cpp
@@ -186,6 +186,10 @@ NAN_METHOD(NodeMap::Render) {
return Nan::ThrowTypeError("Style is not loaded");
}
+ if (nodeMap->callback) {
+ return Nan::ThrowError("Map is currently rendering an image");
+ }
+
auto options = ParseOptions(info[0]->ToObject());
assert(!nodeMap->callback);
diff --git a/platform/node/test/js/map.test.js b/platform/node/test/js/map.test.js
index 295fec6937..1581d15cb7 100644
--- a/platform/node/test/js/map.test.js
+++ b/platform/node/test/js/map.test.js
@@ -266,18 +266,14 @@ test('Map', function(t) {
render();
});
- t.skip('throws if called in parallel', function(t) {
- var completed = 0;
- var remaining = 10;
- var start = +new Date;
-
+ t.test('throws if called in parallel', function(t) {
var map = new mbgl.Map(options);
map.load(style);
t.throws(function() {
map.render({}, function() {});
map.render({}, function() {});
- });
+ }, /Map is currently rendering an image/);
map.release();
t.end();