diff options
author | Bruno de Oliveira Abinader <bruno@mapbox.com> | 2016-01-23 14:47:17 +0200 |
---|---|---|
committer | Bruno de Oliveira Abinader <bruno@mapbox.com> | 2016-01-25 15:11:18 +0200 |
commit | 2f86467586706d254fcbcb1c88657992214aefcd (patch) | |
tree | 97c34a7c1589ba32cc981b47792983d057c3b996 /platform | |
parent | cc47da5a15650c3f8ede9f7e253e4099dc61673f (diff) | |
download | qtlocation-mapboxgl-2f86467586706d254fcbcb1c88657992214aefcd.tar.gz |
Cleanup std::chrono usage
Use mbgl::Duration and mbgl::{,Milli}Seconds whenever possible.
Diffstat (limited to 'platform')
-rw-r--r-- | platform/android/src/jni.cpp | 26 | ||||
-rw-r--r-- | platform/default/glfw_view.cpp | 7 | ||||
-rw-r--r-- | platform/default/http_request_curl.cpp | 3 | ||||
-rw-r--r-- | platform/default/timer.cpp | 4 | ||||
-rw-r--r-- | platform/ios/src/MGLMapView.mm | 13 | ||||
-rw-r--r-- | platform/osx/src/MGLMapView.mm | 6 |
6 files changed, 31 insertions, 28 deletions
diff --git a/platform/android/src/jni.cpp b/platform/android/src/jni.cpp index 23be6a38f8..cc25ec4da0 100644 --- a/platform/android/src/jni.cpp +++ b/platform/android/src/jni.cpp @@ -560,14 +560,14 @@ void JNICALL nativeSetDefaultTransitionDuration(JNIEnv *env, jobject obj, jlong assert(nativeMapViewPtr != 0); assert(duration >= 0); NativeMapView *nativeMapView = reinterpret_cast<NativeMapView *>(nativeMapViewPtr); - nativeMapView->getMap().setDefaultTransitionDuration(std::chrono::milliseconds(duration)); + nativeMapView->getMap().setDefaultTransitionDuration(mbgl::Milliseconds(duration)); } jlong JNICALL nativeGetDefaultTransitionDuration(JNIEnv *env, jobject obj, jlong nativeMapViewPtr) { mbgl::Log::Debug(mbgl::Event::JNI, "nativeGetDefaultTransitionDuration"); assert(nativeMapViewPtr != 0); NativeMapView *nativeMapView = reinterpret_cast<NativeMapView *>(nativeMapViewPtr); - return std::chrono::duration_cast<std::chrono::milliseconds>(nativeMapView->getMap().getDefaultTransitionDuration()).count(); + return std::chrono::duration_cast<mbgl::Milliseconds>(nativeMapView->getMap().getDefaultTransitionDuration()).count(); } void JNICALL nativeSetStyleURL(JNIEnv *env, jobject obj, jlong nativeMapViewPtr, jstring url) { @@ -627,7 +627,7 @@ void JNICALL nativeMoveBy(JNIEnv *env, jobject obj, jlong nativeMapViewPtr, jdou assert(nativeMapViewPtr != 0); NativeMapView *nativeMapView = reinterpret_cast<NativeMapView *>(nativeMapViewPtr); mbgl::PrecisionPoint center(dx, dy); - nativeMapView->getMap().moveBy(center, std::chrono::milliseconds(duration)); + nativeMapView->getMap().moveBy(center, mbgl::Milliseconds(duration)); } void JNICALL nativeSetLatLng(JNIEnv *env, jobject obj, jlong nativeMapViewPtr, jobject latLng, @@ -684,7 +684,7 @@ void JNICALL nativeSetPitch(JNIEnv *env, jobject obj, jlong nativeMapViewPtr, jd mbgl::Log::Debug(mbgl::Event::JNI, "nativeGetPitch"); assert(nativeMapViewPtr != 0); NativeMapView *nativeMapView = reinterpret_cast<NativeMapView *>(nativeMapViewPtr); - nativeMapView->getMap().setPitch(pitch, std::chrono::milliseconds(duration)); + nativeMapView->getMap().setPitch(pitch, mbgl::Milliseconds(duration)); } void JNICALL nativeScaleBy(JNIEnv *env, jobject obj, jlong nativeMapViewPtr, jdouble ds, jdouble cx, @@ -693,7 +693,7 @@ void JNICALL nativeScaleBy(JNIEnv *env, jobject obj, jlong nativeMapViewPtr, jdo assert(nativeMapViewPtr != 0); NativeMapView *nativeMapView = reinterpret_cast<NativeMapView *>(nativeMapViewPtr); mbgl::PrecisionPoint center(cx, cy); - nativeMapView->getMap().scaleBy(ds, center, std::chrono::milliseconds(duration)); + nativeMapView->getMap().scaleBy(ds, center, mbgl::Milliseconds(duration)); } void JNICALL nativeSetScale(JNIEnv *env, jobject obj, jlong nativeMapViewPtr, jdouble scale, @@ -702,7 +702,7 @@ void JNICALL nativeSetScale(JNIEnv *env, jobject obj, jlong nativeMapViewPtr, jd assert(nativeMapViewPtr != 0); NativeMapView *nativeMapView = reinterpret_cast<NativeMapView *>(nativeMapViewPtr); mbgl::PrecisionPoint center(cx, cy); - nativeMapView->getMap().setScale(scale, center, std::chrono::milliseconds(duration)); + nativeMapView->getMap().setScale(scale, center, mbgl::Milliseconds(duration)); } jdouble JNICALL nativeGetScale(JNIEnv *env, jobject obj, jlong nativeMapViewPtr) { @@ -716,7 +716,7 @@ void JNICALL nativeSetZoom(JNIEnv *env, jobject obj, jlong nativeMapViewPtr, jdo mbgl::Log::Debug(mbgl::Event::JNI, "nativeSetZoom"); assert(nativeMapViewPtr != 0); NativeMapView *nativeMapView = reinterpret_cast<NativeMapView *>(nativeMapViewPtr); - nativeMapView->getMap().setZoom(zoom, std::chrono::milliseconds(duration)); + nativeMapView->getMap().setZoom(zoom, mbgl::Milliseconds(duration)); } jdouble JNICALL nativeGetZoom(JNIEnv *env, jobject obj, jlong nativeMapViewPtr) { @@ -750,7 +750,7 @@ void JNICALL nativeSetLatLngZoom(JNIEnv *env, jobject obj, jlong nativeMapViewPt return; } - nativeMapView->getMap().setLatLngZoom(mbgl::LatLng(latitude, longitude), zoom, std::chrono::milliseconds(duration)); + nativeMapView->getMap().setLatLngZoom(mbgl::LatLng(latitude, longitude), zoom, mbgl::Milliseconds(duration)); } jobject JNICALL nativeGetLatLngZoom(JNIEnv *env, jobject obj, jlong nativeMapViewPtr) { @@ -797,7 +797,7 @@ void JNICALL nativeRotateBy(JNIEnv *env, jobject obj, jlong nativeMapViewPtr, jd NativeMapView *nativeMapView = reinterpret_cast<NativeMapView *>(nativeMapViewPtr); mbgl::PrecisionPoint first(sx, sy); mbgl::PrecisionPoint second(ex, ey); - nativeMapView->getMap().rotateBy(first, second, std::chrono::milliseconds(duration)); + nativeMapView->getMap().rotateBy(first, second, mbgl::Milliseconds(duration)); } void JNICALL nativeSetBearing(JNIEnv *env, jobject obj, jlong nativeMapViewPtr, jdouble degrees, @@ -805,7 +805,7 @@ void JNICALL nativeSetBearing(JNIEnv *env, jobject obj, jlong nativeMapViewPtr, mbgl::Log::Debug(mbgl::Event::JNI, "nativeSetBearing"); assert(nativeMapViewPtr != 0); NativeMapView *nativeMapView = reinterpret_cast<NativeMapView *>(nativeMapViewPtr); - mbgl::Duration duration((std::chrono::milliseconds(milliseconds))); + mbgl::Duration duration((mbgl::Milliseconds(milliseconds))); nativeMapView->getMap().setBearing(degrees, duration); } @@ -1300,7 +1300,7 @@ void JNICALL nativeSetVisibleCoordinateBounds(JNIEnv *env, jobject obj, jlong na } mbgl::AnimationOptions animationOptions; if (duration > 0) { - animationOptions.duration = mbgl::Duration(std::chrono::milliseconds(duration)); + animationOptions.duration.emplace(mbgl::Milliseconds(duration)); // equivalent to kCAMediaTimingFunctionDefault in iOS animationOptions.easing = mbgl::util::UnitBezier(0.25, 0.1, 0.25, 0.1); } @@ -1543,7 +1543,7 @@ void JNICALL nativeEaseTo(JNIEnv *env, jobject obj, jlong nativeMapViewPtr, jdou cameraOptions.zoom = zoom; } mbgl::AnimationOptions animationOptions; - animationOptions.duration = mbgl::Duration(duration); + animationOptions.duration.emplace(mbgl::Duration(duration)); nativeMapView->getMap().easeTo(cameraOptions, animationOptions); } @@ -1577,7 +1577,7 @@ void JNICALL nativeFlyTo(JNIEnv *env, jobject obj, jlong nativeMapViewPtr, jdoub cameraOptions.zoom = zoom; } mbgl::AnimationOptions animationOptions; - animationOptions.duration = mbgl::Duration(duration); + animationOptions.duration.emplace(mbgl::Duration(duration)); nativeMapView->getMap().flyTo(cameraOptions, animationOptions); } diff --git a/platform/default/glfw_view.cpp b/platform/default/glfw_view.cpp index 3103f09831..83e2c65585 100644 --- a/platform/default/glfw_view.cpp +++ b/platform/default/glfw_view.cpp @@ -6,6 +6,7 @@ #include <mbgl/platform/log.hpp> #include <mbgl/util/gl_helper.hpp> #include <mbgl/util/string.hpp> +#include <mbgl/util/chrono.hpp> #include <cassert> #include <cstdlib> @@ -140,7 +141,7 @@ void GLFWView::onKey(GLFWwindow *window, int key, int /*scancode*/, int action, break; case GLFW_KEY_R: if (!mods) { - view->map->setDefaultTransitionDuration(std::chrono::milliseconds(300)); + view->map->setDefaultTransitionDuration(mbgl::Milliseconds(300)); if (view->map->hasClass("night")) { view->map->removeClass("night"); } else { @@ -352,9 +353,9 @@ void GLFWView::onMouseClick(GLFWwindow *window, int button, int action, int modi double now = glfwGetTime(); if (now - view->lastClick < 0.4 /* ms */) { if (modifiers & GLFW_MOD_SHIFT) { - view->map->scaleBy(0.5, { view->lastX, view->lastY }, std::chrono::milliseconds(500)); + view->map->scaleBy(0.5, { view->lastX, view->lastY }, mbgl::Milliseconds(500)); } else { - view->map->scaleBy(2.0, { view->lastX, view->lastY }, std::chrono::milliseconds(500)); + view->map->scaleBy(2.0, { view->lastX, view->lastY }, mbgl::Milliseconds(500)); } } view->lastClick = now; diff --git a/platform/default/http_request_curl.cpp b/platform/default/http_request_curl.cpp index 9cc5815ad1..f7fb27afc5 100644 --- a/platform/default/http_request_curl.cpp +++ b/platform/default/http_request_curl.cpp @@ -8,6 +8,7 @@ #include <mbgl/util/run_loop.hpp> #include <mbgl/util/string.hpp> #include <mbgl/util/timer.hpp> +#include <mbgl/util/chrono.hpp> #include <curl/curl.h> @@ -239,7 +240,7 @@ int HTTPCURLContext::startTimeout(CURLM * /* multi */, long timeout_ms, void *us timeout_ms = 0; } context->timeout.stop(); - context->timeout.start(std::chrono::milliseconds(timeout_ms), Duration::zero(), + context->timeout.start(mbgl::Milliseconds(timeout_ms), Duration::zero(), std::bind(&HTTPCURLContext::onTimeout, context)); return 0; diff --git a/platform/default/timer.cpp b/platform/default/timer.cpp index 4b7a455ccc..473f059133 100644 --- a/platform/default/timer.cpp +++ b/platform/default/timer.cpp @@ -66,8 +66,8 @@ Timer::Timer() Timer::~Timer() = default; void Timer::start(Duration timeout, Duration repeat, std::function<void()>&& cb) { - impl->start(std::chrono::duration_cast<std::chrono::milliseconds>(timeout).count(), - std::chrono::duration_cast<std::chrono::milliseconds>(repeat).count(), + impl->start(std::chrono::duration_cast<Milliseconds>(timeout).count(), + std::chrono::duration_cast<Milliseconds>(repeat).count(), std::move(cb)); } diff --git a/platform/ios/src/MGLMapView.mm b/platform/ios/src/MGLMapView.mm index 5447a10304..3fa5ba78b0 100644 --- a/platform/ios/src/MGLMapView.mm +++ b/platform/ios/src/MGLMapView.mm @@ -24,6 +24,7 @@ #include <mbgl/util/image.hpp> #include <mbgl/util/std.hpp> #include <mbgl/util/default_styles.hpp> +#include <mbgl/util/chrono.hpp> #import "Mapbox.h" #import "../../darwin/MGLGeometry_Private.h" @@ -214,10 +215,9 @@ public: #pragma mark - Setup & Teardown - @dynamic debugActive; - -std::chrono::steady_clock::duration MGLDurationInSeconds(float duration) +mbgl::Duration MGLDurationInSeconds(NSTimeInterval duration) { - return std::chrono::duration_cast<std::chrono::steady_clock::duration>(std::chrono::duration<float, std::chrono::seconds::period>(duration)); + return std::chrono::duration_cast<mbgl::Duration>(std::chrono::duration<NSTimeInterval>(duration)); } - (instancetype)initWithFrame:(CGRect)frame @@ -1083,7 +1083,7 @@ std::chrono::steady_clock::duration MGLDurationInSeconds(float duration) velocity = CGPointZero; } - CGFloat duration = UIScrollViewDecelerationRateNormal; + NSTimeInterval duration = UIScrollViewDecelerationRateNormal; BOOL drift = ! CGPointEqualToPoint(velocity, CGPointZero); if (drift) { @@ -1150,7 +1150,8 @@ std::chrono::steady_clock::duration MGLDurationInSeconds(float duration) { velocity = 0; } - CGFloat duration = velocity > 0 ? 1 : 0.25; + + NSTimeInterval duration = velocity > 0 ? 1 : 0.25; CGFloat scale = self.scale * pinch.scale; CGFloat newScale = scale; @@ -1227,7 +1228,7 @@ std::chrono::steady_clock::duration MGLDurationInSeconds(float duration) if (fabs(velocity) > 3) { CGFloat radians = self.angle + rotate.rotation; - CGFloat duration = UIScrollViewDecelerationRateNormal; + NSTimeInterval duration = UIScrollViewDecelerationRateNormal; CGFloat newRadians = radians + velocity * duration * 0.1; CGFloat newDegrees = MGLDegreesFromRadians(newRadians) * -1; diff --git a/platform/osx/src/MGLMapView.mm b/platform/osx/src/MGLMapView.mm index e1c472409e..3bea3f1139 100644 --- a/platform/osx/src/MGLMapView.mm +++ b/platform/osx/src/MGLMapView.mm @@ -25,6 +25,7 @@ #import <mbgl/util/constants.hpp> #import <mbgl/util/math.hpp> #import <mbgl/util/std.hpp> +#import <mbgl/util/chrono.hpp> #import <map> #import <unordered_set> @@ -96,9 +97,8 @@ NSImage *MGLDefaultMarkerImage() { } /// Converts from a duration in seconds to a duration object usable in mbgl. -std::chrono::steady_clock::duration MGLDurationInSeconds(NSTimeInterval duration) { - return std::chrono::duration_cast<std::chrono::steady_clock::duration>( - std::chrono::duration<NSTimeInterval, std::chrono::seconds::period>(duration)); +mbgl::Duration MGLDurationInSeconds(NSTimeInterval duration) { + return std::chrono::duration_cast<mbgl::Duration>(std::chrono::duration<NSTimeInterval>(duration)); } /// Converts a media timing function into a unit bezier object usable in mbgl. |