summaryrefslogtreecommitdiff
path: root/platform
diff options
context:
space:
mode:
authorAntonio Zugaldia <antonio@mapbox.com>2016-02-26 10:05:20 -0500
committerAntonio Zugaldia <antonio@mapbox.com>2016-02-26 10:05:47 -0500
commit11d3eff173b5a596b8f0683a93658cbd4ca1eb95 (patch)
tree1b9c8c2b28a8e821780a42ce25f1a3a0cea0acf5 /platform
parent01e55f183e4468d040e7b144536ca592c9b64cb5 (diff)
downloadqtlocation-mapboxgl-11d3eff173b5a596b8f0683a93658cbd4ca1eb95.tar.gz
[android] Remove invoke to DeleteGlobalRef to avoid client crash
See #4121
Diffstat (limited to 'platform')
-rwxr-xr-xplatform/android/src/jni.cpp9
1 files changed, 3 insertions, 6 deletions
diff --git a/platform/android/src/jni.cpp b/platform/android/src/jni.cpp
index cfb7ca34e3..9855529c66 100755
--- a/platform/android/src/jni.cpp
+++ b/platform/android/src/jni.cpp
@@ -1940,8 +1940,7 @@ void JNICALL setOfflineRegionObserver(JNIEnv *env, jobject obj, jobject offlineR
env2->SetBooleanField(jstatus, offlineRegionStatusRequiredResourceCountIsPreciseId, status.requiredResourceCountIsPrecise);
env2->CallVoidMethod(observerCallback, offlineRegionObserveronStatusChangedId, jstatus);
- // Delete global refs and detach when we're done
- env2->DeleteGlobalRef(observerCallback);
+ // Detach when we're done
detach_jni_thread(theJVM, &env2, renderDetach);
}
@@ -1976,8 +1975,7 @@ void JNICALL setOfflineRegionObserver(JNIEnv *env, jobject obj, jobject offlineR
env2->SetObjectField(jerror, offlineRegionErrorMessageId, std_string_to_jstring(env2, error.message));
env2->CallVoidMethod(observerCallback, offlineRegionObserveronErrorId, jerror);
- // Delete global refs and detach when we're done
- env2->DeleteGlobalRef(observerCallback);
+ // Detach when we're done
detach_jni_thread(theJVM, &env2, renderDetach);
}
@@ -1989,8 +1987,7 @@ void JNICALL setOfflineRegionObserver(JNIEnv *env, jobject obj, jobject offlineR
// Send limit
env2->CallVoidMethod(observerCallback, offlineRegionObserveronLimitId, limit);
- // Delete global refs and detach when we're done
- env2->DeleteGlobalRef(observerCallback);
+ // Detach when we're done
detach_jni_thread(theJVM, &env2, renderDetach);
}