diff options
author | Zsolt Bölöny <bolony.zsolt@gmail.com> | 2018-06-24 14:34:26 +0200 |
---|---|---|
committer | John Firebaugh <john.firebaugh@gmail.com> | 2018-06-25 10:07:04 -0700 |
commit | bc6094eb5539971a7cf7e48c90996a52c89c5815 (patch) | |
tree | 6b90d7445981844591d2580dd25d9f7f656a33fa /platform | |
parent | 279dd93f7cbd57adce60a97bdb760905e30f4580 (diff) | |
download | qtlocation-mapboxgl-bc6094eb5539971a7cf7e48c90996a52c89c5815.tar.gz |
[core] Fix GCC8's new -Wcatch-value warnings
Polymorphic types shouldn't be caught by value, as the warning message says. Catch them by constant reference instead.
Diffstat (limited to 'platform')
-rw-r--r-- | platform/default/mbgl/storage/offline_database.cpp | 2 | ||||
-rw-r--r-- | platform/default/mbgl/storage/offline_download.cpp | 2 | ||||
-rw-r--r-- | platform/glfw/main.cpp | 6 |
3 files changed, 5 insertions, 5 deletions
diff --git a/platform/default/mbgl/storage/offline_database.cpp b/platform/default/mbgl/storage/offline_database.cpp index 24fc0f2335..92e534634d 100644 --- a/platform/default/mbgl/storage/offline_database.cpp +++ b/platform/default/mbgl/storage/offline_database.cpp @@ -658,7 +658,7 @@ void OfflineDatabase::putRegionResources(int64_t regionID, const std::list<std:: status.completedTileCount += 1; status.completedTileSize += resourceSize; } - } catch (MapboxTileLimitExceededException) { + } catch (const MapboxTileLimitExceededException&) { // Commit the rest of the batch and retrow transaction.commit(); throw; diff --git a/platform/default/mbgl/storage/offline_download.cpp b/platform/default/mbgl/storage/offline_download.cpp index 1bd29f031c..4da51db655 100644 --- a/platform/default/mbgl/storage/offline_download.cpp +++ b/platform/default/mbgl/storage/offline_download.cpp @@ -355,7 +355,7 @@ void OfflineDownload::ensureResource(const Resource& resource, if (buffer.size() == 64 || resourcesRemaining.size() == 0) { try { offlineDatabase.putRegionResources(id, buffer, status); - } catch (MapboxTileLimitExceededException) { + } catch (const MapboxTileLimitExceededException&) { onMapboxTileCountLimitExceeded(); return; } diff --git a/platform/glfw/main.cpp b/platform/glfw/main.cpp index c4e0ecf692..8915f1d7f1 100644 --- a/platform/glfw/main.cpp +++ b/platform/glfw/main.cpp @@ -51,14 +51,14 @@ int main(int argc, char *argv[]) { try { argumentParser.ParseCLI(argc, argv); - } catch (args::Help) { + } catch (const args::Help&) { std::cout << argumentParser; exit(0); - } catch (args::ParseError e) { + } catch (const args::ParseError& e) { std::cerr << e.what() << std::endl; std::cerr << argumentParser; exit(1); - } catch (args::ValidationError e) { + } catch (const args::ValidationError& e) { std::cerr << e.what() << std::endl; std::cerr << argumentParser; exit(2); |