diff options
author | Thiago Marcos P. Santos <tmpsantos@gmail.com> | 2020-03-20 12:38:09 +0200 |
---|---|---|
committer | Thiago Marcos P. Santos <tmpsantos@gmail.com> | 2020-03-23 12:09:09 +0200 |
commit | d15b9c1f9c1afa29175ba2e398adc680e66147e6 (patch) | |
tree | 6bf426ae77d7386a6bbdee30444974bbc5dd76d0 /platform/qt | |
parent | 37802eec36aae3cb84c7f73a48652d9959489243 (diff) | |
download | qtlocation-mapboxgl-d15b9c1f9c1afa29175ba2e398adc680e66147e6.tar.gz |
[core] Fix performance-unnecessary-value-param errors
As reported by clang-tidy-8.
Diffstat (limited to 'platform/qt')
-rw-r--r-- | platform/qt/src/local_glyph_rasterizer.cpp | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/platform/qt/src/local_glyph_rasterizer.cpp b/platform/qt/src/local_glyph_rasterizer.cpp index f62975b377..31abfd4503 100644 --- a/platform/qt/src/local_glyph_rasterizer.cpp +++ b/platform/qt/src/local_glyph_rasterizer.cpp @@ -12,7 +12,7 @@ namespace mbgl { class LocalGlyphRasterizer::Impl { public: - Impl(const optional<std::string> fontFamily_); + Impl(const optional<std::string>& fontFamily_); bool isConfigured() const; @@ -21,8 +21,7 @@ public: optional<QFontMetrics> metrics; }; -LocalGlyphRasterizer::Impl::Impl(const optional<std::string> fontFamily_) - : fontFamily(fontFamily_) { +LocalGlyphRasterizer::Impl::Impl(const optional<std::string>& fontFamily_) : fontFamily(fontFamily_) { if (isConfigured()) { font.setFamily(QString::fromStdString(*fontFamily)); font.setPixelSize(util::ONE_EM); @@ -34,9 +33,8 @@ bool LocalGlyphRasterizer::Impl::isConfigured() const { return fontFamily.operator bool(); } -LocalGlyphRasterizer::LocalGlyphRasterizer(const optional<std::string> fontFamily) - : impl(std::make_unique<Impl>(fontFamily)) { -} +LocalGlyphRasterizer::LocalGlyphRasterizer(const optional<std::string>& fontFamily) + : impl(std::make_unique<Impl>(fontFamily)) {} LocalGlyphRasterizer::~LocalGlyphRasterizer() { } |