diff options
author | Konstantin Käfer <mail@kkaefer.com> | 2015-10-16 16:14:55 +0200 |
---|---|---|
committer | Konstantin Käfer <mail@kkaefer.com> | 2015-10-26 15:54:27 +0100 |
commit | 5173bf1bb8d21054b0dd6251d23eb37323d6c525 (patch) | |
tree | d13536c22b8279e9fd7e8f4892596c42973170f3 /platform/node | |
parent | 4e3503ea6cf30c55a2cc86f78c4a607bd14f1c41 (diff) | |
download | qtlocation-mapboxgl-5173bf1bb8d21054b0dd6251d23eb37323d6c525.tar.gz |
[core] Make response data shared to avoid excessive copying
Diffstat (limited to 'platform/node')
-rw-r--r-- | platform/node/src/node_request.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/platform/node/src/node_request.cpp b/platform/node/src/node_request.cpp index fb4d47045b..211a696cd7 100644 --- a/platform/node/src/node_request.cpp +++ b/platform/node/src/node_request.cpp @@ -110,10 +110,10 @@ NAN_METHOD(NodeRequest::Respond) { if (Nan::Has(res, Nan::New("data").ToLocalChecked()).FromJust()) { auto dataHandle = Nan::Get(res, Nan::New("data").ToLocalChecked()).ToLocalChecked(); if (node::Buffer::HasInstance(dataHandle)) { - response->data = std::string { + response->data = std::make_shared<std::string>( node::Buffer::Data(dataHandle), node::Buffer::Length(dataHandle) - }; + ); } else { return Nan::ThrowTypeError("Response data must be a Buffer"); } |