diff options
author | Thiago Marcos P. Santos <tmpsantos@gmail.com> | 2020-03-20 12:38:09 +0200 |
---|---|---|
committer | Thiago Marcos P. Santos <tmpsantos@gmail.com> | 2020-03-23 12:09:09 +0200 |
commit | d15b9c1f9c1afa29175ba2e398adc680e66147e6 (patch) | |
tree | 6bf426ae77d7386a6bbdee30444974bbc5dd76d0 /platform/node | |
parent | 37802eec36aae3cb84c7f73a48652d9959489243 (diff) | |
download | qtlocation-mapboxgl-d15b9c1f9c1afa29175ba2e398adc680e66147e6.tar.gz |
[core] Fix performance-unnecessary-value-param errors
As reported by clang-tidy-8.
Diffstat (limited to 'platform/node')
-rw-r--r-- | platform/node/src/node_map.cpp | 6 | ||||
-rw-r--r-- | platform/node/src/node_map.hpp | 2 |
2 files changed, 4 insertions, 4 deletions
diff --git a/platform/node/src/node_map.cpp b/platform/node/src/node_map.cpp index b410a590a7..624454c103 100644 --- a/platform/node/src/node_map.cpp +++ b/platform/node/src/node_map.cpp @@ -443,7 +443,7 @@ void NodeMap::Render(const Nan::FunctionCallbackInfo<v8::Value>& info) { assert(!nodeMap->image.data); nodeMap->req = std::make_unique<RenderRequest>(Nan::To<v8::Function>(info[1]).ToLocalChecked()); - nodeMap->startRender(std::move(options)); + nodeMap->startRender(options); } catch (const mbgl::style::conversion::Error& err) { return Nan::ThrowTypeError(err.message.c_str()); } catch (const mbgl::util::StyleParseException& ex) { @@ -455,7 +455,7 @@ void NodeMap::Render(const Nan::FunctionCallbackInfo<v8::Value>& info) { info.GetReturnValue().SetUndefined(); } -void NodeMap::startRender(NodeMap::RenderOptions options) { +void NodeMap::startRender(const NodeMap::RenderOptions& options) { frontend->setSize(options.size); map->setSize(options.size); @@ -472,7 +472,7 @@ void NodeMap::startRender(NodeMap::RenderOptions options) { map->setProjectionMode(projectionOptions); - map->renderStill(camera, options.debugOptions, [this](const std::exception_ptr eptr) { + map->renderStill(camera, options.debugOptions, [this](const std::exception_ptr& eptr) { if (eptr) { error = eptr; uv_async_send(async); diff --git a/platform/node/src/node_map.hpp b/platform/node/src/node_map.hpp index 8530448b47..4349cbabe2 100644 --- a/platform/node/src/node_map.hpp +++ b/platform/node/src/node_map.hpp @@ -70,7 +70,7 @@ public: static v8::Local<v8::Value> ParseError(const char* msg); - void startRender(RenderOptions options); + void startRender(const RenderOptions& options); void renderFinished(); void release(); |