diff options
| author | Aleksandar Stojiljkovic <aleksandar.stojiljkovic@mapbox.com> | 2019-07-07 13:40:22 +0300 |
|---|---|---|
| committer | Aleksandar Stojiljkovic <aleksandar.stojiljkovic@mapbox.com> | 2019-07-09 15:13:38 +0200 |
| commit | 2c5528e691b502673b16723205c83add62317734 (patch) | |
| tree | d4e27fecc8b867a5472e5392f52953f38c9327d7 /platform/node | |
| parent | 929824ecc3176c01a5f3e74d80e2ae2ba2cf1e51 (diff) | |
| download | qtlocation-mapboxgl-2c5528e691b502673b16723205c83add62317734.tar.gz | |
Fix layers rendering after fill-extrusion
This fixes following issues:
* Fix some false passing combinations/fill-extrusion-translucent--XXXX tests
* Fix and enable other, failing but ignored, combinations/fill-extrusion-translucent--XXXX tests
* Fix rendering of layers that are on top of fill-extrusion layers
state.getProjMatrix(nearClippedProjMatrix, 100) caused that tests with size 64x64 were not
rendering fill extrusions: far plane calculated as 96.9 and near plane set to 100 was the cause.
near plane is changed from hardcoded 100 to depend on state.getCameraToCenterDistance() - producing
similar value but one that follows max zoom.
This caused that e.g. combinations/fill-extrusion-translucent--fill-opaque was falsely passing as
only fill-opaque layer got rendered.
combinations/fill-extrusion-translucent--XXXX tests expose regression https://github.com/mapbox/mapbox-gl-native/issues/14844#issuecomment-503600034 in #14844, #14779.
Fix (opaquePassCutoff, is3D) is ported from https://github.com/mapbox/mapbox-gl-js/pull/7821
Fixes: #14844, #14779, #15039
Diffstat (limited to 'platform/node')
| -rw-r--r-- | platform/node/test/ignores.json | 18 |
1 files changed, 0 insertions, 18 deletions
diff --git a/platform/node/test/ignores.json b/platform/node/test/ignores.json index 63b9764f22..4b2ed7fd3f 100644 --- a/platform/node/test/ignores.json +++ b/platform/node/test/ignores.json @@ -87,25 +87,7 @@ "render-tests/text-rotate/with-offset": "https://github.com/mapbox/mapbox-gl-native/issues/11872", "render-tests/video/default": "skip - https://github.com/mapbox/mapbox-gl-native/issues/601", "render-tests/background-color/colorSpace-hcl": "needs issue", - "render-tests/combinations/fill-extrusion-translucent--heatmap-translucent": "needs investigation", "render-tests/combinations/heatmap-translucent--background-opaque": "needs investigation", - "render-tests/combinations/heatmap-translucent--fill-extrusion-translucent": "needs investigation", - "render-tests/combinations/background-opaque--fill-extrusion-translucent": "needs investigation", - "render-tests/combinations/background-translucent--fill-extrusion-translucent": "needs investigation", - "render-tests/combinations/circle-translucent--fill-extrusion-translucent": "needs investigation", - "render-tests/combinations/fill-extrusion-translucent--background-translucent": "needs investigation", - "render-tests/combinations/fill-extrusion-translucent--circle-translucent": "needs investigation", - "render-tests/combinations/fill-extrusion-translucent--hillshade-translucent": "needs investigation", - "render-tests/combinations/fill-extrusion-translucent--fill-extrusion-translucent": "needs investigation", - "render-tests/combinations/fill-extrusion-translucent--fill-translucent": "needs investigation", - "render-tests/combinations/fill-extrusion-translucent--line-translucent": "needs investigation", - "render-tests/combinations/fill-extrusion-translucent--symbol-translucent": "needs investigation", - "render-tests/combinations/hillshade-translucent--fill-extrusion-translucent": "needs investigation", - "render-tests/combinations/fill-opaque--fill-extrusion-translucent": "needs investigation", - "render-tests/combinations/fill-translucent--fill-extrusion-translucent": "needs investigation", - "render-tests/combinations/line-translucent--fill-extrusion-translucent": "needs investigation", - "render-tests/combinations/raster-translucent--fill-extrusion-translucent": "needs investigation", - "render-tests/combinations/symbol-translucent--fill-extrusion-translucent": "needs investigation", "render-tests/feature-state/composite-expression": "https://github.com/mapbox/mapbox-gl-native/issues/12613", "render-tests/feature-state/data-expression": "https://github.com/mapbox/mapbox-gl-native/issues/12613", "render-tests/feature-state/vector-source": "https://github.com/mapbox/mapbox-gl-native/issues/12613", |