diff options
author | Thiago Marcos P. Santos <tmpsantos@gmail.com> | 2020-03-27 17:43:37 +0200 |
---|---|---|
committer | Thiago Marcos P. Santos <tmpsantos@gmail.com> | 2020-03-30 23:37:44 +0300 |
commit | 62b543e44a5d63dd79dfc7ab68696dc8a3f8e3ef (patch) | |
tree | 3e1b27e9cedbc53b43ec952579553618731ab671 /platform/default | |
parent | 65f4df5190d764a12a2c8054bfce2838545917e7 (diff) | |
download | qtlocation-mapboxgl-62b543e44a5d63dd79dfc7ab68696dc8a3f8e3ef.tar.gz |
[core] Fix google-explicit-constructor errors
As reported by clang-tidy-8.
Diffstat (limited to 'platform/default')
4 files changed, 4 insertions, 10 deletions
diff --git a/platform/default/src/mbgl/storage/local_file_source.cpp b/platform/default/src/mbgl/storage/local_file_source.cpp index b505303fc0..5d92e711a1 100644 --- a/platform/default/src/mbgl/storage/local_file_source.cpp +++ b/platform/default/src/mbgl/storage/local_file_source.cpp @@ -19,7 +19,7 @@ namespace mbgl { class LocalFileSource::Impl { public: - Impl(const ActorRef<Impl>&) {} + explicit Impl(const ActorRef<Impl>&) {} void request(const std::string& url, const ActorRef<FileSourceRequest>& req) { if (!acceptsURL(url)) { diff --git a/platform/default/src/mbgl/storage/sqlite3.cpp b/platform/default/src/mbgl/storage/sqlite3.cpp index 69d03c4e00..03c1c2e44d 100644 --- a/platform/default/src/mbgl/storage/sqlite3.cpp +++ b/platform/default/src/mbgl/storage/sqlite3.cpp @@ -46,9 +46,7 @@ void setTempPath(const std::string& path) { class DatabaseImpl { public: - DatabaseImpl(sqlite3* db_) - : db(db_) - { + explicit DatabaseImpl(sqlite3* db_) : db(db_) { const int error = sqlite3_extended_result_codes(db, true); if (error != SQLITE_OK) { mbgl::Log::Warning(mbgl::Event::Database, error, "Failed to enable extended result codes: %s", sqlite3_errmsg(db)); diff --git a/platform/default/src/mbgl/util/async_task.cpp b/platform/default/src/mbgl/util/async_task.cpp index 50891056d8..d82b8085a1 100644 --- a/platform/default/src/mbgl/util/async_task.cpp +++ b/platform/default/src/mbgl/util/async_task.cpp @@ -12,10 +12,7 @@ namespace util { class AsyncTask::Impl { public: - Impl(std::function<void()>&& fn) - : async(new uv_async_t), - task(std::move(fn)) { - + explicit Impl(std::function<void()> fn) : async(new uv_async_t), task(std::move(fn)) { auto* loop = reinterpret_cast<uv_loop_t*>(RunLoop::getLoopHandle()); if (uv_async_init(loop, async, asyncCallback) != 0) { throw std::runtime_error("Failed to initialize async."); diff --git a/platform/default/src/mbgl/util/jpeg_reader.cpp b/platform/default/src/mbgl/util/jpeg_reader.cpp index 69df494e70..8daa02f076 100644 --- a/platform/default/src/mbgl/util/jpeg_reader.cpp +++ b/platform/default/src/mbgl/util/jpeg_reader.cpp @@ -79,8 +79,7 @@ static void on_error_message(j_common_ptr cinfo) { } struct jpeg_info_guard { - jpeg_info_guard(jpeg_decompress_struct* cinfo) - : i_(cinfo) {} + explicit jpeg_info_guard(jpeg_decompress_struct* cinfo) : i_(cinfo) {} ~jpeg_info_guard() { jpeg_destroy_decompress(i_); |