summaryrefslogtreecommitdiff
path: root/platform/default
diff options
context:
space:
mode:
authorZsolt Bölöny <bolony.zsolt@gmail.com>2018-06-24 14:34:26 +0200
committerJohn Firebaugh <john.firebaugh@gmail.com>2018-06-25 10:07:04 -0700
commitbc6094eb5539971a7cf7e48c90996a52c89c5815 (patch)
tree6b90d7445981844591d2580dd25d9f7f656a33fa /platform/default
parent279dd93f7cbd57adce60a97bdb760905e30f4580 (diff)
downloadqtlocation-mapboxgl-bc6094eb5539971a7cf7e48c90996a52c89c5815.tar.gz
[core] Fix GCC8's new -Wcatch-value warnings
Polymorphic types shouldn't be caught by value, as the warning message says. Catch them by constant reference instead.
Diffstat (limited to 'platform/default')
-rw-r--r--platform/default/mbgl/storage/offline_database.cpp2
-rw-r--r--platform/default/mbgl/storage/offline_download.cpp2
2 files changed, 2 insertions, 2 deletions
diff --git a/platform/default/mbgl/storage/offline_database.cpp b/platform/default/mbgl/storage/offline_database.cpp
index 24fc0f2335..92e534634d 100644
--- a/platform/default/mbgl/storage/offline_database.cpp
+++ b/platform/default/mbgl/storage/offline_database.cpp
@@ -658,7 +658,7 @@ void OfflineDatabase::putRegionResources(int64_t regionID, const std::list<std::
status.completedTileCount += 1;
status.completedTileSize += resourceSize;
}
- } catch (MapboxTileLimitExceededException) {
+ } catch (const MapboxTileLimitExceededException&) {
// Commit the rest of the batch and retrow
transaction.commit();
throw;
diff --git a/platform/default/mbgl/storage/offline_download.cpp b/platform/default/mbgl/storage/offline_download.cpp
index 1bd29f031c..4da51db655 100644
--- a/platform/default/mbgl/storage/offline_download.cpp
+++ b/platform/default/mbgl/storage/offline_download.cpp
@@ -355,7 +355,7 @@ void OfflineDownload::ensureResource(const Resource& resource,
if (buffer.size() == 64 || resourcesRemaining.size() == 0) {
try {
offlineDatabase.putRegionResources(id, buffer, status);
- } catch (MapboxTileLimitExceededException) {
+ } catch (const MapboxTileLimitExceededException&) {
onMapboxTileCountLimitExceeded();
return;
}