diff options
author | Thiago Marcos P. Santos <tmpsantos@gmail.com> | 2019-09-23 17:41:33 +0300 |
---|---|---|
committer | Thiago Marcos P. Santos <tmpsantos@gmail.com> | 2019-09-25 18:59:07 +0300 |
commit | c7bbd5bbef0780df5d0a5498e14051ee63c24e44 (patch) | |
tree | 4d1803a26e86327b404dc810709b7ea1c0a9453d /platform/default | |
parent | 3c23f6f9f7f92ef43cb3d78e5570976058cf49c5 (diff) | |
download | qtlocation-mapboxgl-c7bbd5bbef0780df5d0a5498e14051ee63c24e44.tar.gz |
[core] Fix performance-move-const-arg
Diffstat (limited to 'platform/default')
-rw-r--r-- | platform/default/src/mbgl/storage/offline.cpp | 11 | ||||
-rw-r--r-- | platform/default/src/mbgl/storage/offline_download.cpp | 2 | ||||
-rw-r--r-- | platform/default/src/mbgl/storage/online_file_source.cpp | 14 |
3 files changed, 16 insertions, 11 deletions
diff --git a/platform/default/src/mbgl/storage/offline.cpp b/platform/default/src/mbgl/storage/offline.cpp index dd809ad129..795710585c 100644 --- a/platform/default/src/mbgl/storage/offline.cpp +++ b/platform/default/src/mbgl/storage/offline.cpp @@ -16,10 +16,14 @@ namespace mbgl { // OfflineTilePyramidRegionDefinition -OfflineTilePyramidRegionDefinition::OfflineTilePyramidRegionDefinition( - std::string styleURL_, LatLngBounds bounds_, double minZoom_, double maxZoom_, float pixelRatio_, bool includeIdeographs_) +OfflineTilePyramidRegionDefinition::OfflineTilePyramidRegionDefinition(std::string styleURL_, + LatLngBounds bounds_, + double minZoom_, + double maxZoom_, + float pixelRatio_, + bool includeIdeographs_) : styleURL(std::move(styleURL_)), - bounds(std::move(bounds_)), + bounds(bounds_), minZoom(minZoom_), maxZoom(maxZoom_), pixelRatio(pixelRatio_), @@ -30,7 +34,6 @@ OfflineTilePyramidRegionDefinition::OfflineTilePyramidRegionDefinition( } } - // OfflineGeometryRegionDefinition OfflineGeometryRegionDefinition::OfflineGeometryRegionDefinition(std::string styleURL_, Geometry<double> geometry_, double minZoom_, double maxZoom_, float pixelRatio_, bool includeIdeographs_) diff --git a/platform/default/src/mbgl/storage/offline_download.cpp b/platform/default/src/mbgl/storage/offline_download.cpp index 939164bd35..d5cf7e4fe1 100644 --- a/platform/default/src/mbgl/storage/offline_download.cpp +++ b/platform/default/src/mbgl/storage/offline_download.cpp @@ -433,7 +433,7 @@ void OfflineDownload::ensureResource(Resource&& resource, } } - if (result) resourcesToBeMarkedAsUsed.emplace_back(std::move(resource)); + if (result) resourcesToBeMarkedAsUsed.emplace_back(resource); return result; }; diff --git a/platform/default/src/mbgl/storage/online_file_source.cpp b/platform/default/src/mbgl/storage/online_file_source.cpp index 4e19d48a15..a8907d849b 100644 --- a/platform/default/src/mbgl/storage/online_file_source.cpp +++ b/platform/default/src/mbgl/storage/online_file_source.cpp @@ -78,10 +78,12 @@ public: if (resourceTransform) { // Request the ResourceTransform actor a new url and replace the resource url with the // transformed one before proceeding to schedule the request. - resourceTransform->invoke(&ResourceTransform::transform, request->resource.kind, - std::move(request->resource.url), [ref = request->actor()](const std::string&& url) { - ref.invoke(&OnlineFileRequest::setTransformedURL, std::move(url)); - }); + resourceTransform->invoke(&ResourceTransform::transform, + request->resource.kind, + std::move(request->resource.url), + [ref = request->actor()](const std::string&& url) { + ref.invoke(&OnlineFileRequest::setTransformedURL, url); + }); } else { request->schedule(); } @@ -466,8 +468,8 @@ void OnlineFileRequest::networkIsReachableAgain() { } void OnlineFileRequest::setTransformedURL(const std::string&& url) { - resource.url = std::move(url); - schedule(); + resource.url = url; + schedule(); } ActorRef<OnlineFileRequest> OnlineFileRequest::actor() { |