diff options
author | Thiago Marcos P. Santos <tmpsantos@gmail.com> | 2020-03-20 12:38:09 +0200 |
---|---|---|
committer | Thiago Marcos P. Santos <tmpsantos@gmail.com> | 2020-03-23 12:09:09 +0200 |
commit | d15b9c1f9c1afa29175ba2e398adc680e66147e6 (patch) | |
tree | 6bf426ae77d7386a6bbdee30444974bbc5dd76d0 /platform/default/src/mbgl/storage/online_file_source.cpp | |
parent | 37802eec36aae3cb84c7f73a48652d9959489243 (diff) | |
download | qtlocation-mapboxgl-d15b9c1f9c1afa29175ba2e398adc680e66147e6.tar.gz |
[core] Fix performance-unnecessary-value-param errors
As reported by clang-tidy-8.
Diffstat (limited to 'platform/default/src/mbgl/storage/online_file_source.cpp')
-rw-r--r-- | platform/default/src/mbgl/storage/online_file_source.cpp | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/platform/default/src/mbgl/storage/online_file_source.cpp b/platform/default/src/mbgl/storage/online_file_source.cpp index f578eb1479..6dc4de0ac7 100644 --- a/platform/default/src/mbgl/storage/online_file_source.cpp +++ b/platform/default/src/mbgl/storage/online_file_source.cpp @@ -24,6 +24,7 @@ #include <cassert> #include <list> #include <map> +#include <utility> namespace mbgl { @@ -77,7 +78,7 @@ public: ~OnlineFileSourceThread() { NetworkStatus::Unsubscribe(&reachability); } - void request(AsyncRequest* req, Resource resource, ActorRef<FileSourceRequest> ref) { + void request(AsyncRequest* req, Resource resource, const ActorRef<FileSourceRequest>& ref) { auto callback = [ref](const Response& res) { ref.invoke(&FileSourceRequest::setResponse, res); }; tasks[req] = std::make_unique<OnlineFileRequest>(std::move(resource), std::move(callback), *this); } @@ -127,7 +128,7 @@ public: void queueRequest(OnlineFileRequest* req) { pendingRequests.insert(req); } void activateRequest(OnlineFileRequest* req) { - auto callback = [=](Response response) { + auto callback = [=](const Response& response) { activeRequests.erase(req); req->request.reset(); req->completed(response); @@ -439,7 +440,7 @@ void OnlineFileRequest::schedule(optional<Timestamp> expires) { // If we're not being asked for a forced refresh, calculate a timeout that depends on how many // consecutive errors we've encountered, and on the expiration time, if present. Duration timeout = std::min(http::errorRetryTimeout(failedRequestReason, failedRequests, retryAfter), - http::expirationTimeout(expires, expiredRequests)); + http::expirationTimeout(std::move(expires), expiredRequests)); if (timeout == Duration::max()) { return; |