diff options
author | Thiago Marcos P. Santos <tmpsantos@gmail.com> | 2020-03-20 12:38:09 +0200 |
---|---|---|
committer | Thiago Marcos P. Santos <tmpsantos@gmail.com> | 2020-03-23 12:09:09 +0200 |
commit | d15b9c1f9c1afa29175ba2e398adc680e66147e6 (patch) | |
tree | 6bf426ae77d7386a6bbdee30444974bbc5dd76d0 /platform/default/src/mbgl/storage/main_resource_loader.cpp | |
parent | 37802eec36aae3cb84c7f73a48652d9959489243 (diff) | |
download | qtlocation-mapboxgl-d15b9c1f9c1afa29175ba2e398adc680e66147e6.tar.gz |
[core] Fix performance-unnecessary-value-param errors
As reported by clang-tidy-8.
Diffstat (limited to 'platform/default/src/mbgl/storage/main_resource_loader.cpp')
-rw-r--r-- | platform/default/src/mbgl/storage/main_resource_loader.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/platform/default/src/mbgl/storage/main_resource_loader.cpp b/platform/default/src/mbgl/storage/main_resource_loader.cpp index aa8d745170..0e7ea367e3 100644 --- a/platform/default/src/mbgl/storage/main_resource_loader.cpp +++ b/platform/default/src/mbgl/storage/main_resource_loader.cpp @@ -25,7 +25,7 @@ public: localFileSource(std::move(localFileSource_)), onlineFileSource(std::move(onlineFileSource_)) {} - void request(AsyncRequest* req, Resource resource, ActorRef<FileSourceRequest> ref) { + void request(AsyncRequest* req, const Resource& resource, const ActorRef<FileSourceRequest>& ref) { auto callback = [ref](const Response& res) { ref.invoke(&FileSourceRequest::setResponse, res); }; auto requestFromNetwork = [=](const Resource& res, @@ -38,7 +38,7 @@ public: std::shared_ptr<AsyncRequest> parentKeepAlive = std::move(parent); MBGL_TIMING_START(watch); - return onlineFileSource->request(res, [=, ptr = parentKeepAlive](Response response) { + return onlineFileSource->request(res, [=, ptr = parentKeepAlive](const Response& response) { if (databaseFileSource) { databaseFileSource->forward(res, response); } @@ -72,7 +72,7 @@ public: tasks[req] = databaseFileSource->request(resource, callback); } else { // Cache request with fallback to network with cache control - tasks[req] = databaseFileSource->request(resource, [=](Response response) { + tasks[req] = databaseFileSource->request(resource, [=](const Response& response) { Resource res = resource; // Resource is in the cache |