diff options
| author | Thiago Marcos P. Santos <tmpsantos@gmail.com> | 2020-03-20 12:38:09 +0200 |
|---|---|---|
| committer | Thiago Marcos P. Santos <tmpsantos@gmail.com> | 2020-03-23 12:09:09 +0200 |
| commit | d15b9c1f9c1afa29175ba2e398adc680e66147e6 (patch) | |
| tree | 6bf426ae77d7386a6bbdee30444974bbc5dd76d0 /platform/darwin | |
| parent | 37802eec36aae3cb84c7f73a48652d9959489243 (diff) | |
| download | qtlocation-mapboxgl-d15b9c1f9c1afa29175ba2e398adc680e66147e6.tar.gz | |
[core] Fix performance-unnecessary-value-param errors
As reported by clang-tidy-8.
Diffstat (limited to 'platform/darwin')
| -rw-r--r-- | platform/darwin/src/collator.mm | 6 | ||||
| -rw-r--r-- | platform/darwin/src/local_glyph_rasterizer.mm | 2 |
2 files changed, 4 insertions, 4 deletions
diff --git a/platform/darwin/src/collator.mm b/platform/darwin/src/collator.mm index 0f010c1df8..7d5da5148e 100644 --- a/platform/darwin/src/collator.mm +++ b/platform/darwin/src/collator.mm @@ -9,7 +9,7 @@ namespace platform { class Collator::Impl { public: - Impl(bool caseSensitive, bool diacriticSensitive, optional<std::string> locale_) + Impl(bool caseSensitive, bool diacriticSensitive, const optional<std::string>& locale_) : options((caseSensitive ? 0 : NSCaseInsensitiveSearch) | (diacriticSensitive ? 0 : NSDiacriticInsensitiveSearch)) , locale(locale_ ? @@ -47,8 +47,8 @@ private: NSLocale* locale; }; -Collator::Collator(bool caseSensitive, bool diacriticSensitive, optional<std::string> locale_) - : impl(std::make_shared<Impl>(caseSensitive, diacriticSensitive, std::move(locale_))) +Collator::Collator(bool caseSensitive, bool diacriticSensitive, const optional<std::string>& locale_) + : impl(std::make_shared<Impl>(caseSensitive, diacriticSensitive, locale_)) {} bool Collator::operator==(const Collator& other) const { diff --git a/platform/darwin/src/local_glyph_rasterizer.mm b/platform/darwin/src/local_glyph_rasterizer.mm index 14cee5063e..6ff346873a 100644 --- a/platform/darwin/src/local_glyph_rasterizer.mm +++ b/platform/darwin/src/local_glyph_rasterizer.mm @@ -88,7 +88,7 @@ private: CTFontRef fontHandle; }; -LocalGlyphRasterizer::LocalGlyphRasterizer(const optional<std::string> fontFamily) +LocalGlyphRasterizer::LocalGlyphRasterizer(const optional<std::string>& fontFamily) : impl(std::make_unique<Impl>(fontFamily)) {} |