[android] #3754 - newLatLngBounds: unit tests for LatLng and LatLngBounds, builder pattern + refactoring.

[android] #3754 - Working version using the underlying VisibleCoorindateBounds

[android] #3754 - refactor Camera api inside maps package, correctly use factory pattern, LatLngBounds hooks into camera API

[android] #3754 - cleanup old API

1 files changed, 160 insertions, 0 deletions

diff --git a/platform/android/MapboxGLAndroidSDKTestApp/src/test/java/com/mapbox/mapboxsdk/geometry/LatLngBoundsTest.java b/platform/android/MapboxGLAndroidSDKTestApp/src/test/java/com/mapbox/mapboxsdk/geometry/LatLngBoundsTest.java
new file mode 100644
index 0000000000..69c2d4935b
--- /dev/null
+++ b/platform/android/MapboxGLAndroidSDKTestApp/src/test/java/com/mapbox/mapboxsdk/geometry/LatLngBoundsTest.java
@@ -0,0 +1,160 @@
+package com.mapbox.mapboxsdk.geometry;
+
+import com.mapbox.mapboxsdk.annotations.Marker;
+import com.mapbox.mapboxsdk.annotations.MarkerOptions;
+import com.mapbox.mapboxsdk.exceptions.InvalidLatLngBoundsException;
+
+import org.junit.Before;
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertTrue;
+
+public class LatLngBoundsTest {
+
+    private static final double DELTA = 1e-15;
+
+    private LatLngBounds mLatLngBounds;
+    private static final LatLng LAT_LNG_NULL_ISLAND = new LatLng(0, 0);
+    private static final LatLng LAT_LNG_NOT_NULL_ISLAND = new LatLng(2, 2);
+
+    @Before
+    public void beforeTest() {
+        mLatLngBounds = new LatLngBounds.Builder()
+                .include(LAT_LNG_NULL_ISLAND)
+                .include(LAT_LNG_NOT_NULL_ISLAND)
+                .build();
+    }
+
+    @Test
+    public void testSanity() {
+        LatLngBounds.Builder latLngBoundsBuilder = new LatLngBounds.Builder();
+        latLngBoundsBuilder.include(LAT_LNG_NULL_ISLAND).include(LAT_LNG_NOT_NULL_ISLAND);
+        assertNotNull("latLng  should not be null", latLngBoundsBuilder.build());
+    }
+
+    @Test(expected = InvalidLatLngBoundsException.class)
+    public void testNoLatLngs() {
+        new LatLngBounds.Builder().build();
+    }
+
+    @Test(expected = InvalidLatLngBoundsException.class)
+    public void testOneLatLngs() {
+        new LatLngBounds.Builder().include(LAT_LNG_NULL_ISLAND).build();
+    }
+
+    @Test
+    public void testLatitiudeSpan() {
+        assertEquals("Span should be the same", 2, mLatLngBounds.getLatitudeSpan(), DELTA);
+    }
+
+    @Test
+    public void testLongitudeSpan() {
+        assertEquals("Span should be the same", 2, mLatLngBounds.getLongitudeSpan(), DELTA);
+    }
+
+    @Test
+    public void testCoordinateSpan() {
+        CoordinateSpan coordinateSpan = mLatLngBounds.getSpan();
+        assertEquals("CoordinateSpan should be the same", new CoordinateSpan(2, 2), coordinateSpan);
+    }
+
+    @Test
+    public void testCenter() {
+        LatLng center = mLatLngBounds.getCenter();
+        assertEquals("Center should match", new LatLng(1, 1), center);
+    }
+
+    @Test
+    public void testEmptySpan() {
+        mLatLngBounds = new LatLngBounds.Builder()
+                .include(LAT_LNG_NOT_NULL_ISLAND)
+                .include(LAT_LNG_NOT_NULL_ISLAND)
+                .build();
+        assertTrue("Should be empty", mLatLngBounds.isEmptySpan());
+    }
+
+    @Test
+    public void testNotEmptySpan() {
+        mLatLngBounds = new LatLngBounds.Builder()
+                .include(LAT_LNG_NOT_NULL_ISLAND)
+                .include(LAT_LNG_NULL_ISLAND)
+                .build();
+        assertFalse("Should not be empty", mLatLngBounds.isEmptySpan());
+    }
+
+    @Test
+    public void testIncluding() {
+        assertTrue("LatLng should be included", mLatLngBounds.including(new LatLng(1, 1)));
+    }
+
+    @Test
+    public void testNoIncluding() {
+        assertFalse("LatLng should not be included", mLatLngBounds.including(new LatLng(3, 1)));
+    }
+
+    @Test
+    public void testHashCode() {
+        assertEquals(2147483647, mLatLngBounds.hashCode(), -1946419200);
+    }
+
+    @Test
+    public void testEquality() {
+        LatLngBounds latLngBounds = new LatLngBounds.Builder()
+                .include(LAT_LNG_NULL_ISLAND)
+                .include(LAT_LNG_NOT_NULL_ISLAND)
+                .build();
+        assertEquals("equality should match", mLatLngBounds, latLngBounds);
+    }
+
+    @Test
+    public void testToString() {
+        assertEquals(mLatLngBounds.toString(), "N:2.0; E:2.0; S:0.0; W:0.0");
+    }
+
+    @Test
+    public void testIntersect() {
+        LatLngBounds latLngBounds = new LatLngBounds.Builder()
+                .include(new LatLng(1, 1))
+                .include(LAT_LNG_NULL_ISLAND)
+                .build();
+        assertEquals("intersect should match", latLngBounds, latLngBounds.intersect(mLatLngBounds.getLatNorth(), mLatLngBounds.getLonEast(), mLatLngBounds.getLatSouth(), mLatLngBounds.getLonWest()));
+    }
+
+    @Test
+    public void testNoIntersect() {
+        LatLngBounds latLngBounds = new LatLngBounds.Builder()
+                .include(new LatLng(10, 10))
+                .include(new LatLng(9, 8))
+                .build();
+        assertNull(latLngBounds.intersect(mLatLngBounds));
+    }
+
+    @Test
+    public void testInnerUnion() {
+        LatLngBounds latLngBounds = new LatLngBounds.Builder()
+                .include(new LatLng(1, 1))
+                .include(LAT_LNG_NULL_ISLAND)
+                .build();
+        assertEquals("union should match", latLngBounds, latLngBounds.intersect(mLatLngBounds));
+    }
+
+    @Test
+    public void testOuterUnion() {
+        LatLngBounds latLngBounds = new LatLngBounds.Builder()
+                .include(new LatLng(10, 10))
+                .include(new LatLng(9, 8))
+                .build();
+        assertEquals("outer union should match",
+                latLngBounds.union(mLatLngBounds),
+                new LatLngBounds.Builder()
+                        .include(new LatLng(10, 10))
+                        .include(LAT_LNG_NULL_ISLAND)
+                        .build());
+    }
+
+
+}