Adds checkstyle to CI (#7442)

* adds checkstyle to CI

* fixed gradlew path

* resolved testapp checkstyle violations

* added back mapboxMap variable for test

* checkstyle annotations

* checkstyle SDK round 1

* maps package checkstyle

* rest of SDK checkstyle

* checkstyle gesture library

* checkstyle test

* finished rest of test checkstyle

* resolved all checkstyle errors

* fixed class name

* removed old test file

* fixed camera postion test

* fixed native crash

1 files changed, 169 insertions, 167 deletions

diff --git a/platform/android/MapboxGLAndroidSDKTestApp/src/main/java/com/mapbox/mapboxsdk/testapp/activity/FeatureOverviewActivity.java b/platform/android/MapboxGLAndroidSDKTestApp/src/main/java/com/mapbox/mapboxsdk/testapp/activity/FeatureOverviewActivity.java
index 9a7badf0fa..9ba51e2694 100644
--- a/platform/android/MapboxGLAndroidSDKTestApp/src/main/java/com/mapbox/mapboxsdk/testapp/activity/FeatureOverviewActivity.java
+++ b/platform/android/MapboxGLAndroidSDKTestApp/src/main/java/com/mapbox/mapboxsdk/testapp/activity/FeatureOverviewActivity.java
@@ -19,7 +19,9 @@ import android.support.v7.app.AppCompatActivity;
 import android.support.v7.widget.LinearLayoutManager;
 import android.support.v7.widget.RecyclerView;
 import android.support.v7.widget.Toolbar;
+
 import timber.log.Timber;
+
 import android.view.View;
 
 import com.mapbox.mapboxsdk.testapp.R;
@@ -35,199 +37,199 @@ import java.util.List;
 
 public class FeatureOverviewActivity extends AppCompatActivity {
 
-    private static final String KEY_STATE_FEATURES = "featureList";
+  private static final String KEY_STATE_FEATURES = "featureList";
 
-    private RecyclerView recyclerView;
-    private FeatureSectionAdapter sectionAdapter;
-    private List<Feature> features;
+  private RecyclerView recyclerView;
+  private FeatureSectionAdapter sectionAdapter;
+  private List<Feature> features;
 
-    @Override
-    protected void onCreate(Bundle savedInstanceState) {
-        super.onCreate(savedInstanceState);
-        setContentView(R.layout.activity_main);
+  @Override
+  protected void onCreate(Bundle savedInstanceState) {
+    super.onCreate(savedInstanceState);
+    setContentView(R.layout.activity_main);
 
-        Toolbar toolbar = (Toolbar) findViewById(R.id.toolbar);
-        toolbar.setTitle(getString(R.string.app_name));
-        setSupportActionBar(toolbar);
-
-        ActionBar actionBar = getSupportActionBar();
-        if (actionBar != null) {
-            actionBar.setElevation(getResources().getDimension(R.dimen.toolbar_shadow));
-        }
+    Toolbar toolbar = (Toolbar) findViewById(R.id.toolbar);
+    toolbar.setTitle(getString(R.string.app_name));
+    setSupportActionBar(toolbar);
 
-        recyclerView = (RecyclerView) findViewById(R.id.recyclerView);
-        recyclerView.setLayoutManager(new LinearLayoutManager(this));
-        recyclerView.addOnItemTouchListener(new RecyclerView.SimpleOnItemTouchListener());
-        recyclerView.setHasFixedSize(true);
-
-        ItemClickSupport.addTo(recyclerView).setOnItemClickListener(new ItemClickSupport.OnItemClickListener() {
-            @Override
-            public void onItemClicked(RecyclerView recyclerView, int position, View view) {
-                if (!sectionAdapter.isSectionHeaderPosition(position)) {
-                    int itemPosition = sectionAdapter.getConvertedPosition(position);
-                    Feature feature = features.get(itemPosition);
-                    if (feature.isRequiresLocationPermission()) {
-                        if (requestLocationPermission(itemPosition)) {
-                            return;
-                        }
-                    }
-                    startFeature(feature);
-                }
-            }
-        });
-
-        if (savedInstanceState == null) {
-            loadFeatures();
-        } else {
-            features = savedInstanceState.getParcelableArrayList(KEY_STATE_FEATURES);
-            onFeaturesLoaded(features);
-        }
+    ActionBar actionBar = getSupportActionBar();
+    if (actionBar != null) {
+      actionBar.setElevation(getResources().getDimension(R.dimen.toolbar_shadow));
     }
 
-    private void loadFeatures() {
-        try {
-            new LoadFeatureTask().execute(
-                getPackageManager().getPackageInfo(getPackageName(),
-                    PackageManager.GET_ACTIVITIES | PackageManager.GET_META_DATA));
-        } catch (PackageManager.NameNotFoundException exception) {
-            Timber.e("Could not resolve package info", exception);
-        }
-    }
-
-    private void onFeaturesLoaded(List<Feature> featuresList) {
-        features = featuresList;
-
-        List<FeatureSectionAdapter.Section> sections = new ArrayList<>();
-        String currentCat = "";
-        for (int i = 0; i < features.size(); i++) {
-            String category = features.get(i).getCategory();
-            if (!currentCat.equals(category)) {
-                sections.add(new FeatureSectionAdapter.Section(i, category));
-                currentCat = category;
+    recyclerView = (RecyclerView) findViewById(R.id.recyclerView);
+    recyclerView.setLayoutManager(new LinearLayoutManager(this));
+    recyclerView.addOnItemTouchListener(new RecyclerView.SimpleOnItemTouchListener());
+    recyclerView.setHasFixedSize(true);
+
+    ItemClickSupport.addTo(recyclerView).setOnItemClickListener(new ItemClickSupport.OnItemClickListener() {
+      @Override
+      public void onItemClicked(RecyclerView recyclerView, int position, View view) {
+        if (!sectionAdapter.isSectionHeaderPosition(position)) {
+          int itemPosition = sectionAdapter.getConvertedPosition(position);
+          Feature feature = features.get(itemPosition);
+          if (feature.isRequiresLocationPermission()) {
+            if (requestLocationPermission(itemPosition)) {
+              return;
             }
+          }
+          startFeature(feature);
         }
-
-        FeatureSectionAdapter.Section[] dummy = new FeatureSectionAdapter.Section[sections.size()];
-        sectionAdapter = new FeatureSectionAdapter(
-            this, R.layout.section_main_layout, R.id.section_text, new FeatureAdapter(features));
-        sectionAdapter.setSections(sections.toArray(dummy));
-        recyclerView.setAdapter(sectionAdapter);
+      }
+    });
+
+    if (savedInstanceState == null) {
+      loadFeatures();
+    } else {
+      features = savedInstanceState.getParcelableArrayList(KEY_STATE_FEATURES);
+      onFeaturesLoaded(features);
     }
-
-    private void startFeature(Feature feature) {
-        Intent intent = new Intent();
-        intent.setComponent(new ComponentName(getPackageName(), feature.getName()));
-        startActivity(intent);
+  }
+
+  private void loadFeatures() {
+    try {
+      new LoadFeatureTask().execute(
+        getPackageManager().getPackageInfo(getPackageName(),
+          PackageManager.GET_ACTIVITIES | PackageManager.GET_META_DATA));
+    } catch (PackageManager.NameNotFoundException exception) {
+      Timber.e("Could not resolve package info", exception);
     }
-
-    private boolean requestLocationPermission(final int positionInList) {
-        if ((ContextCompat.checkSelfPermission(FeatureOverviewActivity.this,
-            Manifest.permission.ACCESS_COARSE_LOCATION) != PackageManager.PERMISSION_GRANTED)
-            || (ContextCompat.checkSelfPermission(FeatureOverviewActivity.this,
-            Manifest.permission.ACCESS_FINE_LOCATION) != PackageManager.PERMISSION_GRANTED)) {
-            ActivityCompat.requestPermissions(FeatureOverviewActivity.this, new String[]{
-                Manifest.permission.ACCESS_COARSE_LOCATION, Manifest.permission.ACCESS_FINE_LOCATION}, positionInList);
-            return true;
-        } else {
-            return false;
-        }
+  }
+
+  private void onFeaturesLoaded(List<Feature> featuresList) {
+    features = featuresList;
+
+    List<FeatureSectionAdapter.Section> sections = new ArrayList<>();
+    String currentCat = "";
+    for (int i = 0; i < features.size(); i++) {
+      String category = features.get(i).getCategory();
+      if (!currentCat.equals(category)) {
+        sections.add(new FeatureSectionAdapter.Section(i, category));
+        currentCat = category;
+      }
     }
 
-    @Override
-    public void onRequestPermissionsResult(int requestCode, @NonNull String[] permissions, @NonNull int[] grantResults) {
-        if (grantResults.length > 0 && grantResults[0] == PackageManager.PERMISSION_GRANTED) {
-            startFeature(features.get(requestCode));
-        } else {
-            Snackbar.make(
-                findViewById(android.R.id.content),
-                "Can't open without accepting the location permission.",
-                Snackbar.LENGTH_SHORT).show();
-        }
+    FeatureSectionAdapter.Section[] dummy = new FeatureSectionAdapter.Section[sections.size()];
+    sectionAdapter = new FeatureSectionAdapter(
+      this, R.layout.section_main_layout, R.id.section_text, new FeatureAdapter(features));
+    sectionAdapter.setSections(sections.toArray(dummy));
+    recyclerView.setAdapter(sectionAdapter);
+  }
+
+  private void startFeature(Feature feature) {
+    Intent intent = new Intent();
+    intent.setComponent(new ComponentName(getPackageName(), feature.getName()));
+    startActivity(intent);
+  }
+
+  private boolean requestLocationPermission(final int positionInList) {
+    if ((ContextCompat.checkSelfPermission(FeatureOverviewActivity.this,
+      Manifest.permission.ACCESS_COARSE_LOCATION) != PackageManager.PERMISSION_GRANTED)
+      || (ContextCompat.checkSelfPermission(FeatureOverviewActivity.this,
+      Manifest.permission.ACCESS_FINE_LOCATION) != PackageManager.PERMISSION_GRANTED)) {
+      ActivityCompat.requestPermissions(FeatureOverviewActivity.this, new String[] {
+        Manifest.permission.ACCESS_COARSE_LOCATION, Manifest.permission.ACCESS_FINE_LOCATION}, positionInList);
+      return true;
+    } else {
+      return false;
     }
-
-    @Override
-    protected void onSaveInstanceState(Bundle outState) {
-        super.onSaveInstanceState(outState);
-        outState.putParcelableArrayList(KEY_STATE_FEATURES, (ArrayList<Feature>) features);
+  }
+
+  @Override
+  public void onRequestPermissionsResult(int requestCode, @NonNull String[] permissions, @NonNull int[] grantResults) {
+    if (grantResults.length > 0 && grantResults[0] == PackageManager.PERMISSION_GRANTED) {
+      startFeature(features.get(requestCode));
+    } else {
+      Snackbar.make(
+        findViewById(android.R.id.content),
+        "Can't open without accepting the location permission.",
+        Snackbar.LENGTH_SHORT).show();
     }
+  }
 
-    private class LoadFeatureTask extends AsyncTask<PackageInfo, Void, List<Feature>> {
-
-        @Override
-        protected List<Feature> doInBackground(PackageInfo... params) {
-            List<Feature> features = new ArrayList<>();
-            PackageInfo app = params[0];
-
-            String packageName = getApplicationContext().getPackageName();
-            String metaDataKey = getString(R.string.category);
-            for (ActivityInfo info : app.activities) {
-                if (info.labelRes != 0 && info.name.startsWith(packageName)
-                    && !info.name.equals(FeatureOverviewActivity.class.getName())) {
-                    String label = getString(info.labelRes);
-                    String description = resolveString(info.descriptionRes);
-                    String category = resolveMetaData(info.metaData, metaDataKey);
-                    boolean requiresLocationPermission = requiresLocationPermission(label, category);
-                    features.add(new Feature(info.name, label, description, category, requiresLocationPermission));
-                }
-            }
+  @Override
+  protected void onSaveInstanceState(Bundle outState) {
+    super.onSaveInstanceState(outState);
+    outState.putParcelableArrayList(KEY_STATE_FEATURES, (ArrayList<Feature>) features);
+  }
 
-            if (!features.isEmpty()) {
-                Comparator<Feature> comparator = new Comparator<Feature>() {
-                    @Override
-                    public int compare(Feature lhs, Feature rhs) {
-                        int result = lhs.getCategory().compareToIgnoreCase(rhs.getCategory());
-                        if (result == 0) {
-                            result = lhs.getLabel().compareToIgnoreCase(rhs.getLabel());
-                        }
-                        return result;
-                    }
-                };
-                Collections.sort(features, comparator);
-            }
+  private class LoadFeatureTask extends AsyncTask<PackageInfo, Void, List<Feature>> {
 
-            return features;
+    @Override
+    protected List<Feature> doInBackground(PackageInfo... params) {
+      List<Feature> features = new ArrayList<>();
+      PackageInfo app = params[0];
+
+      String packageName = getApplicationContext().getPackageName();
+      String metaDataKey = getString(R.string.category);
+      for (ActivityInfo info : app.activities) {
+        if (info.labelRes != 0 && info.name.startsWith(packageName)
+          && !info.name.equals(FeatureOverviewActivity.class.getName())) {
+          String label = getString(info.labelRes);
+          String description = resolveString(info.descriptionRes);
+          String category = resolveMetaData(info.metaData, metaDataKey);
+          boolean requiresLocationPermission = requiresLocationPermission(label, category);
+          features.add(new Feature(info.name, label, description, category, requiresLocationPermission));
         }
-
-        private String resolveMetaData(Bundle bundle, String key) {
-            String category = null;
-            if (bundle != null) {
-                category = bundle.getString(key);
+      }
+
+      if (!features.isEmpty()) {
+        Comparator<Feature> comparator = new Comparator<Feature>() {
+          @Override
+          public int compare(Feature lhs, Feature rhs) {
+            int result = lhs.getCategory().compareToIgnoreCase(rhs.getCategory());
+            if (result == 0) {
+              result = lhs.getLabel().compareToIgnoreCase(rhs.getLabel());
             }
-            return category;
-        }
+            return result;
+          }
+        };
+        Collections.sort(features, comparator);
+      }
 
-        private String resolveString(@StringRes int stringRes) {
-            try {
-                return getString(stringRes);
-            } catch (Resources.NotFoundException exception) {
-                return "-";
-            }
-        }
+      return features;
+    }
 
-        private boolean requiresLocationPermission(String name, String category) {
-            final Resources resources = getResources();
+    private String resolveMetaData(Bundle bundle, String key) {
+      String category = null;
+      if (bundle != null) {
+        category = bundle.getString(key);
+      }
+      return category;
+    }
 
-            List<String> requiresPermissionCategories = new ArrayList<String>() {
-                {
-                    add(resources.getString(R.string.category_userlocation));
-                }
-            };
+    private String resolveString(@StringRes int stringRes) {
+      try {
+        return getString(stringRes);
+      } catch (Resources.NotFoundException exception) {
+        return "-";
+      }
+    }
 
-            List<String> requiresPermissionActvities = new ArrayList<String>() {
-                {
-                    add(resources.getString(R.string.activity_double_map));
-                    add(getString(R.string.activity_location_picker));
-                    add(getString(R.string.activity_car_driving));
-                }
-            };
+    private boolean requiresLocationPermission(String name, String category) {
+      final Resources resources = getResources();
 
-            return requiresPermissionCategories.contains(category) || requiresPermissionActvities.contains(name);
+      List<String> requiresPermissionCategories = new ArrayList<String>() {
+        {
+          add(resources.getString(R.string.category_userlocation));
         }
+      };
 
-        @Override
-        protected void onPostExecute(List<Feature> features) {
-            super.onPostExecute(features);
-            onFeaturesLoaded(features);
+      List<String> requiresPermissionActvities = new ArrayList<String>() {
+        {
+          add(resources.getString(R.string.activity_double_map));
+          add(getString(R.string.activity_location_picker));
+          add(getString(R.string.activity_car_driving));
         }
+      };
+
+      return requiresPermissionCategories.contains(category) || requiresPermissionActvities.contains(name);
+    }
+
+    @Override
+    protected void onPostExecute(List<Feature> features) {
+      super.onPostExecute(features);
+      onFeaturesLoaded(features);
     }
+  }
 }
\ No newline at end of file