Adds checkstyle to CI (#7442)

* adds checkstyle to CI

* fixed gradlew path

* resolved testapp checkstyle violations

* added back mapboxMap variable for test

* checkstyle annotations

* checkstyle SDK round 1

* maps package checkstyle

* rest of SDK checkstyle

* checkstyle gesture library

* checkstyle test

* finished rest of test checkstyle

* resolved all checkstyle errors

* fixed class name

* removed old test file

* fixed camera postion test

* fixed native crash

6 files changed, 162 insertions, 158 deletions

diff --git a/platform/android/MapboxGLAndroidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/testapp/utils/DrawerUtils.java b/platform/android/MapboxGLAndroidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/testapp/utils/DrawerUtils.java
index 8d8905fdf4..d9ced47369 100644
--- a/platform/android/MapboxGLAndroidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/testapp/utils/DrawerUtils.java
+++ b/platform/android/MapboxGLAndroidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/testapp/utils/DrawerUtils.java
@@ -15,15 +15,15 @@ import static android.support.test.espresso.matcher.ViewMatchers.withContentDesc
 
 public class DrawerUtils {
 
-    private final static String HOME_BUTTON_STRING = "Navigate up";
+  private static final String HOME_BUTTON_STRING = "Navigate up";
 
-    public static void openDrawer(){
-        onView(withContentDescription(HOME_BUTTON_STRING)).perform(click());
-    }
+  public static void openDrawer() {
+    onView(withContentDescription(HOME_BUTTON_STRING)).perform(click());
+  }
 
-    public static void clickItem(@StringRes int txtId){
-        Espresso.onView(Matchers.allOf(ViewMatchers.withId(R.id.design_menu_item_text),
-                ViewMatchers.hasSibling(ViewMatchers.withText(txtId)))).perform(ViewActions.click());
-    }
+  public static void clickItem(@StringRes int txtId) {
+    Espresso.onView(Matchers.allOf(ViewMatchers.withId(R.id.design_menu_item_text),
+      ViewMatchers.hasSibling(ViewMatchers.withText(txtId)))).perform(ViewActions.click());
+  }
 
 }
diff --git a/platform/android/MapboxGLAndroidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/testapp/utils/GestureUtils.java b/platform/android/MapboxGLAndroidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/testapp/utils/GestureUtils.java
index 114fbc549e..3376f5eda4 100644
--- a/platform/android/MapboxGLAndroidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/testapp/utils/GestureUtils.java
+++ b/platform/android/MapboxGLAndroidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/testapp/utils/GestureUtils.java
@@ -8,8 +8,8 @@ import static android.support.test.espresso.matcher.ViewMatchers.withId;
 
 public class GestureUtils {
 
-    public static void doubleClickGesture(@IdRes int id){
-        onView(withId(id)).perform(doubleClick());
-    }
+  public static void doubleClickGesture(@IdRes int id) {
+    onView(withId(id)).perform(doubleClick());
+  }
 
 }
diff --git a/platform/android/MapboxGLAndroidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/testapp/utils/OnMapReadyIdlingResource.java b/platform/android/MapboxGLAndroidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/testapp/utils/OnMapReadyIdlingResource.java
index f00c76132c..6e582c6a3a 100644
--- a/platform/android/MapboxGLAndroidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/testapp/utils/OnMapReadyIdlingResource.java
+++ b/platform/android/MapboxGLAndroidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/testapp/utils/OnMapReadyIdlingResource.java
@@ -2,6 +2,7 @@ package com.mapbox.mapboxsdk.testapp.utils;
 
 import android.app.Activity;
 import android.support.test.espresso.IdlingResource;
+
 import timber.log.Timber;
 
 import com.mapbox.mapboxsdk.maps.MapboxMap;
@@ -10,47 +11,47 @@ import java.lang.reflect.Field;
 
 public class OnMapReadyIdlingResource implements IdlingResource {
 
-    private final Activity activity;
-    private MapboxMap mapboxMap;
-    private IdlingResource.ResourceCallback resourceCallback;
+  private final Activity activity;
+  private MapboxMap mapboxMap;
+  private IdlingResource.ResourceCallback resourceCallback;
 
-    public OnMapReadyIdlingResource(Activity activity) {
-        this.activity = activity;
-    }
+  public OnMapReadyIdlingResource(Activity activity) {
+    this.activity = activity;
+  }
 
-    @Override
-    public String getName() {
-        return getClass().getSimpleName();
-    }
+  @Override
+  public String getName() {
+    return getClass().getSimpleName();
+  }
 
-    @Override
-    public boolean isIdleNow() {
-        boolean idle = isMapboxMapReady();
-        if (idle && resourceCallback != null) {
-            resourceCallback.onTransitionToIdle();
-        }
-        return idle;
+  @Override
+  public boolean isIdleNow() {
+    boolean idle = isMapboxMapReady();
+    if (idle && resourceCallback != null) {
+      resourceCallback.onTransitionToIdle();
     }
-
-    @Override
-    public void registerIdleTransitionCallback(ResourceCallback resourceCallback) {
-        this.resourceCallback = resourceCallback;
+    return idle;
+  }
+
+  @Override
+  public void registerIdleTransitionCallback(ResourceCallback resourceCallback) {
+    this.resourceCallback = resourceCallback;
+  }
+
+  private boolean isMapboxMapReady() {
+    try {
+      Field field = activity.getClass().getDeclaredField("mapboxMap");
+      field.setAccessible(true);
+      mapboxMap = (MapboxMap) field.get(activity);
+      Timber.e("isMapboxReady called with value " + (mapboxMap != null));
+      return mapboxMap != null;
+    } catch (Exception exception) {
+      Timber.e("could not reflect", exception);
+      return false;
     }
+  }
 
-    private boolean isMapboxMapReady() {
-        try {
-            Field field = activity.getClass().getDeclaredField("mapboxMap");
-            field.setAccessible(true);
-            mapboxMap = (MapboxMap) field.get(activity);
-            Timber.e("isMapboxReady called with value " + (mapboxMap != null));
-            return mapboxMap != null;
-        } catch (Exception e) {
-            Timber.e("could not reflect", e);
-            return false;
-        }
-    }
-
-    public MapboxMap getMapboxMap() {
-        return mapboxMap;
-    }
+  public MapboxMap getMapboxMap() {
+    return mapboxMap;
+  }
 }
diff --git a/platform/android/MapboxGLAndroidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/testapp/utils/ScreenshotUtil.java b/platform/android/MapboxGLAndroidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/testapp/utils/ScreenshotUtil.java
index 84bfa2c8c3..77bfc519bf 100644
--- a/platform/android/MapboxGLAndroidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/testapp/utils/ScreenshotUtil.java
+++ b/platform/android/MapboxGLAndroidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/testapp/utils/ScreenshotUtil.java
@@ -4,7 +4,9 @@ import android.app.Activity;
 import android.graphics.Bitmap;
 import android.graphics.Canvas;
 import android.os.Environment;
+
 import timber.log.Timber;
+
 import android.view.TextureView;
 import android.view.View;
 import android.view.ViewGroup;
@@ -23,112 +25,113 @@ import java.util.UUID;
  */
 public class ScreenshotUtil {
 
-    // Where to store the files. This path is required by AWS Device Farm:
-    // http://docs.aws.amazon.com/devicefarm/latest/developerguide/test-types-android-instrumentation.html#test-types-android-instrumentation-screenshots
-    private static final String SCREENSHOT_FOLDER = "test-screenshots";
+  // Where to store the files. This path is required by AWS Device Farm:
+  // http://docs.aws.amazon.com/devicefarm/latest/developerguide/test-types-android-instrumentation.html
+  // #test-types-android-instrumentation-screenshots
+  private static final String SCREENSHOT_FOLDER = "test-screenshots";
 
-    // Image type and quality
-    private static final String DEFAULT_IMAGE_EXTENSION = ".png";
-    private static final Bitmap.CompressFormat DEFAULT_IMAGE_FORMAT = Bitmap.CompressFormat.PNG;
-    private static final int DEFAULT_IMAGE_QUALITY = 100;
+  // Image type and quality
+  private static final String DEFAULT_IMAGE_EXTENSION = ".png";
+  private static final Bitmap.CompressFormat DEFAULT_IMAGE_FORMAT = Bitmap.CompressFormat.PNG;
+  private static final int DEFAULT_IMAGE_QUALITY = 100;
 
-    public static void take(Activity activity, String testName) {
+  public static void take(Activity activity, String testName) {
 
-        // Check if storage is available
-        if (!isExternalStorageWritable()) {
-            Timber.d("External storage is not available.");
-            return;
-        }
+    // Check if storage is available
+    if (!isExternalStorageWritable()) {
+      Timber.d("External storage is not available.");
+      return;
+    }
 
-        // Get a bitmap from the activity root view. When the drawing cache is enabled,
-//        // the next call to getDrawingCache() will draw the view in a bitmap.
-        View rootView = activity.getWindow().getDecorView().getRootView();
-//        rootView.setDrawingCacheEnabled(true);r
-//        rootView.setDrawingCacheEnabled(false);
-
-        Bitmap bitmap = null;
-
-        // Add the SurfaceView bit (see getAllTextureViews() below)
-        List<TextureView> tilingViews = getAllTextureViews(rootView);
-        if (tilingViews.size() > 0) {
-            bitmap = Bitmap.createBitmap(tilingViews.get(0).getHeight(),tilingViews.get(0).getWidth(), Bitmap.Config.ARGB_8888);
-            Canvas canvas = new Canvas(bitmap);
-            for (TextureView TextureView : tilingViews) {
-                Bitmap b = TextureView.getBitmap(TextureView.getWidth(), TextureView.getHeight());
-                int[] location = new int[2];
-                TextureView.getLocationInWindow(location);
-                int[] location2 = new int[2];
-                TextureView.getLocationOnScreen(location2);
-                canvas.drawBitmap(b, 0,0, null);
-            }
-        }
+    // Get a bitmap from the activity root view. When the drawing cache is enabled,
+    // the next call to getDrawingCache() will draw the view in a bitmap.
+    View rootView = activity.getWindow().getDecorView().getRootView();
+    // rootView.setDrawingCacheEnabled(true);r
+    // rootView.setDrawingCacheEnabled(false);
+
+    Bitmap bitmap = null;
+
+    // Add the SurfaceView bit (see getAllTextureViews() below)
+    List<TextureView> tilingViews = getAllTextureViews(rootView);
+    if (tilingViews.size() > 0) {
+      bitmap = Bitmap.createBitmap(tilingViews.get(0).getHeight(), tilingViews.get(0).getWidth(),
+        Bitmap.Config.ARGB_8888);
+      Canvas canvas = new Canvas(bitmap);
+      for (TextureView TextureView : tilingViews) {
+        Bitmap b = TextureView.getBitmap(TextureView.getWidth(), TextureView.getHeight());
+        int[] location = new int[2];
+        TextureView.getLocationInWindow(location);
+        int[] location2 = new int[2];
+        TextureView.getLocationOnScreen(location2);
+        canvas.drawBitmap(b, 0, 0, null);
+      }
+    }
 
-        // Save the bitmap in external storage
-        String uniqueAbsolutePath = getUniqueAbsolutePath(testName);
-        File outputFile = new File(uniqueAbsolutePath);
-        OutputStream outputStream = null;
+    // Save the bitmap in external storage
+    String uniqueAbsolutePath = getUniqueAbsolutePath(testName);
+    File outputFile = new File(uniqueAbsolutePath);
+    OutputStream outputStream = null;
+    try {
+      outputStream = new FileOutputStream(outputFile);
+      bitmap.compress(DEFAULT_IMAGE_FORMAT, DEFAULT_IMAGE_QUALITY, outputStream);
+      outputStream.flush();
+    } catch (Exception exception) {
+
+      exception.printStackTrace();
+    } finally {
+      if (outputStream != null) {
         try {
-            outputStream = new FileOutputStream(outputFile);
-            bitmap.compress(DEFAULT_IMAGE_FORMAT, DEFAULT_IMAGE_QUALITY, outputStream);
-            outputStream.flush();
-        } catch (Exception e) {
-
-            e.printStackTrace();
-        } finally {
-            if (outputStream != null) {
-                try {
-                    outputStream.close();
-                } catch (IOException e) {
-                    e.printStackTrace();
-                }
-            }
+          outputStream.close();
+        } catch (IOException ioException) {
+          ioException.printStackTrace();
         }
+      }
     }
-
-    /*
-     * The classic way of taking a screenshot (above) doesn't work with TextureView, this fixes it:
-     * http://stackoverflow.com/questions/19704060/screen-capture-textureview-is-black-using-drawingcache
-     */
-
-    public static List<TextureView> getAllTextureViews(View view)
-    {
-        List<TextureView> tilingViews = new ArrayList<TextureView>();
-        if (view instanceof TextureView) {
-            tilingViews.add((TextureView)view);
-        }  else if(view instanceof ViewGroup) {
-            ViewGroup viewGroup = (ViewGroup)view;
-            for (int i = 0; i < viewGroup.getChildCount(); i++) {
-                tilingViews.addAll(getAllTextureViews(viewGroup.getChildAt(i)));
-            }
-        }
-
-        return tilingViews;
+  }
+
+  /*
+   * The classic way of taking a screenshot (above) doesn't work with TextureView, this fixes it:
+   * http://stackoverflow.com/questions/19704060/screen-capture-textureview-is-black-using-drawingcache
+   */
+
+  public static List<TextureView> getAllTextureViews(View view) {
+    List<TextureView> tilingViews = new ArrayList<TextureView>();
+    if (view instanceof TextureView) {
+      tilingViews.add((TextureView) view);
+    } else if (view instanceof ViewGroup) {
+      ViewGroup viewGroup = (ViewGroup) view;
+      for (int i = 0; i < viewGroup.getChildCount(); i++) {
+        tilingViews.addAll(getAllTextureViews(viewGroup.getChildAt(i)));
+      }
     }
 
-    /*
-     * Utils
-     */
+    return tilingViews;
+  }
 
-    public static boolean isExternalStorageWritable() {
-        // Checks if external storage is available for read and write
-        String state = Environment.getExternalStorageState();
-        return Environment.MEDIA_MOUNTED.equals(state);
-    }
+  /*
+   * Utils
+   */
 
-    private static String getUniqueAbsolutePath(String testName) {
-        // A screenshot after every test vs. manual tests
-        String filename = UUID.randomUUID().toString() + DEFAULT_IMAGE_EXTENSION;
-        if (testName != null && !testName.isEmpty()) {
-            filename = testName + DEFAULT_IMAGE_EXTENSION;
-        }
+  public static boolean isExternalStorageWritable() {
+    // Checks if external storage is available for read and write
+    String state = Environment.getExternalStorageState();
+    return Environment.MEDIA_MOUNTED.equals(state);
+  }
 
-        String externalPath = Environment.getExternalStorageDirectory().toString();
-        String path = externalPath + File.separator + SCREENSHOT_FOLDER;
-        File dir = new File(path);
-        dir.mkdirs();
-        path += File.separator + filename;
-        Timber.d("Screenshot path: " + path);
-        return path;
+  private static String getUniqueAbsolutePath(String testName) {
+    // A screenshot after every test vs. manual tests
+    String filename = UUID.randomUUID().toString() + DEFAULT_IMAGE_EXTENSION;
+    if (testName != null && !testName.isEmpty()) {
+      filename = testName + DEFAULT_IMAGE_EXTENSION;
     }
 
+    String externalPath = Environment.getExternalStorageDirectory().toString();
+    String path = externalPath + File.separator + SCREENSHOT_FOLDER;
+    File dir = new File(path);
+    dir.mkdirs();
+    path += File.separator + filename;
+    Timber.d("Screenshot path: " + path);
+    return path;
+  }
+
 }
diff --git a/platform/android/MapboxGLAndroidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/testapp/utils/TestConstants.java b/platform/android/MapboxGLAndroidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/testapp/utils/TestConstants.java
index ef46da43ee..965f5d1443 100644
--- a/platform/android/MapboxGLAndroidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/testapp/utils/TestConstants.java
+++ b/platform/android/MapboxGLAndroidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/testapp/utils/TestConstants.java
@@ -4,15 +4,15 @@ import com.mapbox.mapboxsdk.constants.MapboxConstants;
 
 public class TestConstants {
 
-    public static final long ANIMATION_TEST_TIME = MapboxConstants.ANIMATION_DURATION * 2;
+  public static final long ANIMATION_TEST_TIME = MapboxConstants.ANIMATION_DURATION * 2;
 
-    public static final double LAT_LNG_DELTA_LARGE = 0.1;
-    public static final double LAT_LNG_DELTA = 0.01;
-    public static final double BEARING_DELTA = 0.1;
-    public static final double TILT_DELTA = 0.1;
-    public static final double ZOOM_DELTA = 0.3;
+  public static final double LAT_LNG_DELTA_LARGE = 0.1;
+  public static final double LAT_LNG_DELTA = 0.01;
+  public static final double BEARING_DELTA = 0.1;
+  public static final double TILT_DELTA = 0.1;
+  public static final double ZOOM_DELTA = 0.3;
 
-    public static final String TEXT_MARKER_TEXT = "Text";
-    public static final String TEXT_MARKER_TITLE = "Marker";
-    public static final String TEXT_MARKER_SNIPPET = "Snippet";
+  public static final String TEXT_MARKER_TEXT = "Text";
+  public static final String TEXT_MARKER_TITLE = "Marker";
+  public static final String TEXT_MARKER_SNIPPET = "Snippet";
 }
diff --git a/platform/android/MapboxGLAndroidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/testapp/utils/ViewUtils.java b/platform/android/MapboxGLAndroidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/testapp/utils/ViewUtils.java
index 188e75edc7..5c4d5a03c3 100644
--- a/platform/android/MapboxGLAndroidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/testapp/utils/ViewUtils.java
+++ b/platform/android/MapboxGLAndroidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/testapp/utils/ViewUtils.java
@@ -10,13 +10,13 @@ import static android.support.test.espresso.matcher.ViewMatchers.withId;
 
 public class ViewUtils {
 
-    public static void clickView(@IdRes int viewRes) {
-        onView(withId(viewRes))
-                .perform(click());
-    }
+  public static void clickView(@IdRes int viewRes) {
+    onView(withId(viewRes))
+      .perform(click());
+  }
 
-    public static void checkViewIsDisplayed(int id) {
-        onView(withId(id))
-                .check(matches(isDisplayed()));
-    }
+  public static void checkViewIsDisplayed(int id) {
+    onView(withId(id))
+      .check(matches(isDisplayed()));
+  }
 }