Adds checkstyle to CI (#7442)

* adds checkstyle to CI

* fixed gradlew path

* resolved testapp checkstyle violations

* added back mapboxMap variable for test

* checkstyle annotations

* checkstyle SDK round 1

* maps package checkstyle

* rest of SDK checkstyle

* checkstyle gesture library

* checkstyle test

* finished rest of test checkstyle

* resolved all checkstyle errors

* fixed class name

* removed old test file

* fixed camera postion test

* fixed native crash

1 files changed, 210 insertions, 195 deletions

diff --git a/platform/android/MapboxGLAndroidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/testapp/camera/CameraMoveTest.java b/platform/android/MapboxGLAndroidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/testapp/camera/CameraMoveTest.java
index 80f5dda77e..b3a7fe0d11 100644
--- a/platform/android/MapboxGLAndroidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/testapp/camera/CameraMoveTest.java
+++ b/platform/android/MapboxGLAndroidSDKTestApp/src/androidTest/java/com/mapbox/mapboxsdk/testapp/camera/CameraMoveTest.java
@@ -29,209 +29,224 @@ import static android.support.test.espresso.Espresso.onView;
 import static android.support.test.espresso.matcher.ViewMatchers.isDisplayed;
 import static android.support.test.espresso.matcher.ViewMatchers.withId;
 import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertTrue;
 
 public class CameraMoveTest {
-    
-    @Rule
-    public final ActivityTestRule<EspressoTestActivity> rule = new ActivityTestRule<>(EspressoTestActivity.class);
 
-    private OnMapReadyIdlingResource idlingResource;
-
-    @Before
-    public void registerIdlingResource() {
-        idlingResource = new OnMapReadyIdlingResource(rule.getActivity());
-        Espresso.registerIdlingResources(idlingResource);
+  @Rule
+  public final ActivityTestRule<EspressoTestActivity> rule = new ActivityTestRule<>(EspressoTestActivity.class);
+
+  private OnMapReadyIdlingResource idlingResource;
+
+  @Before
+  public void registerIdlingResource() {
+    idlingResource = new OnMapReadyIdlingResource(rule.getActivity());
+    Espresso.registerIdlingResources(idlingResource);
+  }
+
+  @Test
+  public void testMoveToCameraPositionTarget() {
+    ViewUtils.checkViewIsDisplayed(R.id.mapView);
+    final MapboxMap mapboxMap = rule.getActivity().getMapboxMap();
+
+    /*TODO remove zoom #6474*/
+    float zoom = 1.0f;
+    LatLng moveTarget = new LatLng(1, 1);
+
+    CameraPosition initialPosition = new CameraPosition.Builder().target(
+      new LatLng()).zoom(zoom).bearing(0).tilt(0).build();
+    CameraPosition cameraPosition = mapboxMap.getCameraPosition();
+    assertEquals("Default camera position should match default", cameraPosition, initialPosition);
+
+    onView(withId(R.id.mapView)).perform(new MoveCameraAction(mapboxMap, CameraUpdateFactory.newLatLng(moveTarget)));
+    cameraPosition = mapboxMap.getCameraPosition();
+    assertEquals("Moved camera position latitude should match", cameraPosition.target.getLatitude(),
+      moveTarget.getLatitude(), TestConstants.LAT_LNG_DELTA);
+    assertEquals("Moved camera position longitude should match", cameraPosition.target.getLongitude(),
+      moveTarget.getLongitude(), TestConstants.LAT_LNG_DELTA);
+  }
+
+  @Test
+  public void testMoveToCameraPositionTargetZoom() {
+    ViewUtils.checkViewIsDisplayed(R.id.mapView);
+    final MapboxMap mapboxMap = rule.getActivity().getMapboxMap();
+
+    final float moveZoom = 15.5f;
+    final LatLng moveTarget = new LatLng(1.0000000001, 1.0000000003);
+
+    onView(withId(R.id.mapView)).perform(new MoveCameraAction(mapboxMap,
+      CameraUpdateFactory.newLatLngZoom(moveTarget, moveZoom)));
+    CameraPosition cameraPosition = mapboxMap.getCameraPosition();
+    assertEquals("Moved camera position latitude should match", cameraPosition.target.getLatitude(),
+      moveTarget.getLatitude(), TestConstants.LAT_LNG_DELTA);
+    assertEquals("Moved camera position longitude should match", cameraPosition.target.getLongitude(),
+      moveTarget.getLongitude(), TestConstants.LAT_LNG_DELTA);
+    assertEquals("Moved zoom should match", cameraPosition.zoom, moveZoom, TestConstants.ZOOM_DELTA);
+  }
+
+  @Test
+  public void testMoveToCameraPosition() {
+    ViewUtils.checkViewIsDisplayed(R.id.mapView);
+    final MapboxMap mapboxMap = rule.getActivity().getMapboxMap();
+
+    final LatLng moveTarget = new LatLng(1.0000000001, 1.0000000003);
+    final float moveZoom = 15.5f;
+    final float moveTilt = 45.5f;
+    final float moveBearing = 12.5f;
+
+    onView(withId(R.id.mapView)).perform(
+      new MoveCameraAction(mapboxMap, CameraUpdateFactory.newCameraPosition(
+        new CameraPosition.Builder()
+          .target(moveTarget)
+          .zoom(moveZoom)
+          .tilt(moveTilt)
+          .bearing(moveBearing)
+          .build()))
+    );
+
+    CameraPosition cameraPosition = mapboxMap.getCameraPosition();
+    assertEquals("Moved camera position latitude should match", cameraPosition.target.getLatitude(),
+      moveTarget.getLatitude(), TestConstants.LAT_LNG_DELTA);
+    assertEquals("Moved camera position longitude should match", cameraPosition.target.getLongitude(),
+      moveTarget.getLongitude(), TestConstants.LAT_LNG_DELTA);
+    assertEquals("Moved zoom should match", cameraPosition.zoom, moveZoom, TestConstants.ZOOM_DELTA);
+    assertEquals("Moved zoom should match", cameraPosition.tilt, moveTilt, TestConstants.TILT_DELTA);
+    assertEquals("Moved bearing should match", cameraPosition.bearing, moveBearing, TestConstants.BEARING_DELTA);
+  }
+
+  @Test
+  public void testMoveToBounds() {
+    ViewUtils.checkViewIsDisplayed(R.id.mapView);
+    final MapboxMap mapboxMap = rule.getActivity().getMapboxMap();
+
+    final LatLng centerBounds = new LatLng(1, 1);
+    LatLng cornerOne = new LatLng();
+    LatLng cornerTwo = new LatLng(2, 2);
+
+    final LatLngBounds.Builder builder = new LatLngBounds.Builder();
+    builder.include(cornerOne);
+    builder.include(cornerTwo);
+
+    onView(withId(R.id.mapView)).perform(new MoveCameraAction(mapboxMap,
+      CameraUpdateFactory.newLatLngBounds(builder.build(), 0)));
+
+    CameraPosition cameraPosition = mapboxMap.getCameraPosition();
+    assertEquals("Moved camera position latitude should match center bounds",
+      cameraPosition.target.getLatitude(),
+      centerBounds.getLatitude(),
+      TestConstants.LAT_LNG_DELTA);
+
+    assertEquals("Moved camera position longitude should match center bounds",
+      cameraPosition.target.getLongitude(),
+      centerBounds.getLongitude(),
+      TestConstants.LAT_LNG_DELTA);
+  }
+
+  @Test
+  public void testMoveToMoveBy() {
+    ViewUtils.checkViewIsDisplayed(R.id.mapView);
+    final MapboxMap mapboxMap = rule.getActivity().getMapboxMap();
+
+    final PointF centerPoint = mapboxMap.getProjection().toScreenLocation(mapboxMap.getCameraPosition().target);
+    final LatLng moveTarget = new LatLng(2, 2);
+    final PointF moveTargetPoint = mapboxMap.getProjection().toScreenLocation(moveTarget);
+
+    onView(withId(R.id.mapView)).perform(new MoveCameraAction(mapboxMap, CameraUpdateFactory.scrollBy(
+      moveTargetPoint.x - centerPoint.x, moveTargetPoint.y - centerPoint.y)));
+
+    CameraPosition cameraPosition = mapboxMap.getCameraPosition();
+    assertEquals("Moved camera position latitude should match", cameraPosition.target.getLatitude(),
+      moveTarget.getLatitude(), TestConstants.LAT_LNG_DELTA_LARGE);
+    assertEquals("Moved camera position longitude should match", cameraPosition.target.getLongitude(),
+      moveTarget.getLongitude(), TestConstants.LAT_LNG_DELTA_LARGE);
+  }
+
+  @Test
+  public void testMoveToZoomIn() {
+    ViewUtils.checkViewIsDisplayed(R.id.mapView);
+    final MapboxMap mapboxMap = rule.getActivity().getMapboxMap();
+
+    /*TODO fix zoom #6474*/
+    float zoom = 1.0f;
+
+    onView(withId(R.id.mapView)).perform(new MoveCameraAction(mapboxMap, CameraUpdateFactory.zoomIn()));
+    CameraPosition cameraPosition = mapboxMap.getCameraPosition();
+    assertEquals("Moved camera zoom should match moved camera zoom", cameraPosition.zoom, zoom + 1,
+      TestConstants.ZOOM_DELTA);
+  }
+
+  @Test
+  public void testMoveToZoomOut() {
+    ViewUtils.checkViewIsDisplayed(R.id.mapView);
+    final MapboxMap mapboxMap = rule.getActivity().getMapboxMap();
+
+    /*TODO fix zoom #6474*/
+    float zoom = 10.0f;
+    onView(withId(R.id.mapView)).perform(new MoveCameraAction(mapboxMap,
+      CameraUpdateFactory.newLatLngZoom(new LatLng(), zoom)));
+    onView(withId(R.id.mapView)).perform(new MoveCameraAction(mapboxMap, CameraUpdateFactory.zoomOut()));
+    CameraPosition cameraPosition = mapboxMap.getCameraPosition();
+    assertEquals("Moved camera zoom should match moved camera zoom", cameraPosition.zoom, zoom - 1,
+      TestConstants.ZOOM_DELTA);
+  }
+
+  @Test
+  public void testMoveToZoomBy() {
+    ViewUtils.checkViewIsDisplayed(R.id.mapView);
+    final MapboxMap mapboxMap = rule.getActivity().getMapboxMap();
+
+    /*TODO fix zoom #6474*/
+    float zoom = 1.0f;
+    final float zoomBy = 2.45f;
+
+    onView(withId(R.id.mapView)).perform(new MoveCameraAction(mapboxMap, CameraUpdateFactory.zoomBy(zoomBy)));
+    CameraPosition cameraPosition = mapboxMap.getCameraPosition();
+    assertEquals("Moved camera zoom should match moved camera zoom", cameraPosition.zoom, zoom + zoomBy,
+      TestConstants.ZOOM_DELTA);
+  }
+
+  @Test
+  public void testMoveToZoomTo() {
+    ViewUtils.checkViewIsDisplayed(R.id.mapView);
+    final MapboxMap mapboxMap = rule.getActivity().getMapboxMap();
+
+    /*TODO fix zoom #6474*/
+    final float zoomTo = 2.45f;
+
+    onView(withId(R.id.mapView)).perform(new MoveCameraAction(mapboxMap, CameraUpdateFactory.zoomTo(zoomTo)));
+    CameraPosition cameraPosition = mapboxMap.getCameraPosition();
+    assertEquals("Moved camera zoom should match moved camera zoom", cameraPosition.zoom, zoomTo,
+      TestConstants.ZOOM_DELTA);
+  }
+
+  @After
+  public void unregisterIdlingResource() {
+    Espresso.unregisterIdlingResources(idlingResource);
+  }
+
+  private class MoveCameraAction implements ViewAction {
+
+    private MapboxMap mapboxMap;
+    private CameraUpdate cameraUpdate;
+
+    MoveCameraAction(MapboxMap map, CameraUpdate update) {
+      mapboxMap = map;
+      cameraUpdate = update;
     }
 
-    @Test
-    public void testMoveToCameraPositionTarget() {
-        ViewUtils.checkViewIsDisplayed(R.id.mapView);
-        final MapboxMap mapboxMap = rule.getActivity().getMapboxMap();
-
-        /*TODO remove zoom #6474*/
-        float zoom = 1.0f;
-        LatLng moveTarget = new LatLng(1, 1);
-
-        CameraPosition initialPosition = new CameraPosition.Builder().target(new LatLng()).zoom(zoom).bearing(0).tilt(0).build();
-        CameraPosition cameraPosition = mapboxMap.getCameraPosition();
-        assertEquals("Default camera position should match default", cameraPosition, initialPosition);
-
-        onView(withId(R.id.mapView)).perform(new MoveCameraAction(mapboxMap, CameraUpdateFactory.newLatLng(moveTarget)));
-        cameraPosition = mapboxMap.getCameraPosition();
-        assertEquals("Moved camera position latitude should match", cameraPosition.target.getLatitude(), moveTarget.getLatitude(), TestConstants.LAT_LNG_DELTA);
-        assertEquals("Moved camera position longitude should match", cameraPosition.target.getLongitude(), moveTarget.getLongitude(), TestConstants.LAT_LNG_DELTA);
+    @Override
+    public Matcher<View> getConstraints() {
+      return isDisplayed();
     }
 
-    @Test
-    public void testMoveToCameraPositionTargetZoom() {
-        ViewUtils.checkViewIsDisplayed(R.id.mapView);
-        final MapboxMap mapboxMap = rule.getActivity().getMapboxMap();
-
-        final float moveZoom = 15.5f;
-        final LatLng moveTarget = new LatLng(1.0000000001, 1.0000000003);
-
-        onView(withId(R.id.mapView)).perform(new MoveCameraAction(mapboxMap, CameraUpdateFactory.newLatLngZoom(moveTarget, moveZoom)));
-        CameraPosition cameraPosition = mapboxMap.getCameraPosition();
-        assertEquals("Moved camera position latitude should match", cameraPosition.target.getLatitude(), moveTarget.getLatitude(), TestConstants.LAT_LNG_DELTA);
-        assertEquals("Moved camera position longitude should match", cameraPosition.target.getLongitude(), moveTarget.getLongitude(), TestConstants.LAT_LNG_DELTA);
-        assertEquals("Moved zoom should match", cameraPosition.zoom, moveZoom, TestConstants.ZOOM_DELTA);
+    @Override
+    public String getDescription() {
+      return getClass().getSimpleName();
     }
 
-    @Test
-    public void testMoveToCameraPosition() {
-        ViewUtils.checkViewIsDisplayed(R.id.mapView);
-        final MapboxMap mapboxMap = rule.getActivity().getMapboxMap();
-
-        final LatLng moveTarget = new LatLng(1.0000000001, 1.0000000003);
-        final float moveZoom = 15.5f;
-        final float moveTilt = 45.5f;
-        final float moveBearing = 12.5f;
-
-        onView(withId(R.id.mapView)).perform(
-                new MoveCameraAction(mapboxMap, CameraUpdateFactory.newCameraPosition(
-                        new CameraPosition.Builder()
-                                .target(moveTarget)
-                                .zoom(moveZoom)
-                                .tilt(moveTilt)
-                                .bearing(moveBearing)
-                                .build()))
-        );
-
-        CameraPosition cameraPosition = mapboxMap.getCameraPosition();
-        assertEquals("Moved camera position latitude should match", cameraPosition.target.getLatitude(), moveTarget.getLatitude(), TestConstants.LAT_LNG_DELTA);
-        assertEquals("Moved camera position longitude should match", cameraPosition.target.getLongitude(), moveTarget.getLongitude(), TestConstants.LAT_LNG_DELTA);
-        assertEquals("Moved zoom should match", cameraPosition.zoom, moveZoom, TestConstants.ZOOM_DELTA);
-        assertEquals("Moved zoom should match", cameraPosition.tilt, moveTilt, TestConstants.TILT_DELTA);
-        assertEquals("Moved bearing should match", cameraPosition.bearing, moveBearing, TestConstants.BEARING_DELTA);
-    }
-
-    @Test
-    public void testMoveToBounds() {
-        ViewUtils.checkViewIsDisplayed(R.id.mapView);
-        final MapboxMap mapboxMap = rule.getActivity().getMapboxMap();
-
-        final LatLng centerBounds = new LatLng(1, 1);
-        LatLng cornerOne = new LatLng();
-        LatLng cornerTwo = new LatLng(2, 2);
-
-        final LatLngBounds.Builder builder = new LatLngBounds.Builder();
-        builder.include(cornerOne);
-        builder.include(cornerTwo);
-
-        onView(withId(R.id.mapView)).perform(new MoveCameraAction(mapboxMap, CameraUpdateFactory.newLatLngBounds(builder.build(), 0)));
-
-        CameraPosition cameraPosition = mapboxMap.getCameraPosition();
-        assertEquals("Moved camera position latitude should match center bounds",
-                cameraPosition.target.getLatitude(),
-                centerBounds.getLatitude(),
-                TestConstants.LAT_LNG_DELTA);
-
-        assertEquals("Moved camera position longitude should match center bounds",
-                cameraPosition.target.getLongitude(),
-                centerBounds.getLongitude(),
-                TestConstants.LAT_LNG_DELTA);
-    }
-
-    @Test
-    public void testMoveToMoveBy() {
-        ViewUtils.checkViewIsDisplayed(R.id.mapView);
-        final MapboxMap mapboxMap = rule.getActivity().getMapboxMap();
-
-        final PointF centerPoint = mapboxMap.getProjection().toScreenLocation(mapboxMap.getCameraPosition().target);
-        final LatLng moveTarget = new LatLng(2, 2);
-        final PointF moveTargetPoint = mapboxMap.getProjection().toScreenLocation(moveTarget);
-
-        onView(withId(R.id.mapView)).perform(new MoveCameraAction(mapboxMap, CameraUpdateFactory.scrollBy(
-                moveTargetPoint.x - centerPoint.x, moveTargetPoint.y - centerPoint.y)));
-
-        CameraPosition cameraPosition = mapboxMap.getCameraPosition();
-        assertEquals("Moved camera position latitude should match", cameraPosition.target.getLatitude(), moveTarget.getLatitude(), TestConstants.LAT_LNG_DELTA_LARGE);
-        assertEquals("Moved camera position longitude should match", cameraPosition.target.getLongitude(), moveTarget.getLongitude(), TestConstants.LAT_LNG_DELTA_LARGE);
-    }
-
-    @Test
-    public void testMoveToZoomIn() {
-        ViewUtils.checkViewIsDisplayed(R.id.mapView);
-        final MapboxMap mapboxMap = rule.getActivity().getMapboxMap();
-
-        /*TODO fix zoom #6474*/
-        float zoom = 1.0f;
-
-        onView(withId(R.id.mapView)).perform(new MoveCameraAction(mapboxMap, CameraUpdateFactory.zoomIn()));
-        CameraPosition cameraPosition = mapboxMap.getCameraPosition();
-        assertEquals("Moved camera zoom should match moved camera zoom", cameraPosition.zoom, zoom + 1, TestConstants.ZOOM_DELTA);
-    }
-
-    @Test
-    public void testMoveToZoomOut() {
-        ViewUtils.checkViewIsDisplayed(R.id.mapView);
-        final MapboxMap mapboxMap = rule.getActivity().getMapboxMap();
-
-        /*TODO fix zoom #6474*/
-        float zoom = 10.0f;
-        onView(withId(R.id.mapView)).perform(new MoveCameraAction(mapboxMap, CameraUpdateFactory.newLatLngZoom(new LatLng(), zoom)));
-        onView(withId(R.id.mapView)).perform(new MoveCameraAction(mapboxMap, CameraUpdateFactory.zoomOut()));
-        CameraPosition cameraPosition = mapboxMap.getCameraPosition();
-        assertEquals("Moved camera zoom should match moved camera zoom", cameraPosition.zoom, zoom - 1, TestConstants.ZOOM_DELTA);
-    }
-
-    @Test
-    public void testMoveToZoomBy() {
-        ViewUtils.checkViewIsDisplayed(R.id.mapView);
-        final MapboxMap mapboxMap = rule.getActivity().getMapboxMap();
-
-        /*TODO fix zoom #6474*/
-        float zoom = 1.0f;
-        final float zoomBy = 2.45f;
-
-        onView(withId(R.id.mapView)).perform(new MoveCameraAction(mapboxMap, CameraUpdateFactory.zoomBy(zoomBy)));
-        CameraPosition cameraPosition = mapboxMap.getCameraPosition();
-        assertEquals("Moved camera zoom should match moved camera zoom", cameraPosition.zoom, zoom + zoomBy, TestConstants.ZOOM_DELTA);
-    }
-
-    @Test
-    public void testMoveToZoomTo() {
-        ViewUtils.checkViewIsDisplayed(R.id.mapView);
-        final MapboxMap mapboxMap = rule.getActivity().getMapboxMap();
-
-        /*TODO fix zoom #6474*/
-        final float zoomTo = 2.45f;
-
-        onView(withId(R.id.mapView)).perform(new MoveCameraAction(mapboxMap, CameraUpdateFactory.zoomTo(zoomTo)));
-        CameraPosition cameraPosition = mapboxMap.getCameraPosition();
-        assertEquals("Moved camera zoom should match moved camera zoom", cameraPosition.zoom, zoomTo, TestConstants.ZOOM_DELTA);
-    }
-
-    @After
-    public void unregisterIdlingResource() {
-        Espresso.unregisterIdlingResources(idlingResource);
-    }
-
-    private class MoveCameraAction implements ViewAction {
-
-        private MapboxMap mapboxMap;
-        private CameraUpdate cameraUpdate;
-
-        MoveCameraAction(MapboxMap map, CameraUpdate update) {
-            mapboxMap = map;
-            cameraUpdate = update;
-        }
-
-        @Override
-        public Matcher<View> getConstraints() {
-            return isDisplayed();
-        }
-
-        @Override
-        public String getDescription() {
-            return getClass().getSimpleName();
-        }
-
-        @Override
-        public void perform(UiController uiController, View view) {
-            mapboxMap.moveCamera(cameraUpdate);
-            uiController.loopMainThreadForAtLeast(100);
-        }
+    @Override
+    public void perform(UiController uiController, View view) {
+      mapboxMap.moveCamera(cameraUpdate);
+      uiController.loopMainThreadForAtLeast(100);
     }
+  }
 }