Adds checkstyle to CI (#7442)

* adds checkstyle to CI

* fixed gradlew path

* resolved testapp checkstyle violations

* added back mapboxMap variable for test

* checkstyle annotations

* checkstyle SDK round 1

* maps package checkstyle

* rest of SDK checkstyle

* checkstyle gesture library

* checkstyle test

* finished rest of test checkstyle

* resolved all checkstyle errors

* fixed class name

* removed old test file

* fixed camera postion test

* fixed native crash

3 files changed, 229 insertions, 220 deletions

diff --git a/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/utils/AnimatorUtils.java b/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/utils/AnimatorUtils.java
index ab3b841043..7694604d9f 100644
--- a/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/utils/AnimatorUtils.java
+++ b/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/utils/AnimatorUtils.java
@@ -12,94 +12,98 @@ import android.view.View;
 
 public class AnimatorUtils {
 
-    public static void animate(@NonNull final View view, @AnimatorRes int animatorRes, @Nullable OnAnimationEndListener listener) {
-        animate(view, animatorRes, -1, listener);
+  public static void animate(@NonNull final View view, @AnimatorRes int animatorRes,
+                             @Nullable OnAnimationEndListener listener) {
+    animate(view, animatorRes, -1, listener);
+  }
+
+  public static void animate(final View view, @AnimatorRes int animatorRes, int duration,
+                             @Nullable final OnAnimationEndListener listener) {
+    if (view == null) {
+      return;
     }
 
-    public static void animate(final View view, @AnimatorRes int animatorRes, int duration, @Nullable final OnAnimationEndListener listener) {
-        if (view == null) {
-            return;
-        }
+    view.setLayerType(View.LAYER_TYPE_HARDWARE, null);
+    Animator animator = AnimatorInflater.loadAnimator(view.getContext(), animatorRes);
+    if (duration != -1) {
+      animator.setDuration(duration);
+    }
 
-        view.setLayerType(View.LAYER_TYPE_HARDWARE, null);
-        Animator animator = AnimatorInflater.loadAnimator(view.getContext(), animatorRes);
-        if (duration != -1) {
-            animator.setDuration(duration);
+    animator.addListener(new AnimatorListenerAdapter() {
+      @Override
+      public void onAnimationEnd(Animator animation) {
+        super.onAnimationEnd(animation);
+        view.setLayerType(View.LAYER_TYPE_NONE, null);
+        if (listener != null) {
+          listener.onAnimationEnd();
         }
+      }
+    });
+    animator.setTarget(view);
+    animator.start();
+  }
 
-        animator.addListener(new AnimatorListenerAdapter() {
-            @Override
-            public void onAnimationEnd(Animator animation) {
-                super.onAnimationEnd(animation);
-                view.setLayerType(View.LAYER_TYPE_NONE, null);
-                if (listener != null) {
-                    listener.onAnimationEnd();
-                }
-            }
-        });
-        animator.setTarget(view);
-        animator.start();
-    }
+  public static void animate(@NonNull final View view, @AnimatorRes int animatorRes) {
+    animate(view, animatorRes, -1);
+  }
 
-    public static void animate(@NonNull final View view, @AnimatorRes int animatorRes) {
-        animate(view, animatorRes, -1);
-    }
-
-    public static void animate(@NonNull final View view, @AnimatorRes int animatorRes, int duration) {
-        animate(view, animatorRes, duration, null);
-    }
+  public static void animate(@NonNull final View view, @AnimatorRes int animatorRes, int duration) {
+    animate(view, animatorRes, duration, null);
+  }
 
-    public static void rotate(@NonNull final View view, float rotation) {
-        view.setLayerType(View.LAYER_TYPE_HARDWARE, null);
-        ObjectAnimator rotateAnimator = ObjectAnimator.ofFloat(view, View.ROTATION, view.getRotation(), rotation);
-        rotateAnimator.addListener(new AnimatorListenerAdapter() {
-            @Override
-            public void onAnimationEnd(Animator animation) {
-                super.onAnimationEnd(animation);
-                view.setLayerType(View.LAYER_TYPE_NONE, null);
-            }
-        });
-        rotateAnimator.start();
-    }
+  public static void rotate(@NonNull final View view, float rotation) {
+    view.setLayerType(View.LAYER_TYPE_HARDWARE, null);
+    ObjectAnimator rotateAnimator = ObjectAnimator.ofFloat(view, View.ROTATION, view.getRotation(), rotation);
+    rotateAnimator.addListener(new AnimatorListenerAdapter() {
+      @Override
+      public void onAnimationEnd(Animator animation) {
+        super.onAnimationEnd(animation);
+        view.setLayerType(View.LAYER_TYPE_NONE, null);
+      }
+    });
+    rotateAnimator.start();
+  }
 
-    public static void rotateBy(@NonNull final View view, float rotationBy) {
-        view.setLayerType(View.LAYER_TYPE_HARDWARE, null);
-        view.animate().rotationBy(rotationBy).setInterpolator(new FastOutSlowInInterpolator()).setListener(new AnimatorListenerAdapter() {
-            @Override
-            public void onAnimationEnd(Animator animation) {
-                super.onAnimationEnd(animation);
-                view.setLayerType(View.LAYER_TYPE_NONE, null);
-            }
-        });
-    }
+  public static void rotateBy(@NonNull final View view, float rotationBy) {
+    view.setLayerType(View.LAYER_TYPE_HARDWARE, null);
+    view.animate().rotationBy(rotationBy).setInterpolator(new FastOutSlowInInterpolator()).setListener(
+      new AnimatorListenerAdapter() {
+        @Override
+        public void onAnimationEnd(Animator animation) {
+          super.onAnimationEnd(animation);
+          view.setLayerType(View.LAYER_TYPE_NONE, null);
+        }
+      });
+  }
 
-    public static void alpha(@NonNull final View convertView, float alpha, @Nullable final OnAnimationEndListener listener) {
-        convertView.setLayerType(View.LAYER_TYPE_HARDWARE, null);
-        ObjectAnimator rotateAnimator = ObjectAnimator.ofFloat(convertView, View.ALPHA, convertView.getAlpha(), alpha);
-        rotateAnimator.addListener(new AnimatorListenerAdapter() {
-            @Override
-            public void onAnimationStart(Animator animation) {
-                super.onAnimationStart(animation);
-                convertView.setVisibility(View.VISIBLE);
-            }
+  public static void alpha(@NonNull final View convertView, float alpha,
+                           @Nullable final OnAnimationEndListener listener) {
+    convertView.setLayerType(View.LAYER_TYPE_HARDWARE, null);
+    ObjectAnimator rotateAnimator = ObjectAnimator.ofFloat(convertView, View.ALPHA, convertView.getAlpha(), alpha);
+    rotateAnimator.addListener(new AnimatorListenerAdapter() {
+      @Override
+      public void onAnimationStart(Animator animation) {
+        super.onAnimationStart(animation);
+        convertView.setVisibility(View.VISIBLE);
+      }
 
-            @Override
-            public void onAnimationEnd(Animator animation) {
-                super.onAnimationEnd(animation);
-                convertView.setLayerType(View.LAYER_TYPE_NONE, null);
-                if (listener != null) {
-                    listener.onAnimationEnd();
-                }
-            }
-        });
-        rotateAnimator.start();
-    }
+      @Override
+      public void onAnimationEnd(Animator animation) {
+        super.onAnimationEnd(animation);
+        convertView.setLayerType(View.LAYER_TYPE_NONE, null);
+        if (listener != null) {
+          listener.onAnimationEnd();
+        }
+      }
+    });
+    rotateAnimator.start();
+  }
 
-    public static void alpha(@NonNull final View convertView, float alpha) {
-        alpha(convertView, alpha, null);
-    }
+  public static void alpha(@NonNull final View convertView, float alpha) {
+    alpha(convertView, alpha, null);
+  }
 
-    public interface OnAnimationEndListener {
-        void onAnimationEnd();
-    }
+  public interface OnAnimationEndListener {
+    void onAnimationEnd();
+  }
 }
diff --git a/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/utils/ColorUtils.java b/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/utils/ColorUtils.java
index 190e0b9b8f..d45d647247 100644
--- a/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/utils/ColorUtils.java
+++ b/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/utils/ColorUtils.java
@@ -19,101 +19,104 @@ import java.util.regex.Pattern;
 
 public class ColorUtils {
 
-    /**
-     * Returns a color integer associated as primary color from a theme based on a {@link Context}.
-     *
-     * @param context The context used to style the color attributes.
-     * @return The primary color value of current theme in the form 0xAARRGGBB.
-     */
-    @ColorInt
-    public static int getPrimaryColor(@NonNull Context context) {
-        TypedValue typedValue = new TypedValue();
-        Resources.Theme theme = context.getTheme();
-        theme.resolveAttribute(R.attr.colorPrimary, typedValue, true);
-        return typedValue.data;
-    }
+  /**
+   * Returns a color integer associated as primary color from a theme based on a {@link Context}.
+   *
+   * @param context The context used to style the color attributes.
+   * @return The primary color value of current theme in the form 0xAARRGGBB.
+   */
+  @ColorInt
+  public static int getPrimaryColor(@NonNull Context context) {
+    TypedValue typedValue = new TypedValue();
+    Resources.Theme theme = context.getTheme();
+    theme.resolveAttribute(R.attr.colorPrimary, typedValue, true);
+    return typedValue.data;
+  }
 
-    /**
-     * Returns a color integer associated as primary dark color from a theme based on a {@link Context}.
-     *
-     * @param context The context used to style the color attributes.
-     * @return The primary dark color value of current theme in the form 0xAARRGGBB.
-     */
-    @ColorInt
-    public static int getPrimaryDarkColor(@NonNull Context context) {
-        TypedValue typedValue = new TypedValue();
-        Resources.Theme theme = context.getTheme();
-        theme.resolveAttribute(R.attr.colorPrimaryDark, typedValue, true);
-        return typedValue.data;
-    }
+  /**
+   * Returns a color integer associated as primary dark color from a theme based on a {@link Context}.
+   *
+   * @param context The context used to style the color attributes.
+   * @return The primary dark color value of current theme in the form 0xAARRGGBB.
+   */
+  @ColorInt
+  public static int getPrimaryDarkColor(@NonNull Context context) {
+    TypedValue typedValue = new TypedValue();
+    Resources.Theme theme = context.getTheme();
+    theme.resolveAttribute(R.attr.colorPrimaryDark, typedValue, true);
+    return typedValue.data;
+  }
 
-    /**
-     * Returns a color integer associated as accent color from a theme based on a {@link Context}.
-     *
-     * @param context The context used to style the color attributes.
-     * @return The accent color value of current theme in the form 0xAARRGGBB.
-     */
-    @ColorInt
-    public static int getAccentColor(@NonNull Context context) {
-        TypedValue typedValue = new TypedValue();
-        Resources.Theme theme = context.getTheme();
-        theme.resolveAttribute(R.attr.colorAccent, typedValue, true);
-        return typedValue.data;
-    }
+  /**
+   * Returns a color integer associated as accent color from a theme based on a {@link Context}.
+   *
+   * @param context The context used to style the color attributes.
+   * @return The accent color value of current theme in the form 0xAARRGGBB.
+   */
+  @ColorInt
+  public static int getAccentColor(@NonNull Context context) {
+    TypedValue typedValue = new TypedValue();
+    Resources.Theme theme = context.getTheme();
+    theme.resolveAttribute(R.attr.colorAccent, typedValue, true);
+    return typedValue.data;
+  }
 
-    /**
-     * Returns a color state list associated with a theme based on a {@link Context}
-     *
-     * @param color The color used for tinting.
-     * @return A ColorStateList object containing the primary color of a theme
-     */
-    @NonNull
-    public static ColorStateList getSelector(@ColorInt int color) {
-        return new ColorStateList(
-                new int[][]{
-                        new int[]{android.R.attr.state_pressed},
-                        new int[]{}
-                },
-                new int[]{
-                        color,
-                        color
-                }
-        );
-    }
+  /**
+   * Returns a color state list associated with a theme based on a {@link Context}
+   *
+   * @param color The color used for tinting.
+   * @return A ColorStateList object containing the primary color of a theme
+   */
+  @NonNull
+  public static ColorStateList getSelector(@ColorInt int color) {
+    return new ColorStateList(
+      new int[][] {
+        new int[] {android.R.attr.state_pressed},
+        new int[] {}
+      },
+      new int[] {
+        color,
+        color
+      }
+    );
+  }
 
-    /**
-     * Set a color tint list to the {@link Drawable} of an {@link ImageView}.
-     *
-     * @param imageView The view to set the default tint list.
-     * @param tintColor The color to tint.
-     */
-    public static void setTintList(@NonNull ImageView imageView, @ColorInt int tintColor) {
-        Drawable originalDrawable = imageView.getDrawable();
-        Drawable wrappedDrawable = DrawableCompat.wrap(originalDrawable);
-        DrawableCompat.setTintList(wrappedDrawable, getSelector(tintColor));
-    }
+  /**
+   * Set a color tint list to the {@link Drawable} of an {@link ImageView}.
+   *
+   * @param imageView The view to set the default tint list.
+   * @param tintColor The color to tint.
+   */
+  public static void setTintList(@NonNull ImageView imageView, @ColorInt int tintColor) {
+    Drawable originalDrawable = imageView.getDrawable();
+    Drawable wrappedDrawable = DrawableCompat.wrap(originalDrawable);
+    DrawableCompat.setTintList(wrappedDrawable, getSelector(tintColor));
+  }
 
-    static int normalizeColorComponent(String value) {
-        return (int) (Float.parseFloat(value) * 255);
-    }
+  static int normalizeColorComponent(String value) {
+    return (int) (Float.parseFloat(value) * 255);
+  }
 
-    /**
-     * Convert an rgba string to a Color int.
-     *
-     * @param value the String representation of rgba
-     * @return the int representation of rgba
-     * @throws ConversionException on illegal input
-     */
-    @ColorInt
-    public static int rgbaToColor(String value) {
-        Pattern c = Pattern.compile("rgba?\\s*\\(\\s*(\\d+\\.?\\d*)\\s*,\\s*(\\d+\\.?\\d*)\\s*,\\s*(\\d+\\.?\\d*)\\s*,?\\s*(\\d+\\.?\\d*)?\\s*\\)");
-        Matcher m = c.matcher(value);
-        if (m.matches() && m.groupCount() == 3) {
-            return Color.rgb(normalizeColorComponent(m.group(1)), normalizeColorComponent(m.group(2)), normalizeColorComponent(m.group(3)));
-        } else if (m.matches() && m.groupCount() == 4) {
-            return Color.argb(normalizeColorComponent(m.group(4)), normalizeColorComponent(m.group(1)), normalizeColorComponent(m.group(2)), normalizeColorComponent(m.group(3)));
-        } else {
-            throw new ConversionException("Not a valid rgb/rgba value");
-        }
+  /**
+   * Convert an rgba string to a Color int.
+   *
+   * @param value the String representation of rgba
+   * @return the int representation of rgba
+   * @throws ConversionException on illegal input
+   */
+  @ColorInt
+  public static int rgbaToColor(String value) {
+    Pattern c = Pattern.compile("rgba?\\s*\\(\\s*(\\d+\\.?\\d*)\\s*,\\s*(\\d+\\.?\\d*)\\s*,\\s*(\\d+\\.?\\d*)\\s*,"
+      + "?\\s*(\\d+\\.?\\d*)?\\s*\\)");
+    Matcher m = c.matcher(value);
+    if (m.matches() && m.groupCount() == 3) {
+      return Color.rgb(normalizeColorComponent(m.group(1)), normalizeColorComponent(m.group(2)),
+        normalizeColorComponent(m.group(3)));
+    } else if (m.matches() && m.groupCount() == 4) {
+      return Color.argb(normalizeColorComponent(m.group(4)), normalizeColorComponent(m.group(1)),
+        normalizeColorComponent(m.group(2)), normalizeColorComponent(m.group(3)));
+    } else {
+      throw new ConversionException("Not a valid rgb/rgba value");
     }
+  }
 }
\ No newline at end of file
diff --git a/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/utils/MathUtils.java b/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/utils/MathUtils.java
index 2c1a1b8e64..30ec214798 100644
--- a/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/utils/MathUtils.java
+++ b/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/utils/MathUtils.java
@@ -2,63 +2,65 @@ package com.mapbox.mapboxsdk.utils;
 
 public class MathUtils {
 
-    /**
-     * Test a value in specified range, returning minimum if it's below, and maximum if it's above
-     * @param value Value to test
-     * @param min Minimum value of range
-     * @param max Maximum value of range
-     * @return value if it's between min and max, min if it's below, max if it's above
-     */
-    public static double clamp(double value, double min, double max) {
-        return Math.max(min, Math.min(max, value));
-    }
+  /**
+   * Test a value in specified range, returning minimum if it's below, and maximum if it's above
+   *
+   * @param value Value to test
+   * @param min   Minimum value of range
+   * @param max   Maximum value of range
+   * @return value if it's between min and max, min if it's below, max if it's above
+   */
+  public static double clamp(double value, double min, double max) {
+    return Math.max(min, Math.min(max, value));
+  }
 
-    /**
-     * Test a value in specified range, returning minimum if it's below, and maximum if it's above
-     * @param value Value to test
-     * @param min Minimum value of range
-     * @param max Maximum value of range
-     * @return value if it's between min and max, min if it's below, max if it's above
-     */
-    public static float clamp(float value, float min, float max) {
-        return Math.max(min, Math.min(max, value));
-    }
+  /**
+   * Test a value in specified range, returning minimum if it's below, and maximum if it's above
+   *
+   * @param value Value to test
+   * @param min   Minimum value of range
+   * @param max   Maximum value of range
+   * @return value if it's between min and max, min if it's below, max if it's above
+   */
+  public static float clamp(float value, float min, float max) {
+    return Math.max(min, Math.min(max, value));
+  }
 
-    /**
-     * Constrains value to the given range (including min, excluding max) via modular arithmetic.
-     *
-     * Same formula as used in Core GL (wrap.hpp)
-     * std::fmod((std::fmod((value - min), d) + d), d) + min;
-     *
-     * @param value Value to wrap
-     * @param min Minimum value
-     * @param max Maximum value
-     * @return Wrapped value
-     */
-    public static double wrap(double value, double min, double max) {
-        double delta = max - min;
+  /**
+   * Constrains value to the given range (including min, excluding max) via modular arithmetic.
+   * <p>
+   * Same formula as used in Core GL (wrap.hpp)
+   * std::fmod((std::fmod((value - min), d) + d), d) + min;
+   *
+   * @param value Value to wrap
+   * @param min   Minimum value
+   * @param max   Maximum value
+   * @return Wrapped value
+   */
+  public static double wrap(double value, double min, double max) {
+    double delta = max - min;
 
-        double firstMod = (value - min) % delta;
-        double secondMod = (firstMod + delta) % delta;
+    double firstMod = (value - min) % delta;
+    double secondMod = (firstMod + delta) % delta;
 
-        return secondMod + min;
-    }
+    return secondMod + min;
+  }
 
-    /**
-     * Convert bearing from core to match Android SDK value.
-     *
-     * @param nativeBearing bearing value coming from core
-     * @return bearing in degrees starting from 0 rotating clockwise
-     */
-    public static double convertNativeBearing(double nativeBearing) {
-        double direction = -nativeBearing;
+  /**
+   * Convert bearing from core to match Android SDK value.
+   *
+   * @param nativeBearing bearing value coming from core
+   * @return bearing in degrees starting from 0 rotating clockwise
+   */
+  public static double convertNativeBearing(double nativeBearing) {
+    double direction = -nativeBearing;
 
-        while (direction > 360) {
-            direction -= 360;
-        }
-        while (direction < 0) {
-            direction += 360;
-        }
-        return direction;
+    while (direction > 360) {
+      direction -= 360;
+    }
+    while (direction < 0) {
+      direction += 360;
     }
+    return direction;
+  }
 }