diff options
| author | Anand Thakker <anandthakker@users.noreply.github.com> | 2018-06-06 11:26:08 -0400 |
|---|---|---|
| committer | Fabian Guerra Soto <fabian.guerra@mapbox.com> | 2018-06-08 13:01:03 -0400 |
| commit | 6c6257cf70f53ba082918da7ffa1c95ebcde87c1 (patch) | |
| tree | 49a4a6baa5618aa8bdc162613b25c8dd9c7779b6 /platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/NativeMapView.java | |
| parent | 8118cb55037a99c22fdf86a3e7dba0398cba38eb (diff) | |
| download | qtlocation-mapboxgl-6c6257cf70f53ba082918da7ffa1c95ebcde87c1.tar.gz | |
[core] Fix crash due to mixing legacy filters and expressions (#12065)
* Fix crash due to mixing legacy filters and expressions
In some cases, (invalid) nested filters that used a mix of legacy filter
syntax and expression syntax caused a crash due to a failure to
propagate parsing errors from deeper within the filter expression.
These errors went undetected in part because these conversion functions
returned unique_ptr<Expression> values (or vectors thereof), using
{nullptr} to represent a parsing error, but the core expression classes
expect unique_ptr<Expression> that are never null.
This changes over to using expression::ParseResult (aka
optional<unique_ptr<Expression>>), to represent conversion failure
the same way we do in the rest of the expression system.
* Fix clang 3.8 / gcc 4.9 issue
Diffstat (limited to 'platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/NativeMapView.java')
0 files changed, 0 insertions, 0 deletions