Adds checkstyle to CI (#7442)

* adds checkstyle to CI

* fixed gradlew path

* resolved testapp checkstyle violations

* added back mapboxMap variable for test

* checkstyle annotations

* checkstyle SDK round 1

* maps package checkstyle

* rest of SDK checkstyle

* checkstyle gesture library

* checkstyle test

* finished rest of test checkstyle

* resolved all checkstyle errors

* fixed class name

* removed old test file

* fixed camera postion test

* fixed native crash

1 files changed, 184 insertions, 183 deletions

diff --git a/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapFragment.java b/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapFragment.java
index 4524a59f0d..18b4c294e5 100644
--- a/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapFragment.java
+++ b/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapFragment.java
@@ -35,196 +35,197 @@ import com.mapbox.mapboxsdk.exceptions.InvalidAccessTokenException;
  */
 public final class MapFragment extends Fragment {
 
-    private MapView map;
-    private OnMapReadyCallback onMapReadyCallback;
-
-    /**
-     * Creates a MapFragment instance
-     *
-     * @param mapboxMapOptions The configuration options to be used.
-     * @return MapFragment created.
-     */
-    public static MapFragment newInstance(@Nullable MapboxMapOptions mapboxMapOptions) {
-        MapFragment mapFragment = new MapFragment();
-        Bundle bundle = new Bundle();
-        bundle.putParcelable(MapboxConstants.FRAG_ARG_MAPBOXMAPOPTIONS, mapboxMapOptions);
-        mapFragment.setArguments(bundle);
-        return mapFragment;
+  private MapView map;
+  private OnMapReadyCallback onMapReadyCallback;
+
+  /**
+   * Creates a MapFragment instance
+   *
+   * @param mapboxMapOptions The configuration options to be used.
+   * @return MapFragment created.
+   */
+  public static MapFragment newInstance(@Nullable MapboxMapOptions mapboxMapOptions) {
+    MapFragment mapFragment = new MapFragment();
+    Bundle bundle = new Bundle();
+    bundle.putParcelable(MapboxConstants.FRAG_ARG_MAPBOXMAPOPTIONS, mapboxMapOptions);
+    mapFragment.setArguments(bundle);
+    return mapFragment;
+  }
+
+  /**
+   * Creates the fragment view hierarchy.
+   *
+   * @param inflater           Inflater used to inflate content.
+   * @param container          The parent layout for the map fragment.
+   * @param savedInstanceState The saved instance state for the map fragment.
+   * @return The view created
+   */
+  @Override
+  public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
+    super.onCreateView(inflater, container, savedInstanceState);
+    Context context = inflater.getContext();
+    MapboxMapOptions options = null;
+
+    // Get bundle
+    Bundle bundle = getArguments();
+    if (bundle != null && bundle.containsKey(MapboxConstants.FRAG_ARG_MAPBOXMAPOPTIONS)) {
+      options = bundle.getParcelable(MapboxConstants.FRAG_ARG_MAPBOXMAPOPTIONS);
     }
 
-    /**
-     * Creates the fragment view hierarchy.
-     *
-     * @param inflater           Inflater used to inflate content.
-     * @param container          The parent layout for the map fragment.
-     * @param savedInstanceState The saved instance state for the map fragment.
-     * @return The view created
-     */
-    @Override
-    public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
-        super.onCreateView(inflater, container, savedInstanceState);
-        Context context = inflater.getContext();
-        MapboxMapOptions options = null;
-
-        // Get bundle
-        Bundle bundle = getArguments();
-        if (bundle != null && bundle.containsKey(MapboxConstants.FRAG_ARG_MAPBOXMAPOPTIONS)) {
-            options = bundle.getParcelable(MapboxConstants.FRAG_ARG_MAPBOXMAPOPTIONS);
-        }
-
-        // Assign an AccessToken if needed
-        if (options == null || options.getAccessToken() == null) {
-            String token = null;
-            if (MapboxAccountManager.getInstance() != null) {
-                token = MapboxAccountManager.getInstance().getAccessToken();
-            } else {
-                token = getToken(inflater.getContext());
-            }
-            if (TextUtils.isEmpty(token)) {
-                throw new InvalidAccessTokenException();
-            }
-            if (options == null) {
-                options = new MapboxMapOptions().accessToken(token);
-            } else {
-                options.accessToken(token);
-            }
-        }
-
-        Drawable foregroundDrawable = options.getMyLocationForegroundDrawable();
-        Drawable foregroundBearingDrawable = options.getMyLocationForegroundBearingDrawable();
-        if (foregroundDrawable == null || foregroundBearingDrawable == null) {
-            if (foregroundDrawable == null) {
-                foregroundDrawable = ContextCompat.getDrawable(context, R.drawable.mapbox_mylocation_icon_default);
-            }
-            if (foregroundBearingDrawable == null) {
-                foregroundBearingDrawable = ContextCompat.getDrawable(context, R.drawable.mapbox_mylocation_icon_bearing);
-            }
-            options.myLocationForegroundDrawables(foregroundDrawable, foregroundBearingDrawable);
-        }
-
-        if (options.getMyLocationBackgroundDrawable() == null) {
-            options.myLocationBackgroundDrawable(ContextCompat.getDrawable(context, R.drawable.mapbox_mylocation_bg_shape));
-        }
-
-        return map = new MapView(inflater.getContext(), options);
+    // Assign an AccessToken if needed
+    if (options == null || options.getAccessToken() == null) {
+      String token = null;
+      if (MapboxAccountManager.getInstance() != null) {
+        token = MapboxAccountManager.getInstance().getAccessToken();
+      } else {
+        token = getToken(inflater.getContext());
+      }
+      if (TextUtils.isEmpty(token)) {
+        throw new InvalidAccessTokenException();
+      }
+      if (options == null) {
+        options = new MapboxMapOptions().accessToken(token);
+      } else {
+        options.accessToken(token);
+      }
     }
 
-    /**
-     * <p>
-     * Returns the Mapbox access token set in the app resources.
-     * </p>
-     * It will first search the application manifest for a {@link MapboxConstants#KEY_META_DATA_MANIFEST}
-     * meta-data value. If not found it will then attempt to load the access token from the
-     * {@code res/raw/token.txt} development file.
-     *
-     * @param context The {@link Context} of the {@link android.app.Activity} or {@link android.app.Fragment}.
-     * @return The Mapbox access token or null if not found.
-     * @see MapboxConstants#KEY_META_DATA_MANIFEST
-     *
-     * @deprecated As of release 4.1.0, replaced by {@link com.mapbox.mapboxsdk.MapboxAccountManager#start(Context, String)}
-     */
-    @Deprecated
-    private String getToken(@NonNull Context context) {
-        try {
-            // read out AndroidManifest
-            PackageManager packageManager = context.getPackageManager();
-            ApplicationInfo appInfo = packageManager.getApplicationInfo(context.getPackageName(), PackageManager.GET_META_DATA);
-            String token = appInfo.metaData.getString(MapboxConstants.KEY_META_DATA_MANIFEST);
-            if (token == null || token.isEmpty()) {
-                throw new IllegalArgumentException();
-            }
-            return token;
-        } catch (Exception e) {
-            // use fallback on string resource, used for development
-            int tokenResId = context.getResources().getIdentifier("mapbox_access_token", "string", context.getPackageName());
-            return tokenResId != 0 ? context.getString(tokenResId) : null;
-        }
+    Drawable foregroundDrawable = options.getMyLocationForegroundDrawable();
+    Drawable foregroundBearingDrawable = options.getMyLocationForegroundBearingDrawable();
+    if (foregroundDrawable == null || foregroundBearingDrawable == null) {
+      if (foregroundDrawable == null) {
+        foregroundDrawable = ContextCompat.getDrawable(context, R.drawable.mapbox_mylocation_icon_default);
+      }
+      if (foregroundBearingDrawable == null) {
+        foregroundBearingDrawable = ContextCompat.getDrawable(context, R.drawable.mapbox_mylocation_icon_bearing);
+      }
+      options.myLocationForegroundDrawables(foregroundDrawable, foregroundBearingDrawable);
     }
 
-    /**
-     * Called when the fragment view hierarchy is created.
-     *
-     * @param view               The content view of the fragment
-     * @param savedInstanceState THe saved instance state of the framgnt
-     */
-    @Override
-    public void onViewCreated(View view, Bundle savedInstanceState) {
-        super.onViewCreated(view, savedInstanceState);
-        map.onCreate(savedInstanceState);
+    if (options.getMyLocationBackgroundDrawable() == null) {
+      options.myLocationBackgroundDrawable(ContextCompat.getDrawable(context, R.drawable.mapbox_mylocation_bg_shape));
     }
 
-    /**
-     * Called when the fragment is visible for the users.
-     */
-    @Override
-    public void onStart() {
-        super.onStart();
-        map.onStart();
-        map.getMapAsync(onMapReadyCallback);
-    }
-
-    /**
-     * Called when the fragment is ready to be interacted with.
-     */
-    @Override
-    public void onResume() {
-        super.onResume();
-        map.onResume();
-    }
-
-    /**
-     * Called when the fragment is pausing.
-     */
-    @Override
-    public void onPause() {
-        super.onPause();
-        map.onPause();
-    }
-
-    /**
-     * Called when the fragment state needs to be saved.
-     *
-     * @param outState The saved state
-     */
-    @Override
-    public void onSaveInstanceState(@NonNull Bundle outState) {
-        super.onSaveInstanceState(outState);
-        map.onSaveInstanceState(outState);
-    }
-
-    /**
-     * Called when the fragment is no longer visible for the user.
-     */
-    @Override
-    public void onStop() {
-        super.onStop();
-        map.onStop();
-    }
-
-    /**
-     * Called when the fragment receives onLowMemory call from the hosting Activity.
-     */
-    @Override
-    public void onLowMemory() {
-        super.onLowMemory();
-        map.onLowMemory();
-    }
-
-    /**
-     * Called when the fragment is view hiearchy is being destroyed.
-     */
-    @Override
-    public void onDestroyView() {
-        super.onDestroyView();
-        map.onDestroy();
-    }
-
-    /**
-     * Sets a callback object which will be triggered when the MapboxMap instance is ready to be used.
-     *
-     * @param onMapReadyCallback The callback to be invoked.
-     */
-    public void getMapAsync(@NonNull final OnMapReadyCallback onMapReadyCallback) {
-        this.onMapReadyCallback = onMapReadyCallback;
+    return map = new MapView(inflater.getContext(), options);
+  }
+
+  /**
+   * <p>
+   * Returns the Mapbox access token set in the app resources.
+   * </p>
+   * It will first search the application manifest for a {@link MapboxConstants#KEY_META_DATA_MANIFEST}
+   * meta-data value. If not found it will then attempt to load the access token from the
+   * {@code res/raw/token.txt} development file.
+   *
+   * @param context The {@link Context} of the {@link android.app.Activity} or {@link android.app.Fragment}.
+   * @return The Mapbox access token or null if not found.
+   * @see MapboxConstants#KEY_META_DATA_MANIFEST
+   * @deprecated As of release 4.1.0, replaced by
+   * {@link com.mapbox.mapboxsdk.MapboxAccountManager#start(Context, String)}
+   */
+  @Deprecated
+  private String getToken(@NonNull Context context) {
+    try {
+      // read out AndroidManifest
+      PackageManager packageManager = context.getPackageManager();
+      ApplicationInfo appInfo = packageManager.getApplicationInfo(context.getPackageName(),
+        PackageManager.GET_META_DATA);
+      String token = appInfo.metaData.getString(MapboxConstants.KEY_META_DATA_MANIFEST);
+      if (token == null || token.isEmpty()) {
+        throw new IllegalArgumentException();
+      }
+      return token;
+    } catch (Exception exception) {
+      // use fallback on string resource, used for development
+      int tokenResId = context.getResources().getIdentifier("mapbox_access_token", "string", context.getPackageName());
+      return tokenResId != 0 ? context.getString(tokenResId) : null;
     }
+  }
+
+  /**
+   * Called when the fragment view hierarchy is created.
+   *
+   * @param view               The content view of the fragment
+   * @param savedInstanceState THe saved instance state of the framgnt
+   */
+  @Override
+  public void onViewCreated(View view, Bundle savedInstanceState) {
+    super.onViewCreated(view, savedInstanceState);
+    map.onCreate(savedInstanceState);
+  }
+
+  /**
+   * Called when the fragment is visible for the users.
+   */
+  @Override
+  public void onStart() {
+    super.onStart();
+    map.onStart();
+    map.getMapAsync(onMapReadyCallback);
+  }
+
+  /**
+   * Called when the fragment is ready to be interacted with.
+   */
+  @Override
+  public void onResume() {
+    super.onResume();
+    map.onResume();
+  }
+
+  /**
+   * Called when the fragment is pausing.
+   */
+  @Override
+  public void onPause() {
+    super.onPause();
+    map.onPause();
+  }
+
+  /**
+   * Called when the fragment state needs to be saved.
+   *
+   * @param outState The saved state
+   */
+  @Override
+  public void onSaveInstanceState(@NonNull Bundle outState) {
+    super.onSaveInstanceState(outState);
+    map.onSaveInstanceState(outState);
+  }
+
+  /**
+   * Called when the fragment is no longer visible for the user.
+   */
+  @Override
+  public void onStop() {
+    super.onStop();
+    map.onStop();
+  }
+
+  /**
+   * Called when the fragment receives onLowMemory call from the hosting Activity.
+   */
+  @Override
+  public void onLowMemory() {
+    super.onLowMemory();
+    map.onLowMemory();
+  }
+
+  /**
+   * Called when the fragment is view hiearchy is being destroyed.
+   */
+  @Override
+  public void onDestroyView() {
+    super.onDestroyView();
+    map.onDestroy();
+  }
+
+  /**
+   * Sets a callback object which will be triggered when the MapboxMap instance is ready to be used.
+   *
+   * @param onMapReadyCallback The callback to be invoked.
+   */
+  public void getMapAsync(@NonNull final OnMapReadyCallback onMapReadyCallback) {
+    this.onMapReadyCallback = onMapReadyCallback;
+  }
 }