diff options
author | Bruno de Oliveira Abinader <bruno@mapbox.com> | 2016-06-12 13:53:35 +0300 |
---|---|---|
committer | Bruno de Oliveira Abinader <bruno@mapbox.com> | 2016-06-13 23:32:05 +0300 |
commit | 4161d197fdb59587b3ef5deac321605fc911a2ab (patch) | |
tree | 0bf4fa48a4e42fac0afce07f099ebace3ff5a698 /include | |
parent | 92f605df326ac4b1f4dd65928d6350b97eea6096 (diff) | |
download | qtlocation-mapboxgl-4161d197fdb59587b3ef5deac321605fc911a2ab.tar.gz |
[tidy] Check modernize-pass-by-value
Ref: http://clang.llvm.org/extra/clang-tidy/checks/modernize-pass-by-value.html
Diffstat (limited to 'include')
-rw-r--r-- | include/mbgl/storage/offline.hpp | 6 | ||||
-rw-r--r-- | include/mbgl/storage/resource.hpp | 4 | ||||
-rw-r--r-- | include/mbgl/storage/response.hpp | 2 | ||||
-rw-r--r-- | include/mbgl/style/function.hpp | 4 | ||||
-rw-r--r-- | include/mbgl/style/transition_options.hpp | 4 | ||||
-rw-r--r-- | include/mbgl/util/geo.hpp | 4 |
6 files changed, 12 insertions, 12 deletions
diff --git a/include/mbgl/storage/offline.hpp b/include/mbgl/storage/offline.hpp index 990c8470bb..bbd8674e5a 100644 --- a/include/mbgl/storage/offline.hpp +++ b/include/mbgl/storage/offline.hpp @@ -27,7 +27,7 @@ class Tileset; */ class OfflineTilePyramidRegionDefinition { public: - OfflineTilePyramidRegionDefinition(const std::string&, const LatLngBounds&, double, double, float); + OfflineTilePyramidRegionDefinition(std::string, LatLngBounds, double, double, float); /* Private */ std::vector<CanonicalTileID> tileCover(SourceType, uint16_t tileSize, const Tileset&) const; @@ -200,8 +200,8 @@ private: friend class OfflineDatabase; OfflineRegion(int64_t id, - const OfflineRegionDefinition&, - const OfflineRegionMetadata&); + OfflineRegionDefinition, + OfflineRegionMetadata); const int64_t id; const OfflineRegionDefinition definition; diff --git a/include/mbgl/storage/resource.hpp b/include/mbgl/storage/resource.hpp index a75de380a1..31df069952 100644 --- a/include/mbgl/storage/resource.hpp +++ b/include/mbgl/storage/resource.hpp @@ -33,10 +33,10 @@ public: Required = true, }; - Resource(Kind kind_, const std::string& url_, optional<TileData> tileData_ = {}, Necessity necessity_ = Required) + Resource(Kind kind_, std::string url_, optional<TileData> tileData_ = {}, Necessity necessity_ = Required) : kind(kind_), necessity(necessity_), - url(url_), + url(std::move(url_)), tileData(std::move(tileData_)) { } diff --git a/include/mbgl/storage/response.hpp b/include/mbgl/storage/response.hpp index 83227573cf..6c79f5e181 100644 --- a/include/mbgl/storage/response.hpp +++ b/include/mbgl/storage/response.hpp @@ -49,7 +49,7 @@ public: std::string message; public: - Error(Reason, const std::string& = ""); + Error(Reason, std::string = ""); }; std::ostream& operator<<(std::ostream&, Response::Error::Reason); diff --git a/include/mbgl/style/function.hpp b/include/mbgl/style/function.hpp index da2659c76a..44ffa31079 100644 --- a/include/mbgl/style/function.hpp +++ b/include/mbgl/style/function.hpp @@ -12,8 +12,8 @@ public: using Stop = std::pair<float, T>; using Stops = std::vector<Stop>; - explicit Function(const Stops& stops_, float base_) - : base(base_), stops(stops_) {} + explicit Function(Stops stops_, float base_) + : base(base_), stops(std::move(stops_)) {} float getBase() const { return base; } const std::vector<std::pair<float, T>>& getStops() const { return stops; } diff --git a/include/mbgl/style/transition_options.hpp b/include/mbgl/style/transition_options.hpp index 87faff21f8..5803fe05c9 100644 --- a/include/mbgl/style/transition_options.hpp +++ b/include/mbgl/style/transition_options.hpp @@ -8,8 +8,8 @@ namespace style { class TransitionOptions { public: - TransitionOptions(const optional<Duration>& duration_ = {}, const optional<Duration>& delay_ = {}) - : duration(duration_), delay(delay_) {} + TransitionOptions(optional<Duration> duration_ = {}, optional<Duration> delay_ = {}) + : duration(std::move(duration_)), delay(std::move(delay_)) {} optional<Duration> duration; optional<Duration> delay; diff --git a/include/mbgl/util/geo.hpp b/include/mbgl/util/geo.hpp index 5db307e482..4af8906465 100644 --- a/include/mbgl/util/geo.hpp +++ b/include/mbgl/util/geo.hpp @@ -161,8 +161,8 @@ private: LatLng sw; LatLng ne; - LatLngBounds(const LatLng& sw_, const LatLng& ne_) - : sw(sw_), ne(ne_) {} + LatLngBounds(LatLng sw_, LatLng ne_) + : sw(std::move(sw_)), ne(std::move(ne_)) {} friend bool operator==(const LatLngBounds&, const LatLngBounds&); friend bool operator!=(const LatLngBounds&, const LatLngBounds&); |