summaryrefslogtreecommitdiff
path: root/expression-test
diff options
context:
space:
mode:
authorzmiao <miao.zhao@mapbox.com>2020-02-11 14:40:51 +0200
committerzmiao <miao.zhao@mapbox.com>2020-02-12 12:24:05 +0200
commit7fda6ecad3e1119995b1bb23257995f730ac2a23 (patch)
tree04b4afd335d21b3c49ca4c05b92db6d623af8468 /expression-test
parent4579e1d6c4cd01b1d1d0d5f7dfc44c2d2e6ec686 (diff)
downloadqtlocation-mapboxgl-7fda6ecad3e1119995b1bb23257995f730ac2a23.tar.gz
reserve vecotr capacity, fix for points within polygon
Address review findings/nit
Diffstat (limited to 'expression-test')
-rw-r--r--expression-test/expression_test_parser.cpp15
1 files changed, 7 insertions, 8 deletions
diff --git a/expression-test/expression_test_parser.cpp b/expression-test/expression_test_parser.cpp
index 0d414cc2c0..9edc3b9866 100644
--- a/expression-test/expression_test_parser.cpp
+++ b/expression-test/expression_test_parser.cpp
@@ -259,14 +259,13 @@ bool parseInputs(const JSValue& inputsValue, TestData& data) {
// Parse canonicalID
optional<CanonicalTileID> canonical;
if (evaluationContext.HasMember("canonicalID")) {
- assert(evaluationContext["canonicalID"].IsObject());
- assert(
- evaluationContext["canonicalID"].HasMember("z") && evaluationContext["canonicalID"]["z"].IsNumber() &&
- evaluationContext["canonicalID"].HasMember("x") && evaluationContext["canonicalID"]["x"].IsNumber() &&
- evaluationContext["canonicalID"].HasMember("y") && evaluationContext["canonicalID"]["y"].IsNumber());
- canonical = CanonicalTileID(evaluationContext["canonicalID"]["z"].GetUint(),
- evaluationContext["canonicalID"]["x"].GetUint(),
- evaluationContext["canonicalID"]["y"].GetUint());
+ const auto& canonicalIDObject = evaluationContext["canonicalID"];
+ assert(canonicalIDObject.IsObject());
+ assert(canonicalIDObject.HasMember("z") && canonicalIDObject["z"].IsNumber());
+ assert(canonicalIDObject.HasMember("x") && canonicalIDObject["x"].IsNumber());
+ assert(canonicalIDObject.HasMember("y") && canonicalIDObject["y"].IsNumber());
+ canonical = CanonicalTileID(
+ canonicalIDObject["z"].GetUint(), canonicalIDObject["x"].GetUint(), canonicalIDObject["y"].GetUint());
}
// Parse availableImages