diff options
| author | Anand Thakker <anandthakker@users.noreply.github.com> | 2018-07-03 17:17:39 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-07-03 17:17:39 -0400 |
| commit | cfd436c287f4209d0d994042452ccbb552a6bd28 (patch) | |
| tree | 6811590928d7ea19db8e8b3f9db8d1df54ba9965 /cmake | |
| parent | 840a5cf1207ed78df3302211a23d369dd3c12b89 (diff) | |
| download | qtlocation-mapboxgl-cfd436c287f4209d0d994042452ccbb552a6bd28.tar.gz | |
[core] Avoid blocking in Thread<Object> constructor (#12151)
* Introduce AspiringActor, EstablishedActor
This pair of objects represents the two-phase (parent-thread /
child-thread) construction that's needed to support constructing
Thread<Object> without blocking until the child thread is up and
running.
An `AspiringActor<O>` is responsible for:
- ownership of the actor's `Mailbox`
- allocating the memory for (but *not* constructing) the target object `O`
Using these two pieces--the mailbox and a stable address for `O`--an
`AspiringActor<O>` can accept messages for the target object, or provide
`ActorRef<O>`s that do so, before the object has actually been
constructed by the corresponding `EstablishedActor<O>`. (Such messages
are queued in the mailbox until after the object is constructed.)
This allows for an `AspiringActor<O>` to be created and safely used by a
thread other than the one on which the target object will (eventually)
live.
An `EstablishedActor<O>` is responsible for managing the lifetime of the
target object `O` and the open/closed state of the parent's `mailbox`.
The `O` object's lifetime is contained by that of its owning
`EstablishedActor<O>`: the `EstablishedActor` constructor executes the
`O` constructor via "placement new", constructing it at the address
provided by the parent `AspiringActor`, and the `~EstablishedActor`
destructor similarly executes the `~O` destructor (after closing the
mailbox). `EstablishedActor` should therefore live entirely on the
thread intended to own `O`.
* Remove Actor#{invoke,ask}
Diffstat (limited to 'cmake')
| -rw-r--r-- | cmake/core-files.cmake | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/cmake/core-files.cmake b/cmake/core-files.cmake index 66f569abc9..f4ee786df7 100644 --- a/cmake/core-files.cmake +++ b/cmake/core-files.cmake @@ -4,6 +4,8 @@ set(MBGL_CORE_FILES # actor include/mbgl/actor/actor.hpp include/mbgl/actor/actor_ref.hpp + include/mbgl/actor/aspiring_actor.hpp + include/mbgl/actor/established_actor.hpp include/mbgl/actor/mailbox.hpp include/mbgl/actor/message.hpp include/mbgl/actor/scheduler.hpp |