diff options
author | Ander Conselvan de Oliveira <ander.deoliveira@mapbox.com> | 2018-09-11 12:18:26 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-09-11 12:18:26 +0300 |
commit | 536652ca201ce59190ae5c41d1202372d28d6d6d (patch) | |
tree | 614fcebe06c337d048918a2f1ba3db185a392e76 /cmake/sqlite.cmake | |
parent | 06ff49dfb2574fe3d12e2a3cbcd2828be525fec5 (diff) | |
download | qtlocation-mapboxgl-536652ca201ce59190ae5c41d1202372d28d6d6d.tar.gz |
[build] Disable implicit fallthrough warnings for sqlite3 (#12855)
The sqlite3 source code has a lot of implicit fallthroughs in case
statements. They are documented with comments but even though gcc
provides options to use these comments to suppress the warnings, that's
not always reliable. For instance, it may fail if an #ifdef follows the
comment or if the comment is within a block scope used for a case.
With gcc version '(Ubuntu 7.3.0-16ubuntu3) 7.3.0' I get warnings similar
to the below:
../../../vendor/sqlite/src/sqlite3.c: In function ‘sqlite3_db_status’:
../../../vendor/sqlite/src/sqlite3.c:20251:10: error: this statement may fall through [-Werror=implicit-fallthrough=]
op = SQLITE_DBSTATUS_CACHE_WRITE+1;
So disable the implicit falltrhough warnings for that library. Note that
-Wno-error=implicit-fallthrough is not used to keep the build silent
since this is vendor library.
Diffstat (limited to 'cmake/sqlite.cmake')
-rw-r--r-- | cmake/sqlite.cmake | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/cmake/sqlite.cmake b/cmake/sqlite.cmake index 03841ea9b9..b099210c85 100644 --- a/cmake/sqlite.cmake +++ b/cmake/sqlite.cmake @@ -33,4 +33,5 @@ target_compile_definitions(sqlite target_compile_options(sqlite PRIVATE "-Wno-int-conversion" + PRIVATE "-Wno-implicit-fallthrough" ) |