diff options
| author | John Firebaugh <john.firebaugh@gmail.com> | 2015-11-20 16:09:58 -0800 |
|---|---|---|
| committer | John Firebaugh <john.firebaugh@gmail.com> | 2015-11-20 16:33:46 -0800 |
| commit | c4c3a19d85991b3c2703e7b6561d8c1a3fed3543 (patch) | |
| tree | 93b548f7fa3875ee149455a2d41ecd7027b3e547 /binding.gyp | |
| parent | 8a0bce780847546c161670420e4d0f1e3a6cbdca (diff) | |
| download | qtlocation-mapboxgl-c4c3a19d85991b3c2703e7b6561d8c1a3fed3543.tar.gz | |
[node] Allow GC in spite of reference loops through the request method
The following produces a reference cycle:
var map = new mbgl.Map({
request: function () { ... }
});
map has a reference to the request function, which has a reference to
its closure, which has a reference to map.
Storing a the map options in an internal field, rather than a Persistent,
allows V8 to collect the reference cycle when none of its members have
other references.
Diffstat (limited to 'binding.gyp')
| -rw-r--r-- | binding.gyp | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/binding.gyp b/binding.gyp index 98e0f4e1c3..6cf0d1cd6f 100644 --- a/binding.gyp +++ b/binding.gyp @@ -19,8 +19,6 @@ 'platform/node/src/node_mapbox_gl_native.cpp', 'platform/node/src/node_log.hpp', 'platform/node/src/node_log.cpp', - 'platform/node/src/node_file_source.hpp', - 'platform/node/src/node_file_source.cpp', 'platform/node/src/node_map.hpp', 'platform/node/src/node_map.cpp', 'platform/node/src/node_request.hpp', |