summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKonstantin Käfer <mail@kkaefer.com>2018-06-07 14:49:41 +0200
committerKonstantin Käfer <mail@kkaefer.com>2018-06-08 10:01:35 +0200
commitf7d0330456ef129211ad558eb11f220a3de716ec (patch)
treea4cbc6948cf5bdbf5c9ccecdda4477edff96840e
parenta3f26275baa5005141a59c1ce4fc0766c37d1ea8 (diff)
downloadqtlocation-mapboxgl-f7d0330456ef129211ad558eb11f220a3de716ec.tar.gz
[core] allow logging error codes and formatting strings at the same time
-rw-r--r--include/mbgl/util/logging.hpp4
-rw-r--r--src/mbgl/util/logging.cpp10
2 files changed, 10 insertions, 4 deletions
diff --git a/include/mbgl/util/logging.hpp b/include/mbgl/util/logging.hpp
index d072673e76..03db2d7462 100644
--- a/include/mbgl/util/logging.hpp
+++ b/include/mbgl/util/logging.hpp
@@ -67,8 +67,8 @@ public:
private:
static void record(EventSeverity severity, Event event, const std::string &msg);
- static void record(EventSeverity severity, Event event, const char* format, ...);
- static void record(EventSeverity severity, Event event, int64_t code);
+ static void record(EventSeverity severity, Event event, const char* format = "", ...);
+ static void record(EventSeverity severity, Event event, int64_t code, const char* format = "", ...);
static void record(EventSeverity severity, Event event, int64_t code, const std::string &msg);
// This method is the data sink that must be implemented by each platform we
diff --git a/src/mbgl/util/logging.cpp b/src/mbgl/util/logging.cpp
index 0552eb36cb..d322bd3670 100644
--- a/src/mbgl/util/logging.cpp
+++ b/src/mbgl/util/logging.cpp
@@ -38,8 +38,14 @@ void Log::record(EventSeverity severity, Event event, const char* format, ...) {
record(severity, event, -1, msg);
}
-void Log::record(EventSeverity severity, Event event, int64_t code) {
- record(severity, event, code, std::string());
+void Log::record(EventSeverity severity, Event event, int64_t code, const char* format, ...) {
+ va_list args;
+ va_start(args, format);
+ char msg[4096];
+ vsnprintf(msg, sizeof(msg), format, args);
+ va_end(args);
+
+ record(severity, event, code, std::string{ msg });
}
void Log::record(EventSeverity severity, Event event, int64_t code, const std::string &msg) {