summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTobrun <tobrun.van.nuland@gmail.com>2018-11-06 11:48:29 +0100
committerTobrun <tobrun@mapbox.com>2018-11-07 10:52:43 +0100
commit60531f12594560a5700d55a5d31e0bdedee6c911 (patch)
tree23f724a6b07c213318d996f777171ffada6cccdb
parent408a767c8478c66e7ce2be908a2d7a9a83270384 (diff)
downloadqtlocation-mapboxgl-60531f12594560a5700d55a5d31e0bdedee6c911.tar.gz
[android] - handle null getMapAsync invocations, deliver onMapReady only once
-rw-r--r--platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapView.java10
1 files changed, 8 insertions, 2 deletions
diff --git a/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapView.java b/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapView.java
index 5e0f3ba727..1997375f9e 100644
--- a/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapView.java
+++ b/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapView.java
@@ -1595,13 +1595,18 @@ public class MapView extends FrameLayout implements NativeMapView.ViewCallback {
}
}
+ /**
+ * Notify listeners, clear when done
+ */
private void onMapReady() {
if (onMapReadyCallbackList.size() > 0) {
- // Notify listeners, clear when done
Iterator<OnMapReadyCallback> iterator = onMapReadyCallbackList.iterator();
while (iterator.hasNext()) {
OnMapReadyCallback callback = iterator.next();
- callback.onMapReady(mapboxMap);
+ if (callback != null) {
+ // null checking required for #13279
+ callback.onMapReady(mapboxMap);
+ }
iterator.remove();
}
}
@@ -1636,6 +1641,7 @@ public class MapView extends FrameLayout implements NativeMapView.ViewCallback {
public void onDidFinishLoadingStyle() {
if (mapboxMap != null) {
if (initialLoad) {
+ initialLoad = false;
mapboxMap.onPreMapReady();
onMapReady();
mapboxMap.onPostMapReady();