summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJason Wray <jason@mapbox.com>2018-10-02 18:15:58 -0400
committerJason Wray <jason@mapbox.com>2018-10-03 13:32:02 -0400
commitcaa2c6d9becd3f9f0720501acdb48418c5ae5033 (patch)
tree01203ea001b73d077d5f496ec45070bd9480336e
parent146bce6de13b38cdc52eb2fe43af6279affee180 (diff)
downloadqtlocation-mapboxgl-caa2c6d9becd3f9f0720501acdb48418c5ae5033.tar.gz
[darwin] Rename 'make check-public-symbols' to darwin-check-public-symbols
-rw-r--r--Makefile4
-rw-r--r--circle.yml2
-rw-r--r--platform/ios/DEVELOPING.md2
-rw-r--r--platform/macos/DEVELOPING.md2
4 files changed, 5 insertions, 5 deletions
diff --git a/Makefile b/Makefile
index 25bbde1b3d..cff9a28e8d 100644
--- a/Makefile
+++ b/Makefile
@@ -280,8 +280,8 @@ style-code: darwin-style-code
darwin-update-examples:
node platform/darwin/scripts/update-examples.js
-.PHONY: check-public-symbols
-check-public-symbols:
+.PHONY: darwin-check-public-symbols
+darwin-check-public-symbols:
node platform/darwin/scripts/check-public-symbols.js macOS iOS
endif
diff --git a/circle.yml b/circle.yml
index 5fdbe89ef2..1def734e60 100644
--- a/circle.yml
+++ b/circle.yml
@@ -294,7 +294,7 @@ commands:
steps:
- run:
name: Check public symbols
- command: make check-public-symbols
+ command: make darwin-check-public-symbols
conditionally-skip-firebase:
diff --git a/platform/ios/DEVELOPING.md b/platform/ios/DEVELOPING.md
index 31d9e754e8..fa23a21f30 100644
--- a/platform/ios/DEVELOPING.md
+++ b/platform/ios/DEVELOPING.md
@@ -65,7 +65,7 @@ To add any Objective-C type, constant, or member to the iOS SDK’s public inter
To add an Objective-C class, protocol, category, typedef, enumeration, or global constant to the iOS maps SDK’s public interface:
-1. _(Optional.)_ Add the macro `MGL_EXPORT` prior to the declaration for classes and global constants when adding them in shared headers located in `platform/darwin`. To use this macro, include `MGLFoundation.h`. You can check whether all public symbols are exported correctly by running `make check-public-symbols`.
+1. _(Optional.)_ Add the macro `MGL_EXPORT` prior to the declaration for classes and global constants when adding them in shared headers located in `platform/darwin`. To use this macro, include `MGLFoundation.h`. You can check whether all public symbols are exported correctly by running `make darwin-check-public-symbols`.
1. _(Optional.)_ Add the type or constant’s name to the relevant category in the `custom_categories` section of [the jazzy configuration file](./jazzy.yml). This is required for classes and protocols and also recommended for any other type that is strongly associated with a particular class or protocol. If you leave out this step, the symbol will appear in an “Other” section in the generated HTML documentation’s table of contents.
1. _(Optional.)_ If the symbol would also be publicly exposed in the macOS maps SDK, consult [the companion macOS document](../macos/DEVELOPING.md#making-a-type-or-constant-public) for further instructions.
diff --git a/platform/macos/DEVELOPING.md b/platform/macos/DEVELOPING.md
index 8b7857cd62..2d64baf292 100644
--- a/platform/macos/DEVELOPING.md
+++ b/platform/macos/DEVELOPING.md
@@ -40,7 +40,7 @@ To add any Objective-C type, constant, or member to the macOS maps SDK’s publi
To add an Objective-C class, protocol, category, typedef, enumeration, or global constant to the macOS maps SDK’s public interface:
-1. _(Optional.)_ Add the macro `MGL_EXPORT` prior to the declaration for classes and global constants. To use this macro, include `MGLFoundation.h`. You can check whether all public symbols are exported correctly by running `make check-public-symbols`.
+1. _(Optional.)_ Add the macro `MGL_EXPORT` prior to the declaration for classes and global constants. To use this macro, include `MGLFoundation.h`. You can check whether all public symbols are exported correctly by running `make darwin-check-public-symbols`.
1. _(Optional.)_ Add the type or constant’s name to the relevant category in the `custom_categories` section of [the jazzy configuration file](./jazzy.yml). This is required for classes and protocols and also recommended for any other type that is strongly associated with a particular class or protocol. If you leave out this step, the symbol will appear in an “Other” section in the generated HTML documentation’s table of contents.
1. _(Optional.)_ If the symbol would also be publicly exposed in the iOS maps SDK, consult [the companion iOS document](../ios/DEVELOPING.md#making-a-type-or-constant-public) for further instructions.