summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMolly Lloyd <molly@mapbox.com>2018-09-26 19:45:44 -0700
committerMolly Lloyd <mollymerp@users.noreply.github.com>2018-10-03 13:09:23 -0700
commit8d895a178dec6d84141d6c3909c7a3e6717e740c (patch)
treed85cfb6ea00ab342c31874e4d87ca74827206ad2
parentddbd7d98ba005f8d63dff1f72e21f47349d98f62 (diff)
downloadqtlocation-mapboxgl-8d895a178dec6d84141d6c3909c7a3e6717e740c.tar.gz
[core] fix flickering caused by incorrect ClipIDs
we missed a check for RenderTile.needsClipping when generating the new ClipIDs for some tiles, resulting in incorrect clipping that caused flickering in some cases
-rw-r--r--src/mbgl/algorithm/generate_clip_ids_impl.hpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mbgl/algorithm/generate_clip_ids_impl.hpp b/src/mbgl/algorithm/generate_clip_ids_impl.hpp
index 6a316dcdad..fedab06022 100644
--- a/src/mbgl/algorithm/generate_clip_ids_impl.hpp
+++ b/src/mbgl/algorithm/generate_clip_ids_impl.hpp
@@ -64,7 +64,7 @@ void ClipIDGenerator::update(std::vector<std::reference_wrapper<Renderable>> ren
uint8_t count = 1;
for (auto& it : renderables) {
auto& renderable = it.get();
- if (!renderable.used) {
+ if (!renderable.used || !renderable.needsClipping) {
continue;
}
renderable.clip.mask |= mask;