summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBruno de Oliveira Abinader <bruno@mapbox.com>2019-02-19 23:11:50 +0200
committerBruno de Oliveira Abinader <bruno@mapbox.com>2019-02-26 11:02:11 +0200
commit4cb1e771721d5ccbdafc8f3389ffc8a8986fb0d7 (patch)
treef138dcd793762a56391494d5bba4cd93a877f5d5
parentc1771125443af559f4f584f12d8c1c4249b9409d (diff)
downloadqtlocation-mapboxgl-4cb1e771721d5ccbdafc8f3389ffc8a8986fb0d7.tar.gz
[core] Ensure 'isPanning' is true when panning a full round
-rw-r--r--src/mbgl/map/transform.cpp2
-rw-r--r--test/map/transform.test.cpp17
2 files changed, 18 insertions, 1 deletions
diff --git a/src/mbgl/map/transform.cpp b/src/mbgl/map/transform.cpp
index 5854eaea37..7d3c9d8b74 100644
--- a/src/mbgl/map/transform.cpp
+++ b/src/mbgl/map/transform.cpp
@@ -124,7 +124,7 @@ void Transform::easeTo(const CameraOptions& camera, const AnimationOptions& anim
const double startScale = state.scale;
const double startAngle = state.angle;
const double startPitch = state.pitch;
- state.panning = latLng != startLatLng;
+ state.panning = unwrappedLatLng != startLatLng;
state.scaling = scale != startScale;
state.rotating = angle != startAngle;
diff --git a/test/map/transform.test.cpp b/test/map/transform.test.cpp
index eb511a82da..7e98863400 100644
--- a/test/map/transform.test.cpp
+++ b/test/map/transform.test.cpp
@@ -468,6 +468,23 @@ TEST(Transform, Camera) {
ASSERT_DOUBLE_EQ(transform.getLatLng().longitude(), 0);
}
+TEST(Transform, IsPanning)
+{
+ Transform transform;
+
+ AnimationOptions easeOptions(Seconds(1));
+ easeOptions.transitionFrameFn = [&transform](double) {
+ ASSERT_TRUE(transform.getState().isPanning());
+ };
+
+ transform.resize({ 1000, 1000 });
+ transform.easeTo(CameraOptions().withCenter(LatLng(0, 360.0)), easeOptions);
+ transform.updateTransitions(transform.getTransitionStart() + Milliseconds(250));
+ transform.updateTransitions(transform.getTransitionStart() + Milliseconds(500));
+ transform.updateTransitions(transform.getTransitionStart() + Milliseconds(750));
+ transform.updateTransitions(transform.getTransitionStart() + transform.getTransitionDuration());
+}
+
TEST(Transform, DefaultTransform) {
struct TransformObserver : public mbgl::MapObserver {
void onCameraWillChange(MapObserver::CameraChangeMode) final {