summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJulian Rex <julian.rex@mapbox.com>2019-05-02 10:47:34 -0400
committerJulian Rex <julian.rex@mapbox.com>2019-05-02 10:47:34 -0400
commit54078f68584fb3ea609962d1c0e4e51d4ac4464a (patch)
tree0b3020d8f891224b29b952fccda75f1c3f5cb614
parent512ad1f8b40d1cd5f40f0dcaee362318e7a3c58c (diff)
downloadqtlocation-mapboxgl-54078f68584fb3ea609962d1c0e4e51d4ac4464a.tar.gz
[ios] Remove analysis warnings from reachability
-rw-r--r--platform/darwin/src/reachability.m22
1 files changed, 13 insertions, 9 deletions
diff --git a/platform/darwin/src/reachability.m b/platform/darwin/src/reachability.m
index 2030e7ef71..737145a8a7 100644
--- a/platform/darwin/src/reachability.m
+++ b/platform/darwin/src/reachability.m
@@ -100,6 +100,8 @@ static void TMReachabilityCallback(SCNetworkReachabilityRef target, SCNetworkRea
{
id reachability = [[self alloc] initWithReachabilityRef:ref];
+ CFRelease(ref);
+
return reachability;
}
@@ -113,6 +115,8 @@ static void TMReachabilityCallback(SCNetworkReachabilityRef target, SCNetworkRea
{
id reachability = [[self alloc] initWithReachabilityRef:ref];
+ CFRelease(ref);
+
return reachability;
}
@@ -149,13 +153,13 @@ static void TMReachabilityCallback(SCNetworkReachabilityRef target, SCNetworkRea
self = [super init];
if (self != nil)
{
- self.reachableOnWWAN = YES;
- self.reachabilityRef = ref;
+ _reachableOnWWAN = YES;
+ _reachabilityRef = CFRetain(ref);
// We need to create a serial queue.
// We allocate this once for the lifetime of the notifier.
- self.reachabilitySerialQueue = dispatch_queue_create("com.tonymillion.reachability", NULL);
+ _reachabilitySerialQueue = dispatch_queue_create("com.tonymillion.reachability", NULL);
}
return self;
@@ -165,15 +169,15 @@ static void TMReachabilityCallback(SCNetworkReachabilityRef target, SCNetworkRea
{
[self stopNotifier];
- if(self.reachabilityRef)
+ if(_reachabilityRef)
{
- CFRelease(self.reachabilityRef);
- self.reachabilityRef = nil;
+ CFRelease(_reachabilityRef);
+ _reachabilityRef = nil;
}
- self.reachableBlock = nil;
- self.unreachableBlock = nil;
- self.reachabilitySerialQueue = nil;
+ _reachableBlock = nil;
+ _unreachableBlock = nil;
+ _reachabilitySerialQueue = nil;
}
#pragma mark - Notifier Methods