diff options
| author | jmkiley <jordan.kiley@mapbox.com> | 2019-10-03 15:36:22 -0700 |
|---|---|---|
| committer | jmkiley <jordan.kiley@mapbox.com> | 2019-10-03 15:36:22 -0700 |
| commit | ce6f7bf320551aece7b9c2b85fba06e6f3f899ac (patch) | |
| tree | b93d7c5846a91ea46ee4f31855a840a02fa76217 | |
| parent | 6965fc310042dd6afd07e03baf9aff67d0f97ab6 (diff) | |
| download | qtlocation-mapboxgl-ce6f7bf320551aece7b9c2b85fba06e6f3f899ac.tar.gz | |
[ios] testing metrics
| -rw-r--r-- | Makefile | 2 | ||||
| -rw-r--r-- | circle.yml | 3 | ||||
| -rwxr-xr-x | platform/ios/scripts/metrics.sh | 12 | ||||
| -rwxr-xr-x | scripts/check_binary_size.js | 3 |
4 files changed, 13 insertions, 7 deletions
@@ -311,7 +311,7 @@ ios-integration-test: $(IOS_PROJ_PATH) .PHONY: ios-sanitize ios-sanitize: $(IOS_PROJ_PATH) - set -o pipefail && $(IOS_XCODEBUILD_SIM) -scheme 'CI' -enableThreadSanitizer YES -enableUndefinedBehaviorSanitizer YES test $(XCPRETTY) + set -o pipefail && $(IOS_XCODEBUILD_SIM) -scheme 'CI' -enableThreadSanitizer YES -enableUndefinedBehaviorSanitizer YES test $(XCPRETTY) -resultBundlePath $(IOS_PROJ_PATH)/$(XCPRETTY).xcresult .PHONY: ios-sanitize-address ios-sanitize-address: $(IOS_PROJ_PATH) diff --git a/circle.yml b/circle.yml index 66ebaf0226..7a99aa4aad 100644 --- a/circle.yml +++ b/circle.yml @@ -1268,6 +1268,9 @@ jobs: - run: name: Nitpick Darwin code generation command: scripts/nitpick/generated-code.js darwin + - run: + name: Record size + command: platform/ios/scripts/metrics.sh - save-dependencies - collect-xcode-build-logs - upload-xcode-build-logs diff --git a/platform/ios/scripts/metrics.sh b/platform/ios/scripts/metrics.sh index 080dce7427..5839fd002c 100755 --- a/platform/ios/scripts/metrics.sh +++ b/platform/ios/scripts/metrics.sh @@ -17,10 +17,10 @@ scripts/check_binary_size.js "build/ios/pkg/dynamic/Mapbox-stripped-x86_64" "iO # Track overall library size scripts/check_binary_size.js "build/ios/pkg/dynamic/Mapbox-stripped" "iOS Dynamic" - -if [[ $CIRCLE_BRANCH == master ]]; then - # Build source data for http://mapbox.github.io/mapbox-gl-native/metrics/binary-size/ - # and log binary sizes to metrics warehouse - scripts/publish_binary_size.js -fi +# +# if [[ $CIRCLE_BRANCH == master ]]; then +# # Build source data for http://mapbox.github.io/mapbox-gl-native/metrics/binary-size/ +# # and log binary sizes to metrics warehouse +# scripts/publish_binary_size.js +# fi diff --git a/scripts/check_binary_size.js b/scripts/check_binary_size.js index 73d6ab7508..24e74d7022 100755 --- a/scripts/check_binary_size.js +++ b/scripts/check_binary_size.js @@ -51,6 +51,9 @@ function getPriorSize() { const run = data.check_runs.find(run => run.name === name); if (!run) { console.log('No matching check found.'); + console.log('BROKEN') + console.log(data.JSON.stringify()) + console.log('BROKEN'); return Promise.resolve(null); } return +run.output.summary.match(/`.*` is (\d+) bytes/)[1]; |