diff options
| author | Thiago Marcos P. Santos <tmpsantos@gmail.com> | 2020-03-27 17:34:00 +0200 |
|---|---|---|
| committer | Thiago Marcos P. Santos <tmpsantos@gmail.com> | 2020-03-30 23:37:44 +0300 |
| commit | fc29ddc6c2267f7da83f8b69cfd52df6b8cdd4fa (patch) | |
| tree | 9d1e9121b3ff964ea87863a01010a9545449b9c7 | |
| parent | 1c5e0ee31e82115fe7d17b6a9cdbc568f8a145e2 (diff) | |
| download | qtlocation-mapboxgl-fc29ddc6c2267f7da83f8b69cfd52df6b8cdd4fa.tar.gz | |
[build] Make the code tidy!
Now the bot will fail when clang-tidy fails. All warnings are fatal.
| -rw-r--r-- | .clang-tidy | 31 | ||||
| -rw-r--r-- | circle.yml | 4 |
2 files changed, 31 insertions, 4 deletions
diff --git a/.clang-tidy b/.clang-tidy index aa9640c77f..7575d21780 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -1,4 +1,31 @@ -Checks: '-*,bugprone-*,clang-analyzer-*,google-*,modernize-*,performance-*,-clang-analyzer-osx.*,-google-readability-braces-around-statements,-google-readability-todo,-google-runtime-int,-google-runtime-references,-modernize-avoid-c-arrays' -WarningsAsErrors: 'bugprone-use-after-move,modernize-*,performance-*' +Checks: > + -*, + bugprone-*, + clang-diagnostic-*, + google-*, + misc-*, + modernize-*, + performance-*, + portability-*, + readability-*, + -bugprone-narrowing-conversions, + -google-build-using-namespace, + -google-readability-braces-around-statements, + -google-readability-todo, + -google-runtime-int, + -google-runtime-references, + -modernize-avoid-c-arrays, + -readability-braces-around-statements, + -readability-else-after-return, + -readability-implicit-bool-conversion, + -readability-magic-numbers, + -readability-named-parameter, + -readability-uppercase-literal-suffix + +WarningsAsErrors: '*' HeaderFilterRegex: '.*' FormatStyle: file + +CheckOptions: + - key: misc-non-private-member-variables-in-classes.IgnoreClassesWithAllMemberVariablesBeingPublic + value: '1' diff --git a/circle.yml b/circle.yml index bc91cca9c5..ba56b03b6b 100644 --- a/circle.yml +++ b/circle.yml @@ -684,8 +684,8 @@ jobs: - run: name: Clang Tidy command: | - run-clang-tidy-8 -quiet -j $(nproc) -p build $PWD/src/.*cpp $PWD/platform/.*cpp |tee clang-tidy.log - grep -o \\[[a-z].*-.*[a-z]\] clang-tidy.log |sort |uniq -c |sort -n + # FIXME: Run on the headers, add -header-filter='.*' + run-clang-tidy-8 -quiet -j $(nproc) -p build $PWD/src/.*cpp $PWD/platform/.*cpp - save baselines: executor: ubuntu-disco |