fallback gracefully on bad half float texture support

1 files changed, 18 insertions, 6 deletions

diff --git a/src/mbgl/renderer/layers/render_heatmap_layer.cpp b/src/mbgl/renderer/layers/render_heatmap_layer.cpp
index 8845670014..4717c224c8 100644
--- a/src/mbgl/renderer/layers/render_heatmap_layer.cpp
+++ b/src/mbgl/renderer/layers/render_heatmap_layer.cpp
@@ -55,10 +55,24 @@ void RenderHeatmapLayer::render(PaintParameters& parameters, RenderSource*) {
         const auto size = Size{viewportSize.width / 4, viewportSize.height / 4};
 
         if (!renderTexture || renderTexture->getSize() != size) {
-            const auto textureType = parameters.context.supportsHalfFloatTextures() ?
-                    gl::TextureType::HalfFloat : gl::TextureType::UnsignedByte;
-
-            renderTexture = OffscreenTexture(parameters.context, size, textureType);
+            if (parameters.context.supportsHalfFloatTextures()) {
+                renderTexture = OffscreenTexture(parameters.context, size, gl::TextureType::HalfFloat);
+
+                try {
+                    renderTexture->bind();
+                } catch (const std::runtime_error& ex) {
+                    // can't render to a half-float texture; falling back to unsigned byte one
+                    renderTexture = nullopt;
+                }
+            }
+
+            if (!renderTexture) {
+                renderTexture = OffscreenTexture(parameters.context, size, gl::TextureType::UnsignedByte);
+                renderTexture->bind();
+            }
+
+        } else {
+            renderTexture->bind();
         }
 
         if (!colorRampTexture) {
@@ -67,8 +81,6 @@ void RenderHeatmapLayer::render(PaintParameters& parameters, RenderSource*) {
                                                                 gl::TextureType::UnsignedByte, colorRamp.data());
         }
 
-        renderTexture->bind();
-
         parameters.context.clear(Color{ 0.0f, 0.0f, 0.0f, 1.0f }, {}, {});
 
         for (const RenderTile& tile : renderTiles) {