diff options
| author | Chloe Krawczyk <chloe.krawczyk@mapbox.com> | 2019-12-12 18:50:05 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-12-12 18:50:05 -0800 |
| commit | 74e03e7d3c10144418929aec322f9610b2c21b49 (patch) | |
| tree | 4e13906b83627be33cab6a822d1cb56d6834c556 | |
| parent | 8b9a4571a4b72b7b4f4e5584a0fabca192964533 (diff) | |
| download | qtlocation-mapboxgl-74e03e7d3c10144418929aec322f9610b2c21b49.tar.gz | |
Create PULL_REQUEST_TEMPLATE.md
I adapted the pr template from @mapbox/gl-js as a proposal.
Main motivation is to add
> - [ ] tagged `@mapbox/maps-android @mapbox/maps-ios` if this PR adds or updates a public API
so the mobile teams can be tagged if there is a new feature we should be aware of.
Items from the js template I excluded:
> - [ ] post benchmark scores
> - [ ] manually test the debug page
> - [ ] tagged `@mapbox/studio` and/or `@mapbox/map-design-team` if this PR includes style spec or visual changes
Anything else we want to add to the launch checklist for mapbox-gl-native? @tmpsantos @zugaldia @brunoabinader
cc @mapbox/gl-native @mapbox/core-sdk @mapbox/maps-ios @mapbox/maps-android
| -rw-r--r-- | PULL_REQUEST_TEMPLATE.md | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 0000000000..13e73a8112 --- /dev/null +++ b/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,11 @@ +## Launch Checklist + +<!-- Thanks for the PR! Feel free to add or remove items from the checklist. --> + + - [ ] briefly describe the changes in this PR + - [ ] include before/after visuals or gifs if this PR includes visual changes + - [ ] write tests for all new functionality + - [ ] document any changes to public APIs + - [ ] tagged `@mapbox/maps-android @mapbox/maps-ios` if this PR adds or updates a public API + - [ ] tagged `@mapbox/gl-js` if this PR includes shader changes or needs a js port + - [ ] apply `needs changelog` label if a changelog is needed (remove label when added) |